From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39241C02181 for ; Mon, 20 Jan 2025 19:58:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C5C4280003; Mon, 20 Jan 2025 14:58:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 97614280002; Mon, 20 Jan 2025 14:58:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86422280003; Mon, 20 Jan 2025 14:58:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 688BB280002 for ; Mon, 20 Jan 2025 14:58:29 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CA9B116030E for ; Mon, 20 Jan 2025 19:58:28 +0000 (UTC) X-FDA: 83028892296.20.5774BE1 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf20.hostedemail.com (Postfix) with ESMTP id C3E961C0002 for ; Mon, 20 Jan 2025 19:58:26 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lfA80iep; spf=pass (imf20.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737403106; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eNwTgvblIXqUyPc7mK/O3md4cgLWoRIPuqtdilgqwyw=; b=5t3MnmQy6Z9dUMHMxQCOOZ2nA02dPzLRu0ESrYFCtfNaItJDu9U2FaavBHMatqBx5fXgog ff9xOlb8QG2wqJ5L2CwDbr0ZRszCmzlPE4QEgvUT8Dny4MJyeH5M88FrBDjqO7NNVFa2sB nEevlPDZaHsed2xM9/8J1ms0bHe5ILs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737403106; a=rsa-sha256; cv=none; b=sIJviGycf4SCc7Tnj8aiYb44+UGbV/yKefgRoN/G8bcBeJUwZrk4KndQtYyEPGUlUIIpCO 7zEQKZJfg9niFNnYxLOu6j3qVhrwWlA2c6DdD9CeqB2eT7OYAsEmk88yxz5TStJ5MsXfoe O+9qer6iIZGjux86wflftzFsgTk65nE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lfA80iep; spf=pass (imf20.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-435f8f29f8aso34765165e9.2 for ; Mon, 20 Jan 2025 11:58:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737403105; x=1738007905; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eNwTgvblIXqUyPc7mK/O3md4cgLWoRIPuqtdilgqwyw=; b=lfA80ieph1PmfnXAkz0QEVs6tlXdSD0IynLgPZKUwGanCJXZ2HNiPDzWGQuiHIBu/G eE15fTSfEBGid0AkPmZm7gqrO2WfMe7R+qyY1WXJ/2CZLTjNWGB2uupMT1BTw8iEtyqI ygzq3tL72n/qlnKemo/deXmF0hgciZi4qHugjinqyS7Uux8vdR4F3q1mWNtwmcGPBisf PuKTT24ldyc0n/sn2aNOEnZadfmVM4fUeVg73iav8e3TCdqrlYbIibxbUBqnU9R5JEv6 OE/Oh9Q5BMzbFAapZR6nWwtTE/Eehp9lNPKwQRw3Tb8SJpYczCg49+rv7P/12VsLtvFf yGUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737403105; x=1738007905; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eNwTgvblIXqUyPc7mK/O3md4cgLWoRIPuqtdilgqwyw=; b=omhEMjItnY0d8Y7RGZerDmt7KZrWo7hRkyefb2I0G5PSy8KNMKJz1Jp9ovH44dqSDr OHvklyjKW9qznglqDJ39OSaBHXF0KELRUPqXnHeS8yuYQ674VfnqRLusNrPUjpa0n+TS o5sG8UOQlyoVOkvQOHTQqc0+W4Qw95rVjHWO24GVaY3h2HY+73yx/2Eio1Sg3jqe0oiP +P5xmpPA+NZTJg79MvqVrCkVt2auh4GxpdCdMN1gd9bZZbnbYdoZ/l/L4xSag3VgQll3 okBG9/0640snfxQnNYao0hvQ5e3+XDJF/tvB5a6PaIJVt2j61TE5cxG2WTEaYFqvrgkQ jI4Q== X-Forwarded-Encrypted: i=1; AJvYcCVKVo+3wnX0RgQw0DwqaBLDOrwGgFj2+ipNXNRg08sB7hvbYAAOtPtZhDCq4zb8V7yxsB2Jd3B5Bg==@kvack.org X-Gm-Message-State: AOJu0YxOBkPIVEvrGHY4PQRxqYj8NgcJhuW6DcvMWMRp36vacOgKVFyI XuXEa6opJUf/ElZqTcgwP/tw2gob8oxNOYjZl+0z+q5jVXTc5vAs X-Gm-Gg: ASbGncsSiHs43v8XL8Y6DktInjdSIW9DG34/994VKu0j0yWAPjVwCIMSvwLgU6ZhaWx zKYMzlY8sZ50hxpxWd8DTFiDCVtStkuXbfgW5FOK/JjZumCqhboXPzsuSQkab5XWNHzp28rwTrm L5/ODQf+7OgKPEDPFEcJ1mhGk2qE4W1MhLjfGX1KC1Id7q34Lo9h5mxW4Ku6oByMsnq8vZzfkTD gj9EcInYvv3uvxbZArwrpsy+YE/XOoSoaR47sciKv2O97vXrIb3Q6jD1TwHzCjbvyk1CvMobIOD XF5bVEQkmY10Fj1fNVkzUqCqHFZJDXaaQBCBey8oVmqiJQW8l69P4IOxXJ48MBg= X-Google-Smtp-Source: AGHT+IES1vFbC8JEv/m8I2R6/D+UPpqV5H59IGLii8I4aWuKOJjnIGt4yCCngYKpUZ3AjzL4SGrXog== X-Received: by 2002:a05:600c:4f48:b0:42c:b16e:7a22 with SMTP id 5b1f17b1804b1-438913cb740mr147762525e9.12.1737403105265; Mon, 20 Jan 2025 11:58:25 -0800 (PST) Received: from ?IPV6:2a02:6b67:d752:5f00:c46:86ac:45ea:7590? ([2a02:6b67:d752:5f00:c46:86ac:45ea:7590]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c1664e8dsm164208845e9.1.2025.01.20.11.58.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 11:58:25 -0800 (PST) Message-ID: <3b461f19-45b7-4e74-969d-1cdf4d324353@gmail.com> Date: Mon, 20 Jan 2025 19:58:24 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] mm/damon: introduce DAMOS filter type hugepage To: SeongJae Park , David Hildenbrand Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org References: <20250120193015.38753-1-sj@kernel.org> Content-Language: en-US From: Usama Arif In-Reply-To: <20250120193015.38753-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: mn4un3jmi7xei894a4ya5whuph6mffb7 X-Rspamd-Queue-Id: C3E961C0002 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1737403106-394748 X-HE-Meta: U2FsdGVkX1+nWdypi8mn6Z4c/mScFasFtBMDITxSJLoB0iUFsH4LKG401/o8ie9VC/6wE9qzW7gtdjficBlcODEzyxmey7DzXNzECGbsbYEJibMbwVNGVJOJoYqlS0LHoibcWKL/jsLfLQR4u3O9PY0QSaDBskjTHcVXcH4igxP6I0SO2zABPGeypMDOQotFZVpjYB+5lTVX7zNluJ3da6fJKLLNwmaTU68kzuFlxxdahTiYbjf6AXOQFAOM9Ca4HzfRmQ2utUrABdpjruARyUSV8q/QmqCfWETeDLfTBxBkXyM386Xha/fQwevrPtCNK/uhpQMUdsUo9NXmIAjBObdRduqdTEz/YFqKZAekTGj8dXdY937528RmmaFY6X5KlQEKmA8Rmf7pML2hHM3s57HlOiBMcH5bmRXqcXl4+w9iNUVQk5DPe313sbgbV0Ltg7ALFwXEIMd0Xpewy8HEMDMobrrd2JowsIyy7ZRHB8sAK/BYKzxzJ3Q4kRM0Padb7lUGck6aXOLXvpUdzdYA51NxdZBP3ww+WBYZSyxht5p4aNLldZhbCG3487WtZBzYHT/fmBkf6uE4JD60xtI6TotNBahXQW5WUlh6e5LdUTsqkWlYutEqO5iZmlnAdcNUqt9Nt8BqJSKvIMRg47uHQ6ssXfo1qE41j21TNXmgSQvR+1ylyzzi3TZnGcV28XUxjhQYyRQDwHXNRfUhFCx7AlaRMdHdLbuQtSy0MTMISIz8AkNZbi/vEZQeCWmKjSEqsVwCimu0Q/0kuoR0NFnaQdgHvNWCpTzZCVwTQlcJ1J5D/389hF+C1p7Kd2svfK+NAtvOYondlzIQP79m8Z0GtjJ7FsuoEJaBWzJeF6V4GbTwEFCbtv6pmxSWuP+77vbY8l+BOkEHB2nZAwrxOf0sjj0hqfcM5Q8XUFdXB21LCNHgdyfOxAUgoKeDnXWPZpusQjHYxQdMTmSrsieI51y KtyqIWsV OqPUpzWjkTnYlw49bM4eod7VENg8daCM9EJ+1oOArwGujioyDnttoMAmM/K9Q8xMg75q35VYvK/3Eizo5NUthimZNPUDVrZaOGgFqv2gma2nAzTTGlDHLWdWSw0mstgahsMlbeEeG7oYf7+Ehu+nApQzSNAIHfLp7bxbSTi0X6NdZeUhu622P8ttBc4vLR4YdrCqEO84XouSPwkMWTgf/tY34W5m9yfqYOln4OM1SNLRMHt68A3ZyzPmfeHHXu3sc73sSq/nhEZF5YhbPmboYP6gFqHZk51KYTCDUJoP6zWRWVJzwxi4YRcdgp8l75KQPz9bSZghKA7LgJcsjcBUvQWf8oE6STyp9sUYo/xzqmLL1qLKi5dwu+A/oohyHCIWBZozmMhCLTBOB35WL5MRpkl1o9UAdIuNcshEJh4onQj+2kUrN5HJx3d6gTQ7DjiyIL5HVfarhFEcsK67PoRDSMUvBwr5nHBbe6ECAwz/p8zVsMk0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.110443, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20/01/2025 19:30, SeongJae Park wrote: > On Mon, 20 Jan 2025 20:23:20 +0100 David Hildenbrand wrote: > >> On 20.01.25 20:16, SeongJae Park wrote: >>> On Mon, 20 Jan 2025 19:57:10 +0100 David Hildenbrand wrote: >>> >>>> On 20.01.25 19:19, Usama Arif wrote: > [...] >>>>> +#if defined(CONFIG_PGTABLE_HAS_HUGE_LEAVES) >>>>> + case DAMOS_FILTER_TYPE_HUGEPAGE: >>>>> + matched = folio_size(folio) == HPAGE_PMD_SIZE; >>>> >>>> >>>> Can we directly embed in the name and the comments/docs that we are only >>>> talking about PMD size (both, THP and hugetlb)? >>>> >>>> DAMOS_FILTER_TYPE_PMD_HUGEPAGE or sth. like that. >>> >>> Nice suggestion, thank you! And we might later add more filter types for >>> different size huge pages. What about extending this to handle more general >>> case, though? That is, we can let the filter receives a range of the folio >>> size to match, like DAMOS_FILTER_TYPE_ADDR does. Then, the filter could be >>> used for any size of interest. >> >> That would probably be future proof: either a range or explicitly >> specified sizes (ranges?). > > DAMON supports installing multiple DAMOS filters. So multiple DAMOS filters > that each matching single range can be used for the multiple sizes or ranges > use case. > > Does creating something like schemes//access_pattern/page_size/{min,max} sound good? with the default value being pmd size?