From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AC3BC433EF for ; Mon, 6 Sep 2021 12:02:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0524761004 for ; Mon, 6 Sep 2021 12:02:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0524761004 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 94BC06B0071; Mon, 6 Sep 2021 08:02:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F9BA6B0072; Mon, 6 Sep 2021 08:02:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C1E46B0073; Mon, 6 Sep 2021 08:02:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0081.hostedemail.com [216.40.44.81]) by kanga.kvack.org (Postfix) with ESMTP id 6EC996B0071 for ; Mon, 6 Sep 2021 08:02:58 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2BBB18249980 for ; Mon, 6 Sep 2021 12:02:58 +0000 (UTC) X-FDA: 78557012436.27.5F31A47 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id D18D5B0000B1 for ; Mon, 6 Sep 2021 12:02:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630929777; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=frAukOYVGtOJ1Dxa66lVEbsorbkE/tBlVsVnTX50G4U=; b=Io2anc8B6mfjGC79LUyOOpvtvvjjiPMJr1laSSFDtUHgTYY93cDlN3rLtSu6xWtVbbe00T 3PD623DcSXf1Zz7dD7In3xehqYQVSfIhq+oCYSbO4wrg36RRCT0kxpAmpLvf23Rgk+Q6UE UXEoY873utqxwfR8cBLiPo6p9sAX4x0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-286-Y2bAvhbtMViu7GCinuBgew-1; Mon, 06 Sep 2021 08:02:55 -0400 X-MC-Unique: Y2bAvhbtMViu7GCinuBgew-1 Received: by mail-wr1-f71.google.com with SMTP id n1-20020a5d4c41000000b00159305d19baso1144979wrt.11 for ; Mon, 06 Sep 2021 05:02:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=frAukOYVGtOJ1Dxa66lVEbsorbkE/tBlVsVnTX50G4U=; b=M8/NDmYpN/y3vSyV8GuwfNh7evNc9shPacO2E1qeDffJF8v3lM67LTitNKUO5BlM0P 2tDmCILafjp3jWWnYvNI4GBsAiDKXWzMUhYl9HCWd/m7/WsVo5StFCNqjDsMJ2BjHBil PLUVTrjUdhtcbrA66XdzNMVRJctRrAzCGRPqh9ES+isC185EqBqMl8Ka6OyZiFKPiTwG vb8Bdw0ojU5t9f5Y0okyI0oPueenrSmuFlNebw7NoOJcLqj2z5RiaMw0bwzA+sFgPNSC zSjDzcUta2kxlOHd99ugITdWtC30MqrToBQ7HjAEB2utRKWbgaDA2o4/53PxLBsV65bV XCiw== X-Gm-Message-State: AOAM530X05wFm/WwwdnFf99q63lOIA87vN/3ugkwIgFt+RPiNeeWKdMs FMZmx9i2k21YVfFbaFvJGB5rrPmofbCbtcamTVftkD8NUWOrWcFHyz8QedRn+08mCtCjl0MBaZP BjazrEWN8W5s= X-Received: by 2002:adf:df0c:: with SMTP id y12mr13034291wrl.155.1630929774421; Mon, 06 Sep 2021 05:02:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhKhtm32LcEgWkjl3X4v4Wu0VKN7KkWyfSQxdUPJRD/eW1BxpQQtgWjoFber1coF0YiWqYaA== X-Received: by 2002:adf:df0c:: with SMTP id y12mr13034275wrl.155.1630929774260; Mon, 06 Sep 2021 05:02:54 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6323.dip0.t-ipconnect.de. [91.12.99.35]) by smtp.gmail.com with ESMTPSA id p5sm8179521wrd.25.2021.09.06.05.02.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Sep 2021 05:02:53 -0700 (PDT) Subject: Re: [PATCH] mm/page_isolation: don't putback unisolated page To: Miaohe Lin , akpm@linux-foundation.org Cc: vbabka@suse.cz, iamjoonsoo.kim@lge.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210904091839.20270-1-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat Message-ID: <3b36529f-ab97-ddfe-0407-66f0cd1fd38d@redhat.com> Date: Mon, 6 Sep 2021 14:02:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210904091839.20270-1-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Io2anc8B; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf19.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D18D5B0000B1 X-Stat-Signature: ds4mpscc4x9sy7i563oy9juwpcewddgq X-HE-Tag: 1630929777-256858 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04.09.21 11:18, Miaohe Lin wrote: > If __isolate_free_page() failed, due to zone watermark check, the page is > still on the free list. But this page will be put back to free list again > via __putback_isolated_page() now. This may trigger page->flags checks in > __free_one_page() if PageReported is set. Or we will corrupt the free list > because list_add() will be called for pages already on another list. > > Fixes: 3c605096d315 ("mm/page_alloc: restrict max order of merging on isolated pageblock") > Signed-off-by: Miaohe Lin > --- > mm/page_isolation.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > index 9bb562d5d194..7d70d772525c 100644 > --- a/mm/page_isolation.c > +++ b/mm/page_isolation.c > @@ -93,10 +93,8 @@ static void unset_migratetype_isolate(struct page *page, unsigned migratetype) > buddy_pfn = __find_buddy_pfn(pfn, order); > buddy = page + (buddy_pfn - pfn); > > - if (!is_migrate_isolate_page(buddy)) { > - __isolate_free_page(page, order); > - isolated_page = true; > - } > + if (!is_migrate_isolate_page(buddy)) > + isolated_page = !!__isolate_free_page(page, order); > } > } > > Thanks! Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb