From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>, linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-block@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-efi@vger.kernel.org, virtualization@lists.linux.dev,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Subject: Re: [PATCH v3 5/7] powerpc: Stop calling page_address() in free_pages()
Date: Thu, 4 Sep 2025 09:10:01 +0200 [thread overview]
Message-ID: <3b333f4e-9817-4a5b-bf0a-f8a9d33575e9@csgroup.eu> (raw)
In-Reply-To: <20250903185921.1785167-6-vishal.moola@gmail.com>
Le 03/09/2025 à 20:59, Vishal Moola (Oracle) a écrit :
> free_pages() should be used when we only have a virtual address. We
> should call __free_pages() directly on our page instead.
>
> Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
> Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
> arch/powerpc/mm/book3s64/radix_pgtable.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/mm/book3s64/radix_pgtable.c b/arch/powerpc/mm/book3s64/radix_pgtable.c
> index be523e5fe9c5..73977dbabcf2 100644
> --- a/arch/powerpc/mm/book3s64/radix_pgtable.c
> +++ b/arch/powerpc/mm/book3s64/radix_pgtable.c
> @@ -780,7 +780,7 @@ static void __meminit free_vmemmap_pages(struct page *page,
> while (nr_pages--)
> free_reserved_page(page++);
> } else
> - free_pages((unsigned long)page_address(page), order);
> + __free_pages(page, order);
> }
>
> static void __meminit remove_pte_table(pte_t *pte_start, unsigned long addr,
next prev parent reply other threads:[~2025-09-04 7:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 18:59 [PATCH v3 0/7] Cleanup free_pages() misuse Vishal Moola (Oracle)
2025-09-03 18:59 ` [PATCH v3 1/7] mm/page_alloc: Add kernel-docs for free_pages() Vishal Moola (Oracle)
2025-09-03 18:59 ` [PATCH v3 2/7] aoe: Stop calling page_address() in free_page() Vishal Moola (Oracle)
2025-09-03 18:59 ` [PATCH v3 3/7] x86: Stop calling page_address() in free_pages() Vishal Moola (Oracle)
2025-09-04 11:51 ` Mike Rapoport
2025-09-04 11:54 ` Mike Rapoport
2025-09-05 18:02 ` Vishal Moola (Oracle)
2025-09-03 18:59 ` [PATCH v3 4/7] riscv: " Vishal Moola (Oracle)
2025-09-04 12:27 ` Alexandre Ghiti
2025-09-03 18:59 ` [PATCH v3 5/7] powerpc: " Vishal Moola (Oracle)
2025-09-04 7:10 ` Christophe Leroy [this message]
2025-09-03 18:59 ` [PATCH v3 6/7] arm64: " Vishal Moola (Oracle)
2025-09-03 18:59 ` [PATCH v3 7/7] virtio_balloon: " Vishal Moola (Oracle)
2025-09-03 19:13 ` David Hildenbrand
2025-09-04 21:38 ` Michael S. Tsirkin
2025-09-04 11:55 ` [PATCH v3 0/7] Cleanup free_pages() misuse Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b333f4e-9817-4a5b-bf0a-f8a9d33575e9@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=ritesh.list@gmail.com \
--cc=virtualization@lists.linux.dev \
--cc=vishal.moola@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox