From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63375C7EE2E for ; Fri, 9 Jun 2023 14:39:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C13216B0072; Fri, 9 Jun 2023 10:39:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9C9D8E0003; Fri, 9 Jun 2023 10:39:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A15BD8E0002; Fri, 9 Jun 2023 10:39:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8DBDF6B0072 for ; Fri, 9 Jun 2023 10:39:13 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 54AF7A0222 for ; Fri, 9 Jun 2023 14:39:13 +0000 (UTC) X-FDA: 80883466986.27.8ED41C5 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf01.hostedemail.com (Postfix) with ESMTP id EF1A54000C for ; Fri, 9 Jun 2023 14:39:10 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="ODZm/S6k"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0Bl4ggUN; dmarc=none; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686321551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O+nq2sVFNvU6nyWExPnHDrSk7SL7j6fMmlV/ftm6VIU=; b=Qcd2s5cOPBqxRiKh/Nxr7lpdMoFBd+FGroFyLD9clLCBrUsRHRPyIutkMfXcXRoRXa5oHp qnoXbWWCh/+s0sjVzcHgypqRcxKK9tQ68WsToiyTEUGJa9YIzO9SoiazwvLEMGJLhosOUn YaTWnysU1GyxOtHGk2Vx+tnfUs6g4Os= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="ODZm/S6k"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0Bl4ggUN; dmarc=none; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686321551; a=rsa-sha256; cv=none; b=sk72U3EZtRwJhQEZ9Lxsqy6S1rGu7sggFaMcUFTZiZEDkec5NORbfqZvP7LDQCmjKquXQW FKlKTB0H5UJ2I3NtDH4hBOPnKxeLSl1JpA7ub5KlKoMLDTiR6vRpGjn5e0iT5Bg5TQOPPD bLUhwcA+J+fIsRBdw5vDyW6WtgHDeHM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7981A218E8; Fri, 9 Jun 2023 14:39:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1686321549; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O+nq2sVFNvU6nyWExPnHDrSk7SL7j6fMmlV/ftm6VIU=; b=ODZm/S6k31XYx+UCgoj7RzO3oZFNknYltRACUNBh5M4wtGImi+QiMGTDk8gi1vrICkOq5w b1rG3dINTJz4oB9ka0qLpAkaBqVtBwhhpKERhdAywR/C5Zpb57ZJuq+N/CXuKJyKhGPrDd VCk+tqXsjxxOzq5OoPxbGdqNpNL/7As= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1686321549; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O+nq2sVFNvU6nyWExPnHDrSk7SL7j6fMmlV/ftm6VIU=; b=0Bl4ggUNIl7d0gyZnuB8rmdlsXkGQqNVlYeBQhcny6DxjGyGMsb8BkIKydQr80ttblBIdh 7SOD0umVHOv90FBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1162713A47; Fri, 9 Jun 2023 14:39:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9Ax0A405g2RUcgAAMHmgww (envelope-from ); Fri, 09 Jun 2023 14:39:09 +0000 Message-ID: <3b2c5414-7623-c4a8-1a24-1c8e1ced0387@suse.cz> Date: Fri, 9 Jun 2023 16:39:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v6 16/17] mm: slab: Reduce the kmalloc() minimum alignment if DMA bouncing possible Content-Language: en-US To: Catalin Marinas , Linus Torvalds , Christoph Hellwig , Robin Murphy Cc: Arnd Bergmann , Greg Kroah-Hartman , Will Deacon , Marc Zyngier , Andrew Morton , Herbert Xu , Ard Biesheuvel , Isaac Manjarres , Saravana Kannan , Alasdair Kergon , Daniel Vetter , Joerg Roedel , Mark Brown , Mike Snitzer , "Rafael J. Wysocki" , Jonathan Cameron , linux-mm@kvack.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin References: <20230531154836.1366225-1-catalin.marinas@arm.com> <20230531154836.1366225-17-catalin.marinas@arm.com> From: Vlastimil Babka In-Reply-To: <20230531154836.1366225-17-catalin.marinas@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EF1A54000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: sqmgf56ut61mh49jfe7bpc159r6g5wz5 X-HE-Tag: 1686321550-869619 X-HE-Meta: U2FsdGVkX1/ZavDdYjWE9dx1oi78DH1BFHwm2GEvctqyhOSjg6Ze2j3vd/pjsyp4dj0s+9BvjD4iiAWro4jTjIEm45mfl/OGZgGxy0pR95snZFPq4TNZgVyMWRy/eNoqeJxSKiubiJScRG97YhZcemjcIH6LLScEsgqhlFM6u0TIFBBEoZqLB6Crvdn8GeG8Gvfqze3feb4W43eZC7Nf5rvDLD7GzvoA7pjlwkcEfGWN7JhXYSOGydJMS3Bw41iho57JPquJwiUPnEFuE4j+3KKAy7RSXM9DIDwHKcUwzf8zfPk+5OOXrfh2kYXaGsCmeo4sM7dfRN5P+DmsGBZj9Z+zFOmVEUkTlCubH9Ppg7NRKQwEBycubmJzBWhH3jk/pECPL3fo87No4gn+lu/QmYwTxZN3jsPBc7LjSclwf4IzOwOkOwO2aLeCno5gjxKUqdVWTfFBpApfpbqlEE9Iq/66btGSNc2m6hHQJ3Q6TYc55hRPdiT+wGxFQO5zsnPLAHgUJzaBT/NTog0cHZN+qD4EsLTBRdmHXgenRgeVCN8OAU2rXe5cHMMkUe8O2pAlPDg9KrB8ICIDv9E9pvM+a7GWp9C4+sgdvw3GR/SPHUH+AUZmjJIi4TDhAtIONvaPXxB5jTf5H34Wd5COEyFRxMaxZftet5fJEQVoFuaLjbIOk6osb9+6dLrMSundP75bSCEtJ8HEA5+B1T5261KXg1pae79lLAhU/D64cBRaOlfFbwd+kQRYhHeUs5we3ra8w3oor/iREugbMSvjNeuHwqymeFIUvOBlul4LVzQifaeShYK7fVq+d3Cw8vTnQGamODX5aEW36MdwjcyPywYgY4FCFABCnYrqMJR9ULmDsOTWHtzcduuGd/xgJVh37MZOyghOs+yDXN4A1lxh+N3ULu8Ij8bpUB2rqmNxbo9nhMzLPJRvEq3fGy4vcVe+lio+KiEqfPU+mOvfSuYMO7V jfSHIrQ+ YIm0jpF7BuIE9ZSP1g13oNBxJ0b9VtvsJrGOZRmzIx5gr/L6yQjH9ULSSFiHElVWi2vq08ZgIIK2bwCO7B2lyr3SFzeLja5SFwPE9UdcgjLHurtP6PZYFZIXoGm2J3TPnV+z59HhleSHxvay2fpzvJDJ4ONsvLBKjHx9QrgCgazrtkgKvWjyUUMG1BMIbEL4zROV/dS1gqP9a2+mHdlfgSTObU0rspRNz4AMvWyCWdzW6KZksoXGfObNQ4QbB8ga+oD1DCNU+kCTFksT14DDJ0uTf/CTvm77hk9icSChFdpBzCZ6X/2HPRzognyU8N9iePc8poHg68azGMueiuq3XrDeHmhDMb/1FTdC0ucB9liCSwJkwbGM9xtliCt4fq3aMam/Cw5r/MQA8BPQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/31/23 17:48, Catalin Marinas wrote: > If an architecture opted in to DMA bouncing of unaligned kmalloc() > buffers (ARCH_WANT_KMALLOC_DMA_BOUNCE), reduce the minimum kmalloc() > cache alignment below cache-line size to ARCH_KMALLOC_MINALIGN. > > Signed-off-by: Catalin Marinas Reviewed-by: Vlastimil Babka Nit below: > Cc: Andrew Morton > Cc: Christoph Hellwig > Cc: Robin Murphy > --- > mm/slab_common.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 7c6475847fdf..fe46459a8b77 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -863,10 +864,19 @@ void __init setup_kmalloc_cache_index_table(void) > } > } > > +#ifdef CONFIG_DMA_BOUNCE_UNALIGNED_KMALLOC > +static unsigned int __kmalloc_minalign(void) > +{ > + if (io_tlb_default_mem.nslabs) > + return ARCH_KMALLOC_MINALIGN; > + return dma_get_cache_alignment(); > +} > +#else > static unsigned int __kmalloc_minalign(void) > { > return dma_get_cache_alignment(); > } > +#endif Should be enough to put the #ifdef around the two lines into a single implementation of the function? > void __init > new_kmalloc_cache(int idx, enum kmalloc_cache_type type, slab_flags_t flags) >