From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED7CBC3F2CD for ; Wed, 4 Mar 2020 08:13:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C55622166E for ; Wed, 4 Mar 2020 08:13:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C55622166E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 750096B0005; Wed, 4 Mar 2020 03:13:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FF586B0007; Wed, 4 Mar 2020 03:13:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 645B56B0005; Wed, 4 Mar 2020 03:13:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0212.hostedemail.com [216.40.44.212]) by kanga.kvack.org (Postfix) with ESMTP id 4B9ED6B0005 for ; Wed, 4 Mar 2020 03:13:58 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1545F180AD802 for ; Wed, 4 Mar 2020 08:13:58 +0000 (UTC) X-FDA: 76556966556.01.blood05_5cc125f423f34 X-HE-Tag: blood05_5cc125f423f34 X-Filterd-Recvd-Size: 2197 Received: from out4436.biz.mail.alibaba.com (out4436.biz.mail.alibaba.com [47.88.44.36]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Mar 2020 08:13:57 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R691e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=14;SR=0;TI=SMTPD_---0TrcoXXb_1583309623; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0TrcoXXb_1583309623) by smtp.aliyun-inc.com(127.0.0.1); Wed, 04 Mar 2020 16:13:44 +0800 Subject: Re: [PATCH v9 04/20] mm/thp: move lru_add_page_tail func to huge_memory.c To: "Kirill A. Shutemov" Cc: cgroups@vger.kernel.org, akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <1583146830-169516-1-git-send-email-alex.shi@linux.alibaba.com> <1583146830-169516-5-git-send-email-alex.shi@linux.alibaba.com> <20200304074719.e6unbgdop2r3jhk2@box> From: Alex Shi Message-ID: <3b18a429-25fd-df28-1bf3-57bcd38c6cd8@linux.alibaba.com> Date: Wed, 4 Mar 2020 16:13:43 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200304074719.e6unbgdop2r3jhk2@box> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =D4=DA 2020/3/4 =CF=C2=CE=E73:47, Kirill A. Shutemov =D0=B4=B5=C0: > On Mon, Mar 02, 2020 at 07:00:14PM +0800, Alex Shi wrote: >> The func is only used in huge_memory.c, defining it in other file with= a >> CONFIG_TRANSPARENT_HUGEPAGE macro restrict just looks weird. >> >> Let's move it close user. >=20 > I don't think it's strong enough justification. I would rather keep all > lru helpers in one place. >=20 Thanks for comments, Kirill, If it's a common used func, yes. But if you look into details of this func, it's thp used only func.=20 Thanks Alex