From: Charan Teja Kalla <quic_charante@quicinc.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: <surenb@google.com>, <vbabka@suse.cz>, <rientjes@google.com>,
<sfr@canb.auug.org.au>, <edgararriaga@google.com>,
<minchan@kernel.org>, <nadav.amit@gmail.com>, <mhocko@suse.com>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2,0/2]mm: madvise: return correct bytes processed with process_madvise
Date: Tue, 15 Mar 2022 19:56:05 +0530 [thread overview]
Message-ID: <3b1626e7-3a32-5733-2a4f-e782c87b8e58@quicinc.com> (raw)
In-Reply-To: <20220311134203.47cbeab087b731bada12d0f1@linux-foundation.org>
Thanks Andrew!!
On 3/12/2022 3:12 AM, Andrew Morton wrote:
>> With the process_madvise(), always choose to return non zero processed
>> bytes over an error. This can help the user to know on which VMA, passed
>> in the 'struct iovec' vector list, is failed to advise thus can take the
>> decission of retrying/skipping on that VMA.
> Thanks, this is not good.
>
> We should have added userspace tests for process_madvise() along with
> the syscall itself. But evidently that was omitted. If someone
> decides to contribute such tests, hopefully they will include checks
> for these return values.
We are happy to contribute here.
>
prev parent reply other threads:[~2022-03-15 14:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 15:29 Charan Teja Kalla
2022-03-11 15:29 ` [PATCH V2,1/2] mm: madvise: return correct bytes advised " Charan Teja Kalla
2022-03-15 22:20 ` Minchan Kim
2022-03-21 15:18 ` Michal Hocko
2022-03-11 15:29 ` [PATCH V2,2/2] mm: madvise: skip unmapped vma holes passed to process_madvise Charan Teja Kalla
2022-03-15 22:58 ` Minchan Kim
2022-03-15 23:48 ` Andrew Morton
2022-03-16 1:43 ` Minchan Kim
2022-03-16 14:19 ` Charan Teja Kalla
2022-03-16 21:29 ` Andrew Morton
2022-03-17 16:28 ` Minchan Kim
2022-03-17 16:53 ` Suren Baghdasaryan
2022-03-17 20:38 ` Nadav Amit
2022-03-18 14:05 ` Charan Teja Kalla
2022-03-18 15:37 ` Minchan Kim
2022-03-17 16:24 ` Minchan Kim
2022-03-21 15:02 ` Michal Hocko
2022-03-22 5:19 ` Charan Teja Kalla
2022-03-21 15:34 ` Michal Hocko
2022-03-22 7:10 ` Charan Teja Kalla
2022-03-22 8:40 ` Michal Hocko
2022-03-11 21:42 ` [PATCH V2,0/2]mm: madvise: return correct bytes processed with process_madvise Andrew Morton
2022-03-15 14:26 ` Charan Teja Kalla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b1626e7-3a32-5733-2a4f-e782c87b8e58@quicinc.com \
--to=quic_charante@quicinc.com \
--cc=akpm@linux-foundation.org \
--cc=edgararriaga@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=nadav.amit@gmail.com \
--cc=rientjes@google.com \
--cc=sfr@canb.auug.org.au \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox