From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49A48C3DA59 for ; Tue, 16 Jul 2024 09:10:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB8056B0083; Tue, 16 Jul 2024 05:10:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B40366B0088; Tue, 16 Jul 2024 05:10:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E0986B0089; Tue, 16 Jul 2024 05:10:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7E7656B0083 for ; Tue, 16 Jul 2024 05:10:48 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CCA9040425 for ; Tue, 16 Jul 2024 09:10:47 +0000 (UTC) X-FDA: 82345045734.07.2FEDB81 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf25.hostedemail.com (Postfix) with ESMTP id 294CEA000F for ; Tue, 16 Jul 2024 09:10:45 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721121026; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cdHdqCXET9f96mST6Na7/80N3pUYrTJZ6hrAFWMjScw=; b=EfE/uJzwvFWqGWbyoy77MYHBXVR4pLHg6MtbesbkmGgchimEYjSleI7zPPDD5JnIJKl1RW 4REug8lX6MFiyQqp2L3aqEvXJyBuNqHTcEaJRIqfbOBC4aNQUshzGNdlh2BhKT9EqGxqJA 7w1OQo1SNbKnmw9qPu0emoUnBxLoTMM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721121026; a=rsa-sha256; cv=none; b=EN1Zo58OGVpLVnLSE8yb/LTxKv39LMXZSb5GK820mpPjRQ9hYXMLy+qzZkz1v0ZL00Z/v+ Xe3/3D97pYg7iXg8LQH9PXHdc4vQvuvEdBdaqvi1R7XkX5TCWCyhQchZJlqVYJ0hX0qpmV nltudsp1G4uOx2q6rs+PyWdaS0dOaII= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8B54F1063; Tue, 16 Jul 2024 02:11:10 -0700 (PDT) Received: from [10.163.52.225] (unknown [10.163.52.225]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 675003F762; Tue, 16 Jul 2024 02:10:34 -0700 (PDT) Message-ID: <3b04d3b6-1e78-456b-a377-2c6b2a72e4bd@arm.com> Date: Tue, 16 Jul 2024 14:40:29 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 14/29] arm64: mask out POIndex when modifying a PTE To: Joey Gouly , linux-arm-kernel@lists.infradead.org Cc: akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-15-joey.gouly@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20240503130147.1154804-15-joey.gouly@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 294CEA000F X-Stat-Signature: dk584wgmt1xtngiqc9y1xwtdz8k7yzu6 X-Rspam-User: X-HE-Tag: 1721121045-687263 X-HE-Meta: U2FsdGVkX1+NnTzcEjQ1HPG7ptzQs+F7Dc8xt5a7ULfzwiRbGJ5fg1V69ZKMjt8f8bIYif7wS7wJO1E5FRFA7hGOsor6AoqGAGLOjHnc1i8ffrkjbRqr2g1bidhkCzh9jZ7aG45ohFoarqvMUSqaJr6mnQmLGUyaPNm+MdiAEpvSfU2qVheziyP1wkdUjJfAaMdgwYhqYUvesjfLrk4wviYTl8gZQMxX0fxGItikVhYHxYQ3rE0zGrm2XuP7qPiZXEmGBRt4FjsZYvZuQsm0Azg6sjy2ygl0qDwgIAwKSKzb1mCXjmb4bxq/sKzmlenRZPcIo5BPpgakC9ICK2ubu/D3Rifdm2mEov7Fa8FkSeA5OxB1c76j5jM9RWVbSgkPH7Rn/Dce9zLPkHOnrLSUialFwiS0kRY5cqmm1OE5rDryrhodcCJUQLLduKTQ/TcJ9MtSPm+M/jiAVEeGEibdaoznzpIJgpb2FBX20jmMDncYYYTza/+eXzJ4TSkv1ydh6i9AJ0SWxkgu633jBvraRvE1PT8H0vr/OyfbroSFwfTemytx9z1tUQ6ab+pZ/x+AO7Bl/40i/SgxZHCo1zAd4vLhzCb7yKEYC7z+H94rSnM7Hgh60Gu5KNfbG8M4KRZZWGrkVdX6DkiwgGiPIRDGtkZ4E56tJIkfv7RdvitKZxTvRcd9pcW2votylVUnmuxFWJGU20loMyYHP1t5qId6wJmAUYFSE6HGOFbCLoiE92V/RyAxwxI1JUawlMAfNwXEKATYFJwco5CIGtSUomSXRBLqMJMbsAzQ5U+NXKhjuAtLcEPZzN6TZE3FVzLoPBzT5w73vnpZ6TuOkJ1COFJEXn40PJJwNh2A05XUt2sI7dx0x0aWN027pFMlBJzcFKVuuqw8Zo0BzaDxSCN2wWAPHnQn0rmKc7qS0LEF+I3Bn0cyLTT6el0E1yZTYWlgyLwJ+KQSf0UxHYX1w71HEXK Rbej0+kq 1xSDb7p9RvlR198vxDIRQ3YHL2Ila1iySx9gzx/NfBU+FXGwHptOlKvofjH2besmDPH455GcoZ4B1wh/1VDZkPMhOBQHvO7ahRVAc2jCv1jgwB05uiLr7eiGQdZCCSpfsTmdQcaBOqodkV/N0YsVd05278aBcwKhrXcT4XTVfWLBOTp7CA7qK5yPL0GyELPK8GEsZcCY/ruvU1d4t7HeTa4Rb26VRW7uN39rvyzeMo/G0RLzpxbxJeJHK+he9iB3+nyiucDS7OQeYXJY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/3/24 18:31, Joey Gouly wrote: > When a PTE is modified, the POIndex must be masked off so that it can be modified. > > Signed-off-by: Joey Gouly > Cc: Catalin Marinas > Cc: Will Deacon > Reviewed-by: Catalin Marinas Reviewed-by: Anshuman Khandual > --- > arch/arm64/include/asm/pgtable.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index afdd56d26ad7..5c970a9cca67 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -1028,7 +1028,8 @@ static inline pte_t pte_modify(pte_t pte, pgprot_t newprot) > */ > const pteval_t mask = PTE_USER | PTE_PXN | PTE_UXN | PTE_RDONLY | > PTE_PROT_NONE | PTE_VALID | PTE_WRITE | PTE_GP | > - PTE_ATTRINDX_MASK; > + PTE_ATTRINDX_MASK | PTE_PO_IDX_MASK; > + > /* preserve the hardware dirty information */ > if (pte_hw_dirty(pte)) > pte = set_pte_bit(pte, __pgprot(PTE_DIRTY));