From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E91EFC25B78 for ; Tue, 4 Jun 2024 01:16:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 459756B0082; Mon, 3 Jun 2024 21:16:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 409C76B0085; Mon, 3 Jun 2024 21:16:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D11C6B0088; Mon, 3 Jun 2024 21:16:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 109D36B0082 for ; Mon, 3 Jun 2024 21:16:36 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 80739160AB4 for ; Tue, 4 Jun 2024 01:16:35 +0000 (UTC) X-FDA: 82191441150.19.3EC7902 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf07.hostedemail.com (Postfix) with ESMTP id 173154000E for ; Tue, 4 Jun 2024 01:16:31 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of xiujianfeng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=xiujianfeng@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717463793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D29i35bHuRrirhpEpz5yWNCBKNTeKq/usJGkkqug000=; b=g8FHc2PfQuHiFaTo0Fn34ilnxL+zvLAy76cr2TnR1zB/RAcs12HloZsGmxBklNlNuM7V57 GdwtfYed8FBAEpPP3zz88gEHKN1Un9/S+ch9E7uatl5uDaV9+LwNjdmXgJYaH0eF10exN0 /fzMF7QmkTEkwedRnMQthd0dwbTuD8U= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of xiujianfeng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=xiujianfeng@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717463793; a=rsa-sha256; cv=none; b=NqEViZDgFHJF3sQ9uADrJFKzP544ZiTagrJhIuy06R9qtT01HdxTFwlLEpu7jN+fSK8+QP cjDOBQMMqEwjO6b9sU+ZanItHLTTFrtSZb1656Xt70tbTJNCyD7zR78gGz9GPSIld9ELNl isp36l5Z9rUqFzFnBMfI4a9uiPsmIY4= Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4VtXdD3dyczxPxC; Tue, 4 Jun 2024 09:12:32 +0800 (CST) Received: from dggpeml500023.china.huawei.com (unknown [7.185.36.114]) by mail.maildlp.com (Postfix) with ESMTPS id BBEE9140109; Tue, 4 Jun 2024 09:16:27 +0800 (CST) Received: from [10.67.110.112] (10.67.110.112) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 4 Jun 2024 09:16:27 +0800 Message-ID: <3b030437-4571-7a87-55e0-5fc3f5711a6e@huawei.com> Date: Tue, 4 Jun 2024 09:16:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH -next 2/3] mm/hugetlb_cgroup: prepare cftypes based on template Content-Language: en-US To: kernel test robot , , CC: , , References: <20240603120506.1837322-3-xiujianfeng@huawei.com> <202406040437.z2Iel9db-lkp@intel.com> From: xiujianfeng In-Reply-To: <202406040437.z2Iel9db-lkp@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.110.112] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500023.china.huawei.com (7.185.36.114) X-Rspamd-Queue-Id: 173154000E X-Stat-Signature: 3mtnymrdkbpg9he3fcwrtaoayjoomf1x X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1717463791-641498 X-HE-Meta: U2FsdGVkX1+bcHj/n8nEP3Whxa5yBpMgM+r0SVgLM3y5Otg0Y1UM3/MGyFLpKUUIyqAnKTdBT1l4onhUuuxTVFZS7yqS8FZgLUw9Ty7Wo4/09lh41l1Qjih8aWfQ6kZ0NFMRIx2FpmRHbO1Gz7n7J/4v9fS7C7RRoVoH1DPl5n6MSQquIi1aPJIW9vSVUS5BSEIlERq8JVNNQtwCSoDjY6rNIElQAeMQS47xOxxFVsiD3IPuJ/tU5JO82vEZYBzL4EpsaW70RqnH+sbHAXBYKihbtZnkdPRw8eaYcQ3GMC0G86Se8bhp1reQ3ZFIaJM8jwnG3A4ogq4QKBLoQwfnhF4MU6LJZZKYBf4PaVlT6Y7iqJNTnqX/AmfCCEi/eLThB3JkenMkBAgRKZF2zDCWBm4L5XWef2n3QmGpLWbiQgOdjpcdWxb/SBYjeMDkq/KNroKXRYsdChwrgAoA4R/rGW+HdZE/2kaxMQ7CXT4pP1ZKRi9mvCk/HZDGLic8V1EgBnKkrN0nRPj9dxjfXs5tDem4sOYFBHDJU6hE0vliCSG3JWHu2JQPQoSFkpgDBI3WQPYgV5FVnlwCs0yO6ybv93ypxD0/nTcAVWEBRaN5HMvkn7+M+s8hLbnxX2Um9mAKMHXDAvOT6A6z48jRR0KuRxt9OUwWtem4rUj46U03X58ZifnkJS3ConmwSMPen+KQ12E7qHDbb9T6pgx9XYtUKPy/uy10CrIUg64ZyaDAXpdJCeK3ucp0fkZsTQwrA5qYRkTMreb7bZJjWDlKDpQXj4cZKEHeQNcOMJ9tmBVEBktnWFr/eRQbgtW9VgoYaFMsyyAJfbC6sdAlzMsQ83g+ICXeJwg1r4zwag764O9cjNhRQbTWg83tuzZO9wg16yMXBVMWv/zNPnx0c2N//gtaTQGnbDBghrOVeesCRrRoLUIBMJfRjk3uBM46Rv5UZ700mrht94v9Uw7qvjctrWU BcdIrjEo GUfLJquE1qcuRxUe/DKeQEdLERvUkHd6EIdQnhDSMYElY1j0kieRqWtYVgpQrHETedqfHizz6376Bmr0sAerOJVtE3V6Mq3V2rWNiZRUDHFKitAVlB+Sw7rsMlQhwavGi5M2RO/6X57uqd5RJ9jm1WAou4UWTFoTjh/AdmLQ3B9r9LvglIWbyenvTjs5H2eQRYzpHcG3GtTYAo7sqkDE0gMRsHa+Pz3lAYF9WA007MTG5xWTOyk3pr8VzvyEhS6tjJJ36HTATU5k5lTGaLahw5ow0cPwG1xtOQSZsnIP0B/0rb3bxL6P2Kc3mimVOpq08hLoDJ02ZZOk5MakjN8PLTjwUDIIPqBTw6G10QA8UB7k7Ij9/YzYVG0Ce5Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/4 5:25, kernel test robot wrote: > Hi Xiu, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on akpm-mm/mm-everything] > > url: https://github.com/intel-lab-lkp/linux/commits/Xiu-Jianfeng/mm-hugetlb_cgroup-identify-the-legacy-using-cgroup_subsys_on_dfl/20240603-201513 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20240603120506.1837322-3-xiujianfeng%40huawei.com > patch subject: [PATCH -next 2/3] mm/hugetlb_cgroup: prepare cftypes based on template > config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240604/202406040437.z2Iel9db-lkp@intel.com/config) > compiler: aarch64-linux-gcc (GCC) 13.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240604/202406040437.z2Iel9db-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202406040437.z2Iel9db-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > mm/hugetlb_cgroup.c: In function 'hugetlb_cgroup_cfttypes_init': >>> mm/hugetlb_cgroup.c:828:21: warning: the comparison will always evaluate as 'true' for the address of 'name' will never be NULL [-Waddress] > 828 | if (tmpl->name) > | ^~~~ > In file included from include/linux/cgroup.h:27, > from mm/hugetlb_cgroup.c:20: > include/linux/cgroup-defs.h:605:14: note: 'name' declared here > 605 | char name[MAX_CFTYPE_NAME]; > | ^~~~ > Thanks, will fix in the next version. > > vim +828 mm/hugetlb_cgroup.c > > 814 > 815 static void __init > 816 hugetlb_cgroup_cfttypes_init(struct hstate *h, struct cftype *cft, > 817 struct cftype *tmpl, int tmpl_size) > 818 { > 819 char buf[32]; > 820 int i, idx = hstate_index(h); > 821 > 822 /* format the size */ > 823 mem_fmt(buf, sizeof(buf), huge_page_size(h)); > 824 > 825 for (i = 0; i < tmpl_size; cft++, tmpl++, i++) { > 826 *cft = *tmpl; > 827 /* rebuild the name */ > > 828 if (tmpl->name) > 829 snprintf(cft->name, MAX_CFTYPE_NAME, "%s.%s", buf, tmpl->name); > 830 /* rebuild the private */ > 831 if (tmpl->private) > 832 cft->private = MEMFILE_PRIVATE(idx, tmpl->private); > 833 /* rebuild the file_offset */ > 834 if (tmpl->file_offset) { > 835 unsigned int offset = tmpl->file_offset; > 836 > 837 cft->file_offset = MEMFILE_OFFSET0(offset) + > 838 MEMFILE_FIELD_SIZE(offset) * idx; > 839 } > 840 } > 841 } > 842 >