From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC273D7877C for ; Thu, 21 Nov 2024 15:04:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4ADDD6B0088; Thu, 21 Nov 2024 10:04:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 45D506B0089; Thu, 21 Nov 2024 10:04:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FE856B008A; Thu, 21 Nov 2024 10:04:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 119386B0088 for ; Thu, 21 Nov 2024 10:04:47 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9BBEAC0BC1 for ; Thu, 21 Nov 2024 15:04:46 +0000 (UTC) X-FDA: 82810423668.14.EF51354 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 7EB8A1C0029 for ; Thu, 21 Nov 2024 15:04:20 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YQwl+4SB; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732201298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3Nq1kII2UB+9ENt//6WMlEnfZsLsEAnBwTFsduCKCB8=; b=i7LUr8vMBAfLTbh3E6h3nAdBZ6Gw0AOIXTx6/DxhCcgd5BMiF90pzQDuBQuMTTs8FX4TZu EcM6OkYiQ4Gq1xKPnSnav58j+mRUSCzFdpO5l+WwywPXjxz3O42bzRu41pAC48W70cNjo2 a4cZkGHDciqVhFu3ni3tzeIbiVrSkP8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YQwl+4SB; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732201298; a=rsa-sha256; cv=none; b=nxGoT49Ap3wOzT4obReOHoe14RJ4BKAca6Sno7/w/2yJhv+hVmZRQfxYYe98DhaNkdXSTO gTSsz6RJovb1GCZFQvnYf4IVKXhw7e1wz9h5eWbgh2cJOvz4wNqWslSmcDwN1jyqmxDdtb of3CO3zgXfBzd4lemZkGYI10yLj+fzI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732201483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3Nq1kII2UB+9ENt//6WMlEnfZsLsEAnBwTFsduCKCB8=; b=YQwl+4SBhWCVXIQuVcWS2G0DY7O9KHr5Ftq/57dKOOT+ptKxOVk4Z0g1axamjv3CLgM02G vCoyMLii5HljxrR8bXPYNLrTzNyJQ/lhFFzXyMG9JiX2LgPaRvY7K9T9dbBKvYLSsYy3af 9hQbOwWvTH4f8j2WDfbbe9XrtzeLqh0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-694-avthi0gGMYyiK8yT_zL6sQ-1; Thu, 21 Nov 2024 10:04:39 -0500 X-MC-Unique: avthi0gGMYyiK8yT_zL6sQ-1 X-Mimecast-MFC-AGG-ID: avthi0gGMYyiK8yT_zL6sQ Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-431518e6d8fso7438775e9.0 for ; Thu, 21 Nov 2024 07:04:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732201478; x=1732806278; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3Nq1kII2UB+9ENt//6WMlEnfZsLsEAnBwTFsduCKCB8=; b=WDJbfKBOyOl7LD28zRCzC5jKEP3cZNn0F1S3z1IdN7ffK1KEotq1iFUJcCzwo9txx3 KqpYaIQ80ImiE3YffWm2UU9i+TXLv8giV9ifjxB4Uv+lG+jIPPNNYnK1xZDY0/Yx8HGp jVtj4xBcDHjTURLwtTSUyPAEpnRz1Dzway5YONi1BxS4HSmpwoCw7sbP7NtTTi6N2y1e r8e6EvB6Xhvey86eOcrwgsW1shpEnGtkjgjAVfatYXaPj2yJUXazx1FVfX+CqiKrpxRi 1aI3Jd5bsSadqFa9vFdqVmrSJtNH8lVTqCPGAIvRih6Dfm6m8TrzKkOhVHNhbpfG9FwX CJ5w== X-Forwarded-Encrypted: i=1; AJvYcCVFHM2mGsG3FiV5s+SHO6ltnfxtHpZOOeXfTr7cOtzq5vYuo1Qqak12xEaE8u2onI04iQj+YRaYIg==@kvack.org X-Gm-Message-State: AOJu0Yx0HUwaaIWQ38SDnFSL9xSzcI0so9b50Y/4h/hudTPAYszcxFIJ TjH5bJaTTwLnRIos6ks1mFjgeBfBSVdci6XnN4hyFytESSDyt3G0jMxxvX7vLCav5y6PvONzNwX cBqqJYRqoo592xo0PszBguh7LcxlT2let9ED4+NU7f3iYSBVR X-Gm-Gg: ASbGncs36tQQxIMwIH66cB8VnvjgeZuBBjKwS8l3daHgTZLOYNvxIjARhHwHnoMKSpm sVvbrH+0vue12nFtGBJLVhRE6As6O3jjf4YgYMc7ZnvZWg4nAAQh50ku056XWW/pPN78k05OIz6 eQJCHfYZ1vHQ0o+aQLEbLG4QZptpduUW8z0H26Q72wL9oBvnLBvNLAtY+WSgBDXGy2ZvH47jvt9 fbXJ9dU29nTHFygOX7BfdjwJGWpW1mBg2lJ5wGLSSOzu/7GumFQsHSKgNTeGgFAWRu6Tdc0hL5Q GYM0vSeA0tWqVztEwgt7HfNVwM5CUtJKyafogQwYx6Qp71lKv0tkc3B33xVkxPhJIkUlYPg+Wts = X-Received: by 2002:a05:600c:3b8d:b0:42c:c401:6d8b with SMTP id 5b1f17b1804b1-4334899712dmr59724095e9.7.1732201476197; Thu, 21 Nov 2024 07:04:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IHvdmgV40iceBFhDPE6uUMsEeLIuOuf5e3raKKjMPeU6dfpAjM249m4BWtVHDX7rkMEbjfpXA== X-Received: by 2002:a05:600c:3b8d:b0:42c:c401:6d8b with SMTP id 5b1f17b1804b1-4334899712dmr59723405e9.7.1732201475521; Thu, 21 Nov 2024 07:04:35 -0800 (PST) Received: from ?IPV6:2003:cb:c70c:de00:1200:8636:b63b:f43? (p200300cbc70cde0012008636b63b0f43.dip0.t-ipconnect.de. [2003:cb:c70c:de00:1200:8636:b63b:f43]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-433b01e1046sm61538025e9.4.2024.11.21.07.04.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2024 07:04:35 -0800 (PST) Message-ID: <3affa5da-469e-4a25-8c75-dfc783ed2919@redhat.com> Date: Thu, 21 Nov 2024 16:04:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/huge_memory: Fix to make vma_adjust_trans_huge() use find_vma() correctly To: Jeongjun Park Cc: akpm@linux-foundation.org, dave@stgolabs.net, willy@infradead.org, Liam.Howlett@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Lorenzo Stoakes References: <20241121124113.66166-1-aha310510@gmail.com> <26b82074-891f-4e26-b0a7-328ee2fa08d3@redhat.com> <25ead85f-2716-4362-8fb5-3422699e308c@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TqARAXTTAHCq_XU_zdA7jPjI-Iy7ZwVAwz0kX4fT2e8_1732201478 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7EB8A1C0029 X-Stat-Signature: nkqui5isa7qo8yk3fw46wbfw8jpyy7ry X-Rspam-User: X-HE-Tag: 1732201460-465082 X-HE-Meta: U2FsdGVkX1+33NLy5XWqz9nKkT/EAbpL7Y+VKjkBzvnQmO7P686jLrHsyhPHrJW/u2rzht2LiSJRMuER04IF4lOmQZixq2GkGOQZMAIsHJPSDx7vSSgXxqki5Yy0ffPotULFRM0jXdg6VUc6H2M5BTo3E8hUIfKN7xqkB0+tncCajSh9CPMOzRyvO++FJAf720EIr1w0mJEY3VQbuwDA742bC/G3MvShezOEPuVwHu5VcDl/IssiLMTl9TUiqouMLr40S7gfOf5Q3Ioeaded9qc8wnbFXtRqYlioOoyDMVs/pHkd24iZxQVAM4A8OtwlEg52DCXfx2VGrYuCBSXvmcpLCfnaJqlnYt+vP8euebvLRUt9dwJkB9SIDGyGjcpFCzARXsd9nktmfJnQ3PefTW1MxDeEVSOP86xF6szVZFHVZ3vWDpYNDPLqpxUtstIqKopbRN/t7jeQ27/oRmXOM+m8rg29zAOIUqiFFnMJaRTtanYXNgBMyK5cQJ0pCmJwamNVFkDBJwdLl6MPz7VT98/faSnrChNwWQ1AfA4Mo5yJaWwez/PTx4Y3424j9LeZiOQJXNCqsAl80BJbWoD6+SukBTggyimBS/lhKZnESApGay5Nw72pBndyaBUo1ZEIgu0guKczJGcfTEKwNEFsosfECG05qPILjaKtO9l9HayJEAI25oSx5mGK9n4mbyboryD7JVn21rviWnf4PfRuPYGzlMrnaUbWjHMWb4kz2UcyzQW4WR/tiJtOH7DWtfs67iS+1kmMuPl/Ec73ikfZoIjYUol11kQ6c9wIay6h0Lgv5ROx0Jglze8maT+rAVuE5fGCNhA5CRVNBdCI6A6lWeGJHcMDoGc/h6zr4E3Cdau1D0rnf8WCyqihGl6BFNNDdBe0adGH9otMAYXJawarEQEuBPFkiEQAwW+5fcAbJ81nh/Jxh30ZuUuQPD3b/BSEz/843rEAp1b94MuNSnq bHCaM5cQ o1D+aKuGuAMYKThifs8cA6Im9UvenNgzn1FVX+JQUVBSltFDDz/WDDXIFmd1CEB1AiOlLFK6wCb3kwzjW8eMTMhW2kIS+Ckr4xwDDaoiy5JoSurCW4SwJQtLBbwBQuJEwG87ktvbYYg/JDryxF1W5Q5p5Xvsdc+M4rqtoN9IDyCaM7vjT9juFkIOuegjIYFk+ShPzLXcciSJXg/VI/x6eU4NU6bR3B5NV/GGkkI61Xo9sZV43Lv3gllhzqEIAjaD2jGT0Lx2ypmaJzMycDueJg8vMOqqyslTdccUw1+YJsiuVJsAavt39NF6uJ91aMxQ7tAUvP+VPuCqQ0nXkxtDEQB10R5J2IyqpKvy0McUuaM0v8q5POitOAJB7Eg0zoTgFD6XrIRGqi1eKdLlAktnEmoE4X8K59ROZTzPAvpFV6k3K/HNvt7X92Hq0SW5rnvvIF/sqN5GUIgCFlBYo28xf2q09x+nO1XfT01YaFv4OBT1gw3I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.11.24 15:18, Jeongjun Park wrote: > David Hildenbrand wrote: >> >> On 21.11.24 14:44, David Hildenbrand wrote: >>> On 21.11.24 13:41, Jeongjun Park wrote: >>>> vma_adjust_trans_huge() uses find_vma() to get the VMA, but find_vma() uses >>>> the returned pointer without any verification, even though it may return NULL. >>>> In this case, NULL pointer dereference may occur, so to prevent this, >>>> vma_adjust_trans_huge() should be fix to verify the return value of find_vma(). >>>> >>>> Cc: >>>> Fixes: 685405020b9f ("mm/khugepaged: stop using vma linked list") >>> >>> If that's an issue, wouldn't it have predated that commit? >>> >>> struct vm_area_struct *next = vma->vm_next; >>> unsigned long nstart = next->vm_start; >>> >>> Would have also assumed that there is a next VMA that can be >>> dereferenced, no? >>> >> >> And looking into the details, we only assume that there is a next VMA if >> we are explicitly told to by the caller of vma_adjust_trans_huge() using >> "adjust_next". >> >> There is only one such caller, >> vma_merge_existing_range()->commit_merge() where we set adj_start -> >> "adjust_next" where we seem to have a guarantee that there is a next VMA. > > I also thought that it would not be a problem in general cases, but I think > that there may be a special case (for example, a race condition...?) that can > occur in certain conditions, although I have not found it yet. If we're working on VMAs in that way (merging!) we need the mmap lock in write mode, so no races are possible. > > In addition, most functions except this one unconditionally check the return > value of find_vma(), so I think it would be better to handle the return value > of find_vma() consistently in this function as well, rather than taking the > risk and leaving it alone just because it seems to be okay. Your patch is silently hiding something that should never happen such that we wouldn't handle our operation as intended. So no, that's even worse. -- Cheers, David / dhildenb