From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBEB6C433EF for ; Mon, 4 Jul 2022 14:51:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41D976B0072; Mon, 4 Jul 2022 10:51:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CD9C6B0073; Mon, 4 Jul 2022 10:51:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 298756B0074; Mon, 4 Jul 2022 10:51:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 199836B0072 for ; Mon, 4 Jul 2022 10:51:33 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DA20A213A9 for ; Mon, 4 Jul 2022 14:51:32 +0000 (UTC) X-FDA: 79649706024.20.F1C562D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 2D5E420048 for ; Mon, 4 Jul 2022 14:51:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656946291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zFvVKJ1fGrkThPrJCts+OirM91DHRLcTY7JYj4rk62U=; b=f7RyMvPHLYQdrSFBnpwyeG/zihciWvXEZJWShNf0rdH3C61AbI/WFbtf8pYdXeeFqO+sQZ kZWSTt08EtoLCaKGwmMaVEpf9e8UxLxIXG+wOxbAZ4QKqZf6F2bYnSB+5dCETkQJnsKnlQ MQUwWmcIRbHL8BH/H9BqYdV7Zfa/H7k= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-189-mKYx6hK6NdaewUoZTeJw6Q-1; Mon, 04 Jul 2022 10:51:28 -0400 X-MC-Unique: mKYx6hK6NdaewUoZTeJw6Q-1 Received: by mail-qt1-f200.google.com with SMTP id x16-20020ac85f10000000b0031d3262f264so7099512qta.22 for ; Mon, 04 Jul 2022 07:51:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=zFvVKJ1fGrkThPrJCts+OirM91DHRLcTY7JYj4rk62U=; b=BIHODMcraIuDMy+4G1HyJ3LHwb5ZfgTF6ok1KlgRFu01u7pt71xuB+0UmuZLP6bC+4 WGhDwIeLEPrv7kM73caL1JhuMUadgyIZwf3HnozPRa0ZI8NsWM1MyS0CIEzgIc7BGlAb GkuwZMcpE9XQrrcx7aQSxguaYh9hPSTmGWPiwJWt+onmVACebcs6+ec3p2B9oP1W0G1/ twM6iXDwRinQx6pAemvrLi3xHVfXot4JocDFNlXcU41wahkyeYJ6c27x61gZEgqvz0xD hOaKfz7kEzk/9W9vATkdAAlx9TmwYwJQY5Pacfmqg6ILhWXHU7RI3hUBATXsskIMRoXC opIQ== X-Gm-Message-State: AJIora/QH2J7oFNBmxgOs5HB2JBSowQr2rrLSOdhzjDd1DMuMWcKnXad 91jIrvEL6aVDbv3miSn08WXU9YW7R/DkKLUPjraGN8PBALc3zrlm7G4jlsk9xM0qV2w/7LxfWFC MSvOl44gBRv0= X-Received: by 2002:a05:622a:391:b0:31d:2a07:4f41 with SMTP id j17-20020a05622a039100b0031d2a074f41mr21046651qtx.294.1656946288098; Mon, 04 Jul 2022 07:51:28 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vOvptI4Bharw1kjiR6aB6/HEu3IoshyNYmsXxZb0mtL2gdO0jVvSB0WNMIX3QGj42rlK2jFA== X-Received: by 2002:a05:622a:391:b0:31d:2a07:4f41 with SMTP id j17-20020a05622a039100b0031d2a074f41mr21046638qtx.294.1656946287912; Mon, 04 Jul 2022 07:51:27 -0700 (PDT) Received: from localhost.localdomain (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id g84-20020a379d57000000b0069c72b41b59sm24603917qke.2.2022.07.04.07.51.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Jul 2022 07:51:27 -0700 (PDT) Subject: Re: [PATCH] secretmem: drop unneeded initialization in secretmem_file_create() To: Lukas Bulwahn , Mike Rapoport , Andrew Morton , linux-mm@kvack.org Cc: Nathan Chancellor , Nick Desaulniers , llvm@lists.linux.dev, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220704092605.19604-1-lukas.bulwahn@gmail.com> From: Tom Rix Message-ID: <3aff433c-f503-791d-77df-21a962185c54@redhat.com> Date: Mon, 4 Jul 2022 07:51:24 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220704092605.19604-1-lukas.bulwahn@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656946292; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zFvVKJ1fGrkThPrJCts+OirM91DHRLcTY7JYj4rk62U=; b=4kjnaXtjm1N41yq2/lEpPYfCh4rqrljQKbfx+KzLwNbQHzTMZeJag54wHAqB5KESYraYq4 3qVr4ywYbxCF8aJMWwqRzrzJGpeojq3eZdq25Cb0SKAzMErMSuFofiPBzS9OD8x44XbJOj YKM7ppRqGJiYnwlLW16NNhk4bOK+kik= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f7RyMvPH; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf13.hostedemail.com: domain of trix@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=trix@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656946292; a=rsa-sha256; cv=none; b=OcOzsdOHF3W51hgKWIlkFxvZDLP5mcb4/JkhUB2jJlR0vX763Up7dfjUo25QhhoBIW6fgJ Jx7gaR7j2j+AtLbXE+m0GZ+oa67C0FNmkRLaFvggzgiTpgE6+HvlCQeShsPX9tKkubJWZr Eq4Fu+O0AhWQ8TEK478oqVx3zd65WH8= Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f7RyMvPH; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf13.hostedemail.com: domain of trix@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=trix@redhat.com X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2D5E420048 X-Stat-Signature: g8qsu8u5bb6zrz7cu81cwi1dwyjcq9xd X-Rspam-User: X-HE-Tag: 1656946291-569331 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/4/22 2:26 AM, Lukas Bulwahn wrote: > Drop the unneeded initialization of the local variable file in function > secretmem_file_create(). > > No functional change and no change in the resulting object code. > > This unneeded initialization was already introduced with the introduction > of secretmem in commit 1507f51255c9 ("mm: introduce memfd_secret system > call to create "secret" memory areas"). You may need to be more specific about this commit, the whole function, including this initialization was introduced at this time. Otherwise, change looks fine. Reviewed-by: Tom Rix > This minor code-stylistic issue > was discovered as a dead store with clang-analyzer. > > Signed-off-by: Lukas Bulwahn > --- > Mike, please ack. > > Andrew, please pick this minor stylistic clean-up patch. Thanks. > > mm/secretmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/secretmem.c b/mm/secretmem.c > index 7584aab54d20..46b431d62761 100644 > --- a/mm/secretmem.c > +++ b/mm/secretmem.c > @@ -171,7 +171,7 @@ static struct vfsmount *secretmem_mnt; > > static struct file *secretmem_file_create(unsigned long flags) > { > - struct file *file = ERR_PTR(-ENOMEM); > + struct file *file; > struct inode *inode; > const char *anon_name = "[secretmem]"; > const struct qstr qname = QSTR_INIT(anon_name, strlen(anon_name));