From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6C42E77188 for ; Fri, 3 Jan 2025 07:06:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FADF6B007B; Fri, 3 Jan 2025 02:06:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A8E86B0082; Fri, 3 Jan 2025 02:06:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4977F6B0083; Fri, 3 Jan 2025 02:06:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2D2136B007B for ; Fri, 3 Jan 2025 02:06:49 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CF7261405B3 for ; Fri, 3 Jan 2025 07:06:48 +0000 (UTC) X-FDA: 82965257550.28.C1946D7 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf20.hostedemail.com (Postfix) with ESMTP id 352761C0010 for ; Fri, 3 Jan 2025 07:05:54 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf20.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735887959; a=rsa-sha256; cv=none; b=IJNt0UoHUA5BHmhPqnTfTGMgBmncLC9dG6pKuTWr2paeBGtevvtrJqPUjjM3sxH0TKVgh+ 3wm4K0s46MowaGFH7XArZIHcMRArjlX0rglCRY9ktptLKMOQ7GMAGs4OfX47SvJmnr2Wl3 8turaVzqY0Ah9SmcqP7VS9Nhpq6xy7E= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf20.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735887959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tdeN2n4VKdFFKUCNlYiuhpanjzxWJTUGgsr1PQAr0G8=; b=j4bnYB2WjfB/yauPv5yxcI8+bAZykRxMYogUiMmewkxqMv9OnWOQGGyHMSLHyCzII404qL Es9DfvN2y0md1cD+MZiG+oao2b+ZguaqeEcAkkdNMWTcjznn2l/bG3cfvyEzFX2Xjqv4kn HjQ7Brf9ezBAE00iAkcNCgffadxxFmA= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8D64A1516; Thu, 2 Jan 2025 23:07:14 -0800 (PST) Received: from [10.163.53.221] (unknown [10.163.53.221]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C91433F6A8; Thu, 2 Jan 2025 23:06:39 -0800 (PST) Message-ID: <3aed8d7d-568c-43fc-a157-cb13d6259ebe@arm.com> Date: Fri, 3 Jan 2025 12:36:36 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] arm64: mm: Test for pmd_sect() in vmemmap_check_pmd() To: Zhenhua Huang , catalin.marinas@arm.com Cc: will@kernel.org, ardb@kernel.org, ryan.roberts@arm.com, mark.rutland@arm.com, joey.gouly@arm.com, dave.hansen@linux.intel.com, akpm@linux-foundation.org, chenfeiyang@loongson.cn, chenhuacai@kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, quic_tingweiz@quicinc.com References: <20250102074047.674156-1-quic_zhenhuah@quicinc.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20250102074047.674156-1-quic_zhenhuah@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 352761C0010 X-Stat-Signature: psjxpqqg7rgf789npr93bqpd7py595m5 X-Rspam-User: X-HE-Tag: 1735887954-796057 X-HE-Meta: U2FsdGVkX18TMm+4YyvvJvx1ewEHwwQxgbL7XOXrwGeaT12b0NxrvvPszH9MEXXZ9TJ5v7mCSK7kLx70ECx1I7jFNhzolNfIrJGVJwTlBcLRNWSVl3bOxQ+yZPiHHIfdAC/kSdndGMbC/bBfp5Orqz4bfOL4xEZk1IdG7rfne0WchJ00lXP5WLuCvpi9+LgzYNqEStj21pgJzRWLesSBa8Ng0J+ksyJBlKzouhVbxc16la99Hr1m54JHDA2+TwHe1h/ePnGik9er3ilPPT0XIoXhctxGddhixOZxyIPkZw2YnJh+NXIFRs4iW31pLOJjzk9Do4JYHjoqUo+nChMBC/AB6Y07eswq+GBM8EmZkf0arzyaYv7VVnUqycF0BGlN4Q6Z3kXS4HRfCHXWwFZsqCSZoxSAf4v4luNPmKyi06u2q/RQiExoVKr8Q1v5HgCTXviUHsCKQanXuwnhqkx5/1NdzEqRzdlZAfRtHFL7hYRVHx89wuSC0gPy4EZUkIG1fi6dqbfQRG3apkEZaW/Y9YogEzPxkKEheSMTJhqp9UunnOifBFjew8SpERRN5NX3J0bTsaogkG7SnwyVQfFGnOWSv0DAEPCMlK2qa0NoqVpuCewa64E6e4Apv9tn7U+WF373k8s/611GoucJ17HLHJjhPW79ww3jAMUv1ubWUmv3iE9B4M2jjYK47nAoGYxMyDVPzBIBuXTfT5IREIQjaIC1+QRkHj6iE0VM24q57XdlV1mLyxGpOPdsffNJUsm9PawG3dBa1BEgl7TImM7CqGkxiy3BTMhNlQp8DJQOSfJfgnDcwjOGfAq0BzyvJ4MAS6iSYW/eUKuF+JzYZoDrfTn9uqJnHKVGz4rHxdB4J9KRiXDkre33oaC52tMmvLcKtQwLRYpre4+6rqpESLRgyUgvtIdFlt51Bx8/EbMlhhVcraVQMAdE0+XuquXED/jtEORbsdoWLu4yfQ3T8eN AS3ApFTW 9RtBknBgm2ziwwyj9zB/6gULZpUPGFW6wUqhlk5frPGr/g1BLC20JUZ8E9ahkzljUlh3f/Jd7TATbftJ//2STrRZDLfKYaJSPyvZmCXA86tPXjLlk9YDE1+Wi+LWJMHe3PFxZx9zVcQ7jWf8Au4fX4VtmyoWMPXeUfwcAhq1QSCDwvSItAnY79rQtEkPREQQfEILfViYAhAr8Y3RQQLM7PYJ9TxtoE9S3A0mA2fyKRFTJTegnFL+fhEfR8Kre/2/CnPJOZcy2C3+1HBVuKyFhcqKVrouRAaiSsx6oBLHkCl4ERFUh2g5zh5yjzf5gfg0+iySD8vRClfUsbpo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/2/25 13:10, Zhenhua Huang wrote: > Commit 2045a3b8911b ("mm/sparse-vmemmap: generalise vmemmap_populate_hugepages()") > introduces the vmemmap_check_pmd() while does not verify if the entry is a > section mapping, as is already done for Loongarch & X86. > The update includes a check for pmd_sect(). Only if pmd_sect() returns true, > further vmemmap population for the addr is skipped. > > Signed-off-by: Zhenhua Huang > --- > Separate the patch out based on the discussion: > https://lore.kernel.org/linux-arm-kernel/20241209094227.1529977-3-quic_zhenhuah@quicinc.com/T/#m41d49cd91b348ecfe2c37c4b3c0911180426934e LGTM, regardless whether this patch goes on its own or via the series. Reviewed-by: Anshuman Khandual > > arch/arm64/mm/mmu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index 9afeb35673a3..50a22c63f450 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -1172,7 +1172,8 @@ int __meminit vmemmap_check_pmd(pmd_t *pmdp, int node, > unsigned long addr, unsigned long next) > { > vmemmap_verify((pte_t *)pmdp, node, addr, next); > - return 1; > + > + return pmd_sect(READ_ONCE(*pmdp)); > } > > int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node,