From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBF73CD4857 for ; Wed, 4 Sep 2024 16:22:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 885C76B02CA; Wed, 4 Sep 2024 12:22:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8362D6B02CC; Wed, 4 Sep 2024 12:22:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B0896B02CD; Wed, 4 Sep 2024 12:22:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4C73F6B02CA for ; Wed, 4 Sep 2024 12:22:51 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 05FCEC1408 for ; Wed, 4 Sep 2024 16:22:51 +0000 (UTC) X-FDA: 82527574542.19.185EE9F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf30.hostedemail.com (Postfix) with ESMTP id 7110A8001D for ; Wed, 4 Sep 2024 16:22:48 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=T7Uo201K; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=z1OT4ESL; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AWYyPPU0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Naivw1uF; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725466872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OsGn+GMU9LztgvJJ2xT+wcVfB0lZopSDBR8Roh7ZK+A=; b=EtWUNvZ2iNNDnhpcr5lqQTaXiepbXtk8ZaNHpWXO1Vh/6nSDhT51aFxgjVCfHeyP55KYxa PLXJ3UqOgTU8I/YeF13YCteH3bkBmbeNUiSdBODD8zaiM7sxmAtgTLzOx5N2on2nhchxJX g1YVBrLWT2RD9CMXfbyVYYyZwujqCSM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725466872; a=rsa-sha256; cv=none; b=SNm3GEswCDmWGcH3eRhWtx1yy0AN2S280LILDTx5bU2TtRRj8D22Inalq5OwVoOdmz8yJT UaojmzXat6WURl89CtjnoWi9d0Gt4J8jdur+40y7V5JmkLZNvSTgHjLssSeM/FFKUiJ1dv nUer1t/beWYWA6NrocMb1gLyjxn1FMQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=T7Uo201K; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=z1OT4ESL; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AWYyPPU0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Naivw1uF; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 846E521A1B; Wed, 4 Sep 2024 16:22:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725466966; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OsGn+GMU9LztgvJJ2xT+wcVfB0lZopSDBR8Roh7ZK+A=; b=T7Uo201KaV/e7YvZysDIrNAX6nBAR8WIIkgjbtcqEwNeMwAc8QlHf2wH8xrujpjLSctB3F iw+ZIxdpQpU4KXbxmxzreCEFbRe++MK8i6vw34GPzB8FdX3YvyvWGPN+nlH8FM916Wsj/9 9EJljpZ1TsXHJU8AVkSfR/7pIOKJEzI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725466966; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OsGn+GMU9LztgvJJ2xT+wcVfB0lZopSDBR8Roh7ZK+A=; b=z1OT4ESLxDBx5R+OcGcKjUpOBQ7cbPAcYu5lQzlcw+KEOsnlZwHAWepP+D5XDM0aOdNzkH /8m0H5oJ1wk1X7AA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725466965; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OsGn+GMU9LztgvJJ2xT+wcVfB0lZopSDBR8Roh7ZK+A=; b=AWYyPPU0AvDtaVrDitWIye8UkuOhr2TnRXhHtdXmT5AAC6FKjwFOuEgArGH0tpwDqWwHN3 AQmaNjhDQXRSYfLAfLlEjhcrT1lgk0uU6jp5QEX3M/pYKodibrAHaui+xkm68xIZvIK32n HNFmMj5A3vs7w1C4MiqhGydaKLerjNk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725466965; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OsGn+GMU9LztgvJJ2xT+wcVfB0lZopSDBR8Roh7ZK+A=; b=Naivw1uFIKL1+EtJUYmZa2zYdShKwFL3rv7uTjgcI46TVu5KSKdD5Gas3NI/MsoV6MYxa6 aAl55jQmCNnOuuAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7213C139D2; Wed, 4 Sep 2024 16:22:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id OC59G1WJ2GZKGwAAD6G6ig (envelope-from ); Wed, 04 Sep 2024 16:22:45 +0000 Message-ID: <3ade6827-701d-4b50-b9bd-96c60ba38658@suse.cz> Date: Wed, 4 Sep 2024 18:22:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/15] slab: add struct kmem_cache_args Content-Language: en-US To: Mike Rapoport Cc: Christian Brauner , Jens Axboe , Jann Horn , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org References: <20240903-work-kmem_cache_args-v2-0-76f97e9a4560@kernel.org> <20240903-work-kmem_cache_args-v2-2-76f97e9a4560@kernel.org> <9303896a-e3c8-4dc3-926b-c7e8fc75cf6b@suse.cz> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7110A8001D X-Stat-Signature: d6icy58pch85sp1ci5knxr8rngdxjwgh X-HE-Tag: 1725466968-604971 X-HE-Meta: U2FsdGVkX1+G4wv/I3nNrryomarQs/brFYNY9KtMhuCYDQN/wtfl+8icGNbyKTOCBvCBUYB36TLelY530oLeeCpGMf9vVtQ0hPexPAAgf9/fCCYDC/a7lLsf4ewPqJA+pAowVHbVD5pTny92l9fRJLlTNNnstcnZv0rW4GOgx8p8HsPlgS50jXrlk2NT8inz+cxq3U74f5WSRAXlKEcveK3oHmfo5K7sAU7PCoRKtCcx/oPadyDLTwuHr1xtUEQS9lOTRJfunxD7r3e5eIWCAbf4n+IVkXG0V/KpjSEBZHhHlp6p+nVxoTshfGMK2zQ2YYCEkm2wZxXNrDfdDH51SbbwT7Zpc3/tAKv42UXSfbBr/8P80PwX14pZq7O6t7MK6x4MZceyLpZH0MkfJo+tdim2RolybLZrVetB/RT0skMO4zmMONSndN4zt1KKwUwhCYW7jK4IABFcw8ksfihaf0GbxS9ClsmuDHg3FesVsbsNnx241nb149QQjL3drk88ZXeXC/syAPOq+SwJklI7OvrVYmTpH0zXGuLmY1vGBidYpc2cJSipkQxdIdFH5IOh6N91YNcijrZtevH461DPIrkVuV33HV4U0hqibhhM4eiuQ6bH9/2Kb+3xMqBEYaDgbROBVq+Qs2WK+bsyjcFa/yDga/oLmiQflaM4m2hHjBQJDkNkkP9cKG30s2Crn93vRKtljurLv3YUL4iifBwqVs6zCcKVRR9ItNN/e0aSGy1+VBtwk+Dfpa0DVibMmItp8hlLXq9hcGmThE/H63+U72MtDuK9cjLhe9cs1iODMWqIyxwUmkeGP/KShxl1iK5ElIqWpnAIXphoEKWZ3usSusbm4v5dXdqAF6ZrT9vutWGWpeEMrbPiEiWi8JgqutFm8JGm4qMnc0QwQywfhScE/x7BzSR1K7wjqueT3C6CJEP9KZwiBF4vXO1tljx8ZczrhnhYlL5S1DcQybRWwRo Df2852tL QwGZ7WICap+iuRGMsQLCfPInBQCDzxE3rWsKq5ZpqORbTNdcMXKRPitb5Lf6xQ5TgjzaRk9QiRT9N24Pdew76Bc01wIbGkovh7ObR4HCm71EGmZIMWJDCwNVODXTNIiZ5idvhmp0u5rotWZCyF/tXnDLSlhjBiIGXF4peeQtLcURqBVDOSvdoi2EbgLq6HAGPFgQecvExd/tBKWAYCsOnnGcJe6/zSK/38HuFtSbj+dWSerB9bdXhqSCa5zY6ykFrmo0cqlEFq8fsCHI4dnvwD3ghqXGwYvsnnnfC4Jz9fWtKEJntlEhE8n0nBA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/4/24 18:16, Mike Rapoport wrote: > On Wed, Sep 04, 2024 at 05:49:15PM +0200, Vlastimil Babka wrote: >> On 9/4/24 17:16, Mike Rapoport wrote: >> > On Tue, Sep 03, 2024 at 04:20:43PM +0200, Christian Brauner wrote: >> >> @@ -275,7 +285,7 @@ do_kmem_cache_create_usercopy(const char *name, >> >> >> >> mutex_lock(&slab_mutex); >> >> >> >> - err = kmem_cache_sanity_check(name, size); >> >> + err = kmem_cache_sanity_check(name, object_size); >> >> if (err) { >> >> goto out_unlock; >> >> } >> >> @@ -296,12 +306,14 @@ do_kmem_cache_create_usercopy(const char *name, >> >> >> >> /* Fail closed on bad usersize of useroffset values. */ >> >> if (!IS_ENABLED(CONFIG_HARDENED_USERCOPY) || >> >> - WARN_ON(!usersize && useroffset) || >> >> - WARN_ON(size < usersize || size - usersize < useroffset)) >> >> - usersize = useroffset = 0; >> >> - >> >> - if (!usersize) >> >> - s = __kmem_cache_alias(name, size, align, flags, ctor); >> >> + WARN_ON(!args->usersize && args->useroffset) || >> >> + WARN_ON(object_size < args->usersize || >> >> + object_size - args->usersize < args->useroffset)) >> >> + args->usersize = args->useroffset = 0; >> >> + >> >> + if (!args->usersize) >> >> + s = __kmem_cache_alias(name, object_size, args->align, flags, >> >> + args->ctor); >> > >> > Sorry I missed it in the previous review, but nothing guaranties that >> > nobody will call kmem_cache_create_args with args != NULL. >> > >> > I think there should be a check for args != NULL and a substitution of args >> > with defaults if it actually was NULL. >> >> Hm there might be a bigger problem with this? If we wanted to do a >> (non-flag-day) conversion to the new kmem_cache_create() for some callers >> that need none of the extra args, passing NULL wouldn't work for the >> _Generic((__args) looking for "struct kmem_cache_args *" as NULL is not of >> that type, right? >> >> I tried and it really errors out. > > How about > > #define kmem_cache_create(__name, __object_size, __args, ...) \ > _Generic((__args), \ > struct kmem_cache_args *: __kmem_cache_create_args, \ > void *: __kmem_cache_create_args, \ > default: __kmem_cache_create)(__name, __object_size, __args, __VA_ARGS__) Seems to work. I'd agree with the "if NULL, use a static default" direction then. It just seems like a more user-friendly API to me.