From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63F3BC433EF for ; Wed, 24 Nov 2021 06:05:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF8C06B0075; Wed, 24 Nov 2021 01:05:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AA7CD6B0078; Wed, 24 Nov 2021 01:05:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BCDE6B007B; Wed, 24 Nov 2021 01:05:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 8F8316B0075 for ; Wed, 24 Nov 2021 01:05:38 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 588E5184C6E6C for ; Wed, 24 Nov 2021 06:05:28 +0000 (UTC) X-FDA: 78842786736.03.144E61A Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf13.hostedemail.com (Postfix) with ESMTP id 721931044801 for ; Wed, 24 Nov 2021 06:05:24 +0000 (UTC) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4HzVmD34FPz1DJYx; Wed, 24 Nov 2021 14:02:52 +0800 (CST) Received: from kwepemm600019.china.huawei.com (7.193.23.64) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 24 Nov 2021 14:05:24 +0800 Received: from [10.174.177.210] (10.174.177.210) by kwepemm600019.china.huawei.com (7.193.23.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 24 Nov 2021 14:05:23 +0800 Subject: Re: [PATCH] hugetlbfs: avoid overflow in hugetlbfs_fallocate To: Matthew Wilcox CC: , , , References: <20211124040818.2219374-1-yangerkun@huawei.com> From: yangerkun Message-ID: <3ad388a4-503d-6cbf-a02c-118594d36d33@huawei.com> Date: Wed, 24 Nov 2021 14:05:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.210] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600019.china.huawei.com (7.193.23.64) X-CFilter-Loop: Reflected X-Stat-Signature: 9in185umfr5pjkxfrihpkytpood6z71q X-Rspamd-Queue-Id: 721931044801 X-Rspamd-Server: rspam07 Authentication-Results: imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of yangerkun@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=yangerkun@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-HE-Tag: 1637733924-936657 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/11/24 12:24, Matthew Wilcox wrote: > On Wed, Nov 24, 2021 at 12:08:18PM +0800, yangerkun wrote: >> start = offset >> hpage_shift; >> - end = (offset + len + hpage_size - 1) >> hpage_shift; >> + end = ((unsigned long long)offset + len + hpage_size - 1) >> + >> hpage_shift; > > + end = DIV_ROUND_UP_ULL(offset + len, hpage_size); Thanks, will do it in v2! > . >