From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54867C433EF for ; Thu, 30 Dec 2021 17:54:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5F406B0072; Thu, 30 Dec 2021 12:54:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CBF996B0074; Thu, 30 Dec 2021 12:54:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC5A16B0075; Thu, 30 Dec 2021 12:54:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 98CA56B0072 for ; Thu, 30 Dec 2021 12:54:44 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4FF7A83E92 for ; Thu, 30 Dec 2021 17:54:44 +0000 (UTC) X-FDA: 78975210888.29.2650D2E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 33BFF100008 for ; Thu, 30 Dec 2021 17:54:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:To:Subject:MIME-Version:Date:Message-ID:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=aA9xBCuC2t/FCahUtFoF9vl9PxKpUL1fgzD9EinxOdo=; b=Z8drxXgAC81DL2C+p/fauQxUXf NsKPhFvqfekg/WFrvVja5bA4fBORGdpvl0dWCK1Aoy3l5uVtRvRBA9iSLlKP7MEsBfdf/5Fu5FSLU sDrJhGQg0kzhDDj/znSXRYMKj8gNfjGfKfzPuBuKqbI+FiNy+JxXh4xugYlsC7E9GWKVC6f1MDl9S Y6gPYgQNL7lvyLoboMGvlG7EvgBVcGm9mBUQH3kBagIVy5gjGwDniIoBNVLLGX4ciE9bYzSNqeSxg TaJvSv6YFKo1M5aY7TKF3d6WSTbKPOsj5qwdeTGeZpTdggtOoHpx+gKJFlk48Ggu+VoGK6+XLFRGa 4m2kFgjQ==; Received: from [2601:1c0:6280:3f0::aa0b] by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2zI7-009x46-N5; Thu, 30 Dec 2021 17:32:39 +0000 Message-ID: <3ad11107-30d8-ab75-961b-8142404c8c21@infradead.org> Date: Thu, 30 Dec 2021 09:32:35 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: mmotm 2021-12-29-20-07 uploaded (mm/damon) Content-Language: en-US To: Baolin Wang , akpm@linux-foundation.org, broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au, SeongJae Park References: <20211230040740.SbquJAFf5%akpm@linux-foundation.org> <1aaf9c11-0d8e-b92d-5c92-46e50a6e8d4e@linux.alibaba.com> From: Randy Dunlap In-Reply-To: <1aaf9c11-0d8e-b92d-5c92-46e50a6e8d4e@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 33BFF100008 X-Stat-Signature: 4x3unjyq9zwqry7gzws7zawfnwdbin9g Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Z8drxXgA; spf=none (imf14.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=rdunlap@infradead.org; dmarc=none X-HE-Tag: 1640886881-593186 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/29/21 22:33, Baolin Wang wrote: > Hi, >=20 > On 12/30/2021 2:27 PM, Randy Dunlap wrote: >> Hi-- >> >> On 12/29/21 20:07, akpm@linux-foundation.org wrote: >>> The mm-of-the-moment snapshot 2021-12-29-20-07 has been uploaded to >>> >>> =C2=A0=C2=A0=C2=A0 https://www.ozlabs.org/~akpm/mmotm/ >>> >>> mmotm-readme.txt says >>> >>> README for mm-of-the-moment: >>> >>> https://www.ozlabs.org/~akpm/mmotm/ >>> >>> This is a snapshot of my -mm patch queue.=C2=A0 Uploaded at random ho= pefully >>> more than once a week. >>> >>> You will need quilt to apply these patches to the latest Linus releas= e (5.x >>> or 5.x-rcY).=C2=A0 The series file is in broken-out.tar.gz and is dup= licated in >>> https://ozlabs.org/~akpm/mmotm/series >>> >>> The file broken-out.tar.gz contains two datestamp files: .DATE and >>> .DATE-yyyy-mm-dd-hh-mm-ss.=C2=A0 Both contain the string yyyy-mm-dd-h= h-mm-ss, >>> followed by the base kernel version against which this patch series i= s to >>> be applied. >> >> >> On i386: >> >> ../mm/damon/vaddr.c: In function =E2=80=98damon_hugetlb_mkold=E2=80=99= : >> ../mm/damon/vaddr.c:402:17: warning: unused variable =E2=80=98h=E2=80=99= [-Wunused-variable] >> =C2=A0=C2=A0 struct hstate *h =3D hstate_vma(vma); >=20 > Ah, thanks for report, I think below changes can fix the warning. And I= 'll send a new version to address this warning. Yes, that works. Thanks. Acked-by: Randy Dunlap # build-tested > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c > index bcdc602..25bff8a 100644 > --- a/mm/damon/vaddr.c > +++ b/mm/damon/vaddr.c > @@ -397,7 +397,6 @@ static void damon_hugetlb_mkold(pte_t *pte, struct = mm_struct *mm, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct vm_area_struct *vma, unsig= ned long addr) > =C2=A0{ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bool referenced =3D false; > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct hstate *h =3D hstate_vma(v= ma); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pte_t entry =3D huge_ptep_ge= t(pte); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct page *page =3D pte_pa= ge(entry); >=20 > @@ -414,7 +413,7 @@ static void damon_hugetlb_mkold(pte_t *pte, struct = mm_struct *mm, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >=20 > =C2=A0#ifdef CONFIG_MMU_NOTIFIER > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (mmu_notifier_clear_young(mm, = addr, addr + huge_page_size(h))) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (mmu_notifier_clear_young(mm, = addr, addr + huge_page_size(hstate_vma(vma)))) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 referenced =3D true; > =C2=A0#endif /* CONFIG_MMU_NOTIFIER */ --=20 ~Randy