From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61570C30658 for ; Tue, 2 Jul 2024 12:28:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC1836B009F; Tue, 2 Jul 2024 08:28:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E70E16B00A1; Tue, 2 Jul 2024 08:28:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D38BA6B00A2; Tue, 2 Jul 2024 08:28:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BB84E6B009F for ; Tue, 2 Jul 2024 08:28:00 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4184DC0133 for ; Tue, 2 Jul 2024 12:28:00 +0000 (UTC) X-FDA: 82294739520.09.AF630A3 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf01.hostedemail.com (Postfix) with ESMTP id 436444000C for ; Tue, 2 Jul 2024 12:27:56 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719923248; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ULXAq5aAAM4GTCXRMWCqNB4WIczRaHyM1TxTkWu4PHA=; b=V88NZ494kzMq6tGoVFGwCzsD0JwYtyP3uPgMrst+IxVlxVW+rhMoMvc7vO+CiYyNdIUV+1 jhy1R3UNCM/bd6/9nwN2yOj4fZAVpZ/hU0CK7tm4b/F6Vt4CtP1epy5+RASjDBf6yVaV8X ClsV5/Vxs+fp53mrUqOCKO6SIBFSDz8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719923248; a=rsa-sha256; cv=none; b=uiGEDXnPdz3FKl93uupSt3qXdiBngpriqN7hqMLIA5uCR8yKR1lmrebqf/JYKDlo0/ow5x wOoD6LmZlxCohHOx5I6XVP7dMCPqFX7Ia7vz9zrETc39u4fLkB2VQy7rOMPc7xyOPOb9Fk fzK4xkdzwP8gwUs4UWUiV0mr52xiHcg= Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4WD2BJ4sjPz1T4lL; Tue, 2 Jul 2024 20:23:20 +0800 (CST) Received: from dggpemf200006.china.huawei.com (unknown [7.185.36.61]) by mail.maildlp.com (Postfix) with ESMTPS id C4B64180AA6; Tue, 2 Jul 2024 20:27:52 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemf200006.china.huawei.com (7.185.36.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 2 Jul 2024 20:27:52 +0800 Subject: Re: [PATCH net-next v9 02/13] mm: move the page fragment allocator from page_alloc into its own file To: Alexander H Duyck , , , CC: , , David Howells , Andrew Morton , References: <20240625135216.47007-1-linyunsheng@huawei.com> <20240625135216.47007-3-linyunsheng@huawei.com> <86c56c9a88d07efbfe1e85bec678e86704588a15.camel@gmail.com> From: Yunsheng Lin Message-ID: <3ac9d5ef-50a4-286d-eeec-a8d9a846278f@huawei.com> Date: Tue, 2 Jul 2024 20:27:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <86c56c9a88d07efbfe1e85bec678e86704588a15.camel@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemf200006.china.huawei.com (7.185.36.61) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 436444000C X-Stat-Signature: bwp5t8iiqt63mscyacp4crwj4yfwi7hi X-Rspam-User: X-HE-Tag: 1719923276-574812 X-HE-Meta: U2FsdGVkX19HrqKv6Q8AmZSX5rnyah1SyduplvT318PlB9YEDSn5V1q7Xf3hrCsH9IFtiuphBMxwNyBJipQzU9bjx8r/RkCuZvaf0vsEvxEuCY2bh4if2UR3wt2m1q+ZC9oPGg/JvcdBzJeDXAEhQaY8MVOLeXGi/xs0SIDZ0QYHpnHuxinU6haZR5mwyM5qt4LiDecMfqipvLCdGbcOUE2+HxJcb3nmtgRQnS2Kp+RYQ1EUXiPntzZIhodNzoBY0aTsnA3zZAo+bswroZc/yO0Ibn9tdnA4V3nvXo27b1pGbv1nYlcZm+zpRGJbxXZyHp6C+Kjqe5lx25kAxxmED7lnGXLPr7OXRWCgsnFHadOJJ1AZNPEc7azZchMiWSB5yX2XVAFcsP8fKBP4uG0ruFCSIozxih3XhanhHoEXVm4LSz6NkaZYyJXRtB1A1j9ys9pW/Zp5f6/52Yj2+jNsmUexddT03Der6cnDSrDVgDpTgdToNjbStVxIFIH5Dy1EVKIq1TzvKAImKHWIn8tfXuY9vaMI2u3FBuPr+BpNnTT8TfNXIy7Kbeh0U1OU09WHvGidwbXQwqtfHXMRKTkvj9r8XiqR+D3SqOSqShejZ+lbD/IUUZDgIraDGM6L/8B5eC8YiuLqoOJV9Q/lCv8i3HWrAgcorsmVVHw3RN2crc5wXbecOfxM2jVx+dPvl/vFrIpzn+WaU+h9vihYbvvTT1tcRgOprszBBuTo2COZfK7eNVsFfdRNBXqTHpatDdPAnoULXeegAR62EDrOTlzwXHXyxxlOMSQYt8IretX/BedeZcC/B5OhTfB7h57E4UKxtno2Lwo+Q+fghuZrfvwjZmQqFEkGTFYUtZE28wp3o8b4SELxY+fv0gmGkeh3EW0COnqlGWf6HZI73TL925nSvhpnQbfsisllgUJ8gE8wZ029EYCfJoDXCEELUMn8oW+BHYDbmMzOufzmVoGc8w6 5SMqks6o OwGJzFTUj3L8UeFIVd3IWIw351RV/temwTsmu33NQF1TzX7QQNPMZTTanj7wYfcZNS/smyNn/9GhE0018Al/Ujo/gwfYbZiPQh9dFadKEu19NLKj3Q4fm3BvUuRTCznNfueTp8uU5D+mGxqYuHo9IrEBlyPop2g0db8ICzdenrNTasfmmgtkniVkG+9xGSZGRpaKo29xy66wvY1JfYLE2pZVDyMflcJ6PCgrKE4JAv4zMVq7keqrzErnY41Bl2yzWdv13JlW8Rx5d97xquIhHXgDXDXursUJKtT/BnBXeEGtTqw7Z9JRFoA/a4Bv9BnY9LwIloo7OdUPT9rzsUPuWERJAbbUFzHecd2OO24EPdbh3lrQdamzq6tq4pB/T60UHwTx5YLqlNGarsjQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/2 7:10, Alexander H Duyck wrote: > On Tue, 2024-06-25 at 21:52 +0800, Yunsheng Lin wrote: >> Inspired by [1], move the page fragment allocator from page_alloc >> into its own c file and header file, as we are about to make more >> change for it to replace another page_frag implementation in >> sock.c >> >> 1. https://lore.kernel.org/all/20230411160902.4134381-3-dhowells@redhat.com/ >> >> CC: David Howells >> CC: Alexander Duyck >> Signed-off-by: Yunsheng Lin > > So one thing that I think might have been overlooked in the previous > reviews is the fact that the headers weren't necessarily self > sufficient. You were introducing dependencies that had to be fulfilled > by other headers. > > One thing you might try doing as part of your testing would be to add a > C file that just adds your header and calls your functions to verify > that there aren't any unincluded dependencies. Sure, will do. >