From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C360C3DA4B for ; Wed, 17 Jul 2024 09:30:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F0E06B0092; Wed, 17 Jul 2024 05:30:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79D2A6B0095; Wed, 17 Jul 2024 05:30:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F0AE6B0096; Wed, 17 Jul 2024 05:30:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 413896B0092 for ; Wed, 17 Jul 2024 05:30:46 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CF3D9A38AC for ; Wed, 17 Jul 2024 09:30:45 +0000 (UTC) X-FDA: 82348724850.08.40F3E08 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf20.hostedemail.com (Postfix) with ESMTP id 5F7C81C0019 for ; Wed, 17 Jul 2024 09:30:43 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=WQ5y45eY; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=rRlOIPxr; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=WQ5y45eY; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=rRlOIPxr; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721208624; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qcTz1ZeKOjXrPBceZbnpdHK/tN2ydZ9N5V5O1DKOgsI=; b=GnHPxwgncxFfZHheCDaP6oxx/ngAqpwmryvTtAK2wH/hAFMdkG09ThVr9YWrRk/M/IgZko Jx6IRKFk2ooITwjo+b6fEObCkHXcR3yMf0sZYPZaqNQDOdHfmpMwyF5lMibUrIAG3tDTx6 kX/G00WeCOn/fUOxqlrPpHTPo+zzKK4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=WQ5y45eY; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=rRlOIPxr; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=WQ5y45eY; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=rRlOIPxr; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721208624; a=rsa-sha256; cv=none; b=a83Y2P5kIxw7ekLNNiRR2daIlD8JXydbLM/8X1ko7gH40pwlEStFU/uRzAXs5wbOCuE2S4 mqTzw9YNt3gZC/YjrlY3hmeT/ztviVFi1xIa5IU1aYg+O+JbYk8ju4kHa0/MGSoboawI4K 1GfZq3ons5DfeHHGLRicvD1CKaADYRQ= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 906E521ADD; Wed, 17 Jul 2024 09:30:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1721208641; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qcTz1ZeKOjXrPBceZbnpdHK/tN2ydZ9N5V5O1DKOgsI=; b=WQ5y45eYlgJIbAQdWIim/NtbmBoAgFycFNhmSEP+D/gxVypPtXzPtCEYFZyWInJPXRAR0D keMNK80BRF9ePj865UX9Z5mRqlLhkpV3+TC9BxeK7wLdxfGVqnZX9Dc3PU1WlAE4DeZ8PL kKQ+AtpD1j+Gb82+ehm2qbEbr6EWvZE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1721208641; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qcTz1ZeKOjXrPBceZbnpdHK/tN2ydZ9N5V5O1DKOgsI=; b=rRlOIPxritoKlKd2TB4/VPGJCf72xR3wfXA8G9xklAwy5lrjDyevLp3/ckldyKRnosS5rq csQFm2x95WIPYZCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1721208641; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qcTz1ZeKOjXrPBceZbnpdHK/tN2ydZ9N5V5O1DKOgsI=; b=WQ5y45eYlgJIbAQdWIim/NtbmBoAgFycFNhmSEP+D/gxVypPtXzPtCEYFZyWInJPXRAR0D keMNK80BRF9ePj865UX9Z5mRqlLhkpV3+TC9BxeK7wLdxfGVqnZX9Dc3PU1WlAE4DeZ8PL kKQ+AtpD1j+Gb82+ehm2qbEbr6EWvZE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1721208641; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qcTz1ZeKOjXrPBceZbnpdHK/tN2ydZ9N5V5O1DKOgsI=; b=rRlOIPxritoKlKd2TB4/VPGJCf72xR3wfXA8G9xklAwy5lrjDyevLp3/ckldyKRnosS5rq csQFm2x95WIPYZCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 499A8136E5; Wed, 17 Jul 2024 09:30:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id MyJGEUGPl2aEJwAAD6G6ig (envelope-from ); Wed, 17 Jul 2024 09:30:41 +0000 Message-ID: <3ac089e1-7a30-42ef-a11a-d4d080e06c69@suse.cz> Date: Wed, 17 Jul 2024 11:30:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] alloc_tag: outline and export {get|put}_page_tag_ref() used by modules Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, hch@infradead.org, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel test robot References: <20240717011631.2150066-1-surenb@google.com> <20240717011631.2150066-2-surenb@google.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240717011631.2150066-2-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5F7C81C0019 X-Stat-Signature: 4kkr5jik53wcxz61h7pk5dn6tox48ikw X-HE-Tag: 1721208643-529575 X-HE-Meta: U2FsdGVkX19sqNssxvdGJXc/yKOypCr1F2PnnI8syrb66nFjZb7nBocdnD1Z8zmKvY40OMwiS0U4v5iDbenBuhW91JRV9Gv356unnOsGArIxi/aK8Al6/sIIBuPcUuXwHZ1Oj5agBsRHH91C3/bx2vlyGU7/qyPlsy4FKVK5O3ynjNTFM9Pjm5zt9+GHRib6fzlWPddOvYBz4HvHsLWHfkm+F7IoxbuyOm9Il5R2UwzpP5zW0XjsLUdFJozfBOo1c9G8JKRxsZSk4ck/kLGOLEEZK3Be/8XfWvm28ilvSX9u3P4jooe2krqTk/OGRGFU4HDcx9srcTm+nloP3chgJtvbGVTiy4AuBpa/1laEEs5BLqqlBvS3oq+Vkm+j0eIzVhPhC6QkflyhmRTUrz2erVFbZV7oN4pd6A5fDtU26HWnYC5yIwvGxNmJg9vcS/bp9++bIzgSWoHQIHr6ojFj0j+bEloaIZEsPnpnrMFfYJOcAD7LL+i3OKvh21sVmI81weywQ3NDltmpKp/wXb3f2vKp9S3Y4m1z8XSz5RLusO6c0GEgkBVcJBBG+bVpbZd0aCNWTPt/gcJ6DawftTfI+Oock4GTK2FU0V1e3SJCDpp0BJ1vbn5vxUokulnrBrznjAdqJyBlzHp0de2kNHopDbwjbTY85ckypPuvMp78DXbXPbUcPy2JcFbP6HYxnGtqv4ITGBwGveg59vXf8+uRJCPYXIbv8fdCehoAA+SNH0/fVeCA05q3TxuatfoVM20t4dmbZWQFXYBu5OgLgpyA2E1ppZDSzE9xlSSk2RfNfx6ONAfyRxHlKN659buhAL/lzHhRDRa5UeynbGt/SNkCf8RpyMu04LLt2sS5ihQrHLXA2dFvZ0o111zeGieHbFh0++4ob7StL49uWSio2lliQ8ZCHFu5tvP+7gQiezlEWTez5kOqg1RYyDA+Y8ZrrbcjsnzV6IjFbakl5I5MbQd e7BLykvr rAwmxkqnqQZIutEjJArIFV97kGBJWwGytUwVUJTQwX/jN2um0JdvBbAKF1awOlXVO30t4IS/96X7oObJYGF9thbY5SmvQHsMuwAKqpaLzQl1ETzgs9hfkTW3yntAZWUWVnuxGJ5cKKXr7otHIMWtxWKIs7ak818OnML5Z5Zk12sppp1gW2oVILvddULvhvqdnisMdi9Ga+0Sj7wHaWn0/4xN91bZwOXaVpqdfG2RqsYWjrrGdNmKzIUtNMFYXv9Lyg1P5AUu7YtFt6cbd1IT2/bbYTmXEYPdo2CmBR6OU6uDAQ4bxk8YrKpkeDavF5H4DE39hbjKM2spbBqem2ZAoxCuxNHdwwEkU+311zZ9DBdcuyiRA0FExJp6jn6Y59eLyNy39OLVdcUssSOiGd839HAU9PX6ilnL0ydL4qlU2g2JSEbOKEQQj5yEdbOoDslwzCDlCFVNlFtwOVW/+RbYYZzoDaCCiF3PlVJXp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/17/24 3:16 AM, Suren Baghdasaryan wrote: > Outline and export get_page_tag_ref() and put_page_tag_ref() so that > modules can use them without exporting page_ext_get() and page_ext_put(). > > Fixes: dcfe378c81f7 ("lib: introduce support for page allocation tagging") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202407080044.DWMC9N9I-lkp@intel.com/ > Suggested-by: Christoph Hellwig > Signed-off-by: Suren Baghdasaryan Better than exporting page_ext but still seems like suboptimal level to me. You have various inline functions that use get/put_page_tag_ref and now will call into them both. IMHO outlining those (and leaving only the static key check inline) is the better way. As for the report that triggered this, AFAICS it was due to free_reserved_page() so it could be enough to only outline that memalloc profiling part there and leave the rest as that seems to be used only from core code and no modules. > --- > include/linux/pgalloc_tag.h | 23 +++-------------------- > lib/alloc_tag.c | 23 +++++++++++++++++++++++ > 2 files changed, 26 insertions(+), 20 deletions(-) > > diff --git a/include/linux/pgalloc_tag.h b/include/linux/pgalloc_tag.h > index 9cacadbd61f8..3c6ab717bd57 100644 > --- a/include/linux/pgalloc_tag.h > +++ b/include/linux/pgalloc_tag.h > @@ -13,6 +13,9 @@ > > extern struct page_ext_operations page_alloc_tagging_ops; > > +union codetag_ref *get_page_tag_ref(struct page *page); > +void put_page_tag_ref(union codetag_ref *ref); > + > static inline union codetag_ref *codetag_ref_from_page_ext(struct page_ext *page_ext) > { > return (void *)page_ext + page_alloc_tagging_ops.offset; > @@ -23,26 +26,6 @@ static inline struct page_ext *page_ext_from_codetag_ref(union codetag_ref *ref) > return (void *)ref - page_alloc_tagging_ops.offset; > } > > -/* Should be called only if mem_alloc_profiling_enabled() */ > -static inline union codetag_ref *get_page_tag_ref(struct page *page) > -{ > - if (page) { > - struct page_ext *page_ext = page_ext_get(page); > - > - if (page_ext) > - return codetag_ref_from_page_ext(page_ext); > - } > - return NULL; > -} > - > -static inline void put_page_tag_ref(union codetag_ref *ref) > -{ > - if (WARN_ON(!ref)) > - return; > - > - page_ext_put(page_ext_from_codetag_ref(ref)); > -} > - > static inline void pgalloc_tag_add(struct page *page, struct task_struct *task, > unsigned int nr) > { > diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c > index 832f79a32b3e..5271cc070901 100644 > --- a/lib/alloc_tag.c > +++ b/lib/alloc_tag.c > @@ -4,6 +4,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -22,6 +23,28 @@ struct allocinfo_private { > bool print_header; > }; > > +/* Should be called only if mem_alloc_profiling_enabled() */ > +union codetag_ref *get_page_tag_ref(struct page *page) > +{ > + if (page) { > + struct page_ext *page_ext = page_ext_get(page); > + > + if (page_ext) > + return codetag_ref_from_page_ext(page_ext); > + } > + return NULL; > +} > +EXPORT_SYMBOL_GPL(get_page_tag_ref); > + > +void put_page_tag_ref(union codetag_ref *ref) > +{ > + if (WARN_ON(!ref)) > + return; > + > + page_ext_put(page_ext_from_codetag_ref(ref)); > +} > +EXPORT_SYMBOL_GPL(put_page_tag_ref); > + > static void *allocinfo_start(struct seq_file *m, loff_t *pos) > { > struct allocinfo_private *priv;