From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AA76EB64DD for ; Tue, 11 Jul 2023 11:55:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 081D76B0071; Tue, 11 Jul 2023 07:55:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0334E6B0075; Tue, 11 Jul 2023 07:55:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E148A6B0078; Tue, 11 Jul 2023 07:55:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D0CCA6B0071 for ; Tue, 11 Jul 2023 07:55:55 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 96987AFE17 for ; Tue, 11 Jul 2023 11:55:55 +0000 (UTC) X-FDA: 80999177070.03.6013770 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 58CF71C0019 for ; Tue, 11 Jul 2023 11:55:53 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="d/f4DSnV"; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689076553; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9QndkvGX+ralMYrK4vSVmQjm+CR9QG8JZocEr1mbjrI=; b=zjx7nqpwaNU9QNOOd+SVzNzMp8UuPZTQd4ShlsvwklztXlabkogsDRhpmYHnwrrNWLxBQi EQgW3B4y9bIuJIpQhxoFxpzAzVhp6G/1cwDfREwtU4UWGx9YPSlXjQh6hbeps7FQOPZ5mc EXJzzzWehdgtT/kzB3qoh376iZwQLP8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689076553; a=rsa-sha256; cv=none; b=GUZKqt0MkqlhD5RRoxwPn5RwzWHf4w2dF9nT0jx0JtRHdhV6qdwLLEiRqhqDyMxiKeifny wBAy2FeyDYsvBMtYRCvxRb0tcj6GmiZbHT8+PjnZ8zDPQmVjf9H5rVXZZlpr49WKrbESGB /AGFG6hBdugSUqKfpIcNQ+v8gCjhk7U= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="d/f4DSnV"; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689076552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9QndkvGX+ralMYrK4vSVmQjm+CR9QG8JZocEr1mbjrI=; b=d/f4DSnVyPPUijWL5k+LweWOk505S9B9v/SzltEfAaILXdw5R44b/mNmi7YVoOv4qb6uzK QgufYT4vBOCDTTk+r05FQgIY40yNWU8NhAWbA4QoyYPkN+NKStSrbycT7ZLuRrbdt/R1aR JiWTBLd+VLmJBhv75gVXUKLHiA3vPDA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-386-9lNgBqiMPheTQYfhTAwClg-1; Tue, 11 Jul 2023 07:55:51 -0400 X-MC-Unique: 9lNgBqiMPheTQYfhTAwClg-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-31437f02985so3474662f8f.0 for ; Tue, 11 Jul 2023 04:55:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689076550; x=1691668550; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9QndkvGX+ralMYrK4vSVmQjm+CR9QG8JZocEr1mbjrI=; b=k9CSyvzzio/KLlk23M52c0RU1mJri22fbP6CnVmOjYvvxfyjkhgT/2y6X6qLEfue2d fcyD0bPeRanpfgTRromwi7we0JWLPYufum70g/+uSOQaVeAjOn5alToajDdDGaa6eWyA UO79VMi9ylKnU+oRnpeHbwWjphrW1Tm3aSRWYidtdekR4iTVbVBlbEN4fyysWeeDyP8W 6tz4xedBt7iwwCSdSoIy2gSDIsbGdiIWXBSz79Z5kE0B+8g+G+vg+IRBkJvMoirvhf6g FRawe0MAwYqtF4bVHMw1Ro4FXepLo0vShog3/FJrpKZSu+ZgpcmVdKmU714Gu8MB0BPE 3/aA== X-Gm-Message-State: ABy/qLbjgrSpAueKxUe0tVdJsc9Iwm3ekjWsexQ9606/QsjYq8mMLEy0 dr4O4SoSncl6RsMxLxvVbccfYShU9fFg3doxAhTCefoFO/7Vej5/ADDY7CdAE8zDe2GN+sssMfN Yk/FS/Wz508I= X-Received: by 2002:a5d:4d0b:0:b0:313:e20c:b8e0 with SMTP id z11-20020a5d4d0b000000b00313e20cb8e0mr15606187wrt.23.1689076550481; Tue, 11 Jul 2023 04:55:50 -0700 (PDT) X-Google-Smtp-Source: APBJJlFURy1zSr3Q0gRDkNXbN9SbMZxA7dXq7h/P+2X/BOQ2s5vHiGIIPZobjuUfNduFocMFb0gDpA== X-Received: by 2002:a5d:4d0b:0:b0:313:e20c:b8e0 with SMTP id z11-20020a5d4d0b000000b00313e20cb8e0mr15606169wrt.23.1689076550073; Tue, 11 Jul 2023 04:55:50 -0700 (PDT) Received: from ?IPV6:2003:cb:c745:4000:13ad:ed64:37e6:115d? (p200300cbc745400013aded6437e6115d.dip0.t-ipconnect.de. [2003:cb:c745:4000:13ad:ed64:37e6:115d]) by smtp.gmail.com with ESMTPSA id y11-20020a05600c364b00b003f90b9b2c31sm12817954wmq.28.2023.07.11.04.55.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jul 2023 04:55:49 -0700 (PDT) Message-ID: <3abfb722-a0c1-dcad-55f9-dfff7167c501@redhat.com> Date: Tue, 11 Jul 2023 13:55:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v12 12/22] x86/virt/tdx: Allocate and set up PAMTs for TDMRs To: "Huang, Kai" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "Raj, Ashok" , "Hansen, Dave" , "Luck, Tony" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "kirill.shutemov@linux.intel.com" , "Chatre, Reinette" , "Christopherson,, Sean" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "tglx@linutronix.de" , "Yamahata, Isaku" , "mingo@redhat.com" , "nik.borisov@suse.com" , "hpa@zytor.com" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "bp@alien8.de" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" , "x86@kernel.org" References: <85ea233226ec7a05e8c5627a499e97ea4cbd6950.1687784645.git.kai.huang@intel.com> <68a8cba5-55b6-4c8a-f4e6-d528fc839285@redhat.com> <4fe54e141ec5040300d0e2552ea31b83aa947ec2.camel@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <4fe54e141ec5040300d0e2552ea31b83aa947ec2.camel@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 58CF71C0019 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: gmi7iczndtah59m3ejziian6gb6rotq5 X-HE-Tag: 1689076553-621907 X-HE-Meta: U2FsdGVkX18rABoAuOd6bdwS+pKY/LrFwkdA3ZBRvgF5KJBhsKjamrw0bN23Rawf1GdHKQouaU1B4gJ/ZcVvMaOO68hQwM5XfzeQcsVP3awVVKBV6GbXpF1nJyrhmcf9BbibFoXxkbupwQ9CQhE3OVhgrA72trIHqjQZSCRjLV5vAE7aCl+g3rv3l/ZnMPQIAzQSfSoMxY4Me91Ma8l+An8XgqbN5+b6K4PZXS+knc8PCkg5bThKvovl5D9u5FmqnKj/v/maNBnCzsvI8+j9uZMV0J9ngQ2eWm8WcbWIRC3DlAA0rZZsgNQ6z2inu0Dozl9m0cbs2xytcUWjVwSOljurziN0jP4vK31zeLx5N7660v11doFbBMn71x49z9bZgqVOEYwMZxlbrUU5MfIzxoWXJGActyL4xYFhpInIsM3UuzfOZhuHIpxUCRYeto/ib25SBnA80X4CTLWkRSmt3qqhzq70uNsC2HcKYhLFAGI4Y3XZRH1rnUKSRsCV5seebIDoJherFspxJ1WVC9i1YB5GwGTaybH3HD1rPfX0pqUn+elop8dhetUR3vmbr1ayTdh4f4yfox0Z+jiwGMbw9ObuXwQVkWoM9ZjA94NpqzqT3Fb9+CqFeilQuojTmI5gSRrrZw5ZDmLFgSNCeIXM9vGJWnISeQcKxX2dgPqu8JBjeOV7ckQGjvEaO9jp5I08b1P0gal6SAEKPiYfpLeaiDiBKZ3KwcYFWRNG4mIDW7ZGaleB9SbsrsNCzm5a1FKQENaft3blHj02JZ4IZR4AZN+JXc8+GV09Bs11qNJv2TA4+4JzwWKXN9WkJ/T+bpLOKlKV6KLI3+Sg0Z/R6pW4ahm8/XHcSI0IEZGM3TJKp9cqnz/sbPEyoS9+p9rL0DIbX+m5/Nxc4fM5PP1R/7WRuI1wmaDkRuk/c+3rlgRc6ZpbuxCzU7NrvRtqLVm8B8N7j1+V9Pt58sNaB3YLRAl PydTJd1M HgQO+Z/ElocAVdMATe0TB6C2UufGC6sJHildjnSdhMjAjUQFSZpwaVmPQ+UZL+cA15wOhtPCD+0vmOZ05k8hAWFTDV5uccKZrwV7/+jQno+yUxv3wtyl6oB+0eC3eRCaO28OTfSywOyCRbV4Md9S/BrixJI3XpGwaw/r57+Gq2ompFcupwakkFsf+EA8/pTD+2teOC0xgJJQkcRthg1K4f/O4nXzKLJK3mXGRHpnkKYfGa1ARYi4GOe4IqpfmOmK4waY4cbjJoG17iWPgQ6xP2PZYfeyX/Mt8IzmqXfdckHWe21MhX9IrqBptxrB9l/SHreoqROJJA15B8x30GBZzw46M0bHAztI/vbqo6B0jc9tGPRoYzsiLDweIzLZxD1NxU3H2SMCpcZZHv5VETt/n9a6Cf1daoh1Q7v2b X-Bogosity: Ham, tests=bogofilter, spamicity=0.000026, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.07.23 13:49, Huang, Kai wrote: > On Tue, 2023-07-11 at 13:42 +0200, David Hildenbrand wrote: >>> - ret = add_tdx_memblock(tmb_list, start_pfn, end_pfn); >>> + ret = add_tdx_memblock(tmb_list, start_pfn, end_pfn, nid); >>>     if (ret) >>>     goto err; >> >> Why did you decide to defer remembering the nid as well? I'd just move >> that part to the patch that adds add_tdx_memblock(). > > Thanks for the review. > > The @nid is used to try to allocate the PAMT from local node. It only gets used > in this patch. Originally (in v7) I had it in patch 09 but Dave suggested to > move to this patch (see the first comment in below link): > > https://lore.kernel.org/lkml/8e6803f5-bec6-843d-f3c4-75006ffd0d2f@intel.com/ Okay, thanks. -- Cheers, David / dhildenb