From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39853CD11DF for ; Tue, 26 Mar 2024 10:00:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C19A06B0092; Tue, 26 Mar 2024 06:00:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC91C6B0093; Tue, 26 Mar 2024 06:00:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6A596B0095; Tue, 26 Mar 2024 06:00:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 93D276B0092 for ; Tue, 26 Mar 2024 06:00:33 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DD87F40664 for ; Tue, 26 Mar 2024 10:00:32 +0000 (UTC) X-FDA: 81938745504.13.268B418 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf29.hostedemail.com (Postfix) with ESMTP id 0993E12002E for ; Tue, 26 Mar 2024 10:00:28 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=UOznrKGV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Nifv0FZX; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=UOznrKGV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Nifv0FZX; spf=pass (imf29.hostedemail.com: domain of hare@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711447229; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KICT4ootVVkt82VIPFNRhNaswFEFMB6uWwwdlc+odyo=; b=jwOVfgiR95IuX0ez9I/pqlng0X8YUgBLIDBA8rZxP2dCz4BHdxG5WKc/uEERBmeOifFsnP btjsSRGWdtRbfVxH16sayn1Ca0YowoYxiMJ0Q9JP6iN1GILsC5+gIChsqeB3vQZg0yzgRb YQSRVTJGLcfJ4ajPjpHp1xvQpR7OCPM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711447229; a=rsa-sha256; cv=none; b=hoAFO/BYokChxBuJ0tcYVUYq64tSk/cuJHCMgR++39mOazOhTGdWxg4Ci+qSdQkGiY62c0 coXSZkkNBSiaicxZVHb/v1ww14Q4U0tHMvRD1/gII/RmPcFh2dvz7ynua68SsS1f9qO7rM zF4/310km3tsEuD6oCxKh33ATzPlhy0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=UOznrKGV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Nifv0FZX; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=UOznrKGV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Nifv0FZX; spf=pass (imf29.hostedemail.com: domain of hare@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 578B55D41B; Tue, 26 Mar 2024 10:00:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711447227; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KICT4ootVVkt82VIPFNRhNaswFEFMB6uWwwdlc+odyo=; b=UOznrKGVKIfFw2Fuszv5rYbTxsSo6NUggGIl4qc4DEs4/FyktjuYR8w/28z9wRcXhmp5DM yuDOfmvFfgFCmZqQuLpc940hGiok4U5tIA1OnKTWVm8hgbCxN1xChmxDD0tz78xhpYhuoV Y4rO/xz2+NyOS6VhgXYbMjfCH5lhB/s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711447227; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KICT4ootVVkt82VIPFNRhNaswFEFMB6uWwwdlc+odyo=; b=Nifv0FZX88quizLkdpQphaS7PfqMVM9ArrCcCEpGk+35zdfozitUjml3zkzOyQKwHZ0nLb McctA9slEgNiv+Aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711447227; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KICT4ootVVkt82VIPFNRhNaswFEFMB6uWwwdlc+odyo=; b=UOznrKGVKIfFw2Fuszv5rYbTxsSo6NUggGIl4qc4DEs4/FyktjuYR8w/28z9wRcXhmp5DM yuDOfmvFfgFCmZqQuLpc940hGiok4U5tIA1OnKTWVm8hgbCxN1xChmxDD0tz78xhpYhuoV Y4rO/xz2+NyOS6VhgXYbMjfCH5lhB/s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711447227; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KICT4ootVVkt82VIPFNRhNaswFEFMB6uWwwdlc+odyo=; b=Nifv0FZX88quizLkdpQphaS7PfqMVM9ArrCcCEpGk+35zdfozitUjml3zkzOyQKwHZ0nLb McctA9slEgNiv+Aw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1759B138A1; Tue, 26 Mar 2024 10:00:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id uMT8BLucAmZfeQAAD6G6ig (envelope-from ); Tue, 26 Mar 2024 10:00:27 +0000 Message-ID: <3aa8bdf1-24f6-4e1f-a5c4-8dc2d11ca292@suse.de> Date: Tue, 26 Mar 2024 11:00:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/11] readahead: rework loop in page_cache_ra_unbounded() Content-Language: en-US To: Pankaj Raghav , Matthew Wilcox Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, gost.dev@samsung.com, chandan.babu@oracle.com, mcgrof@kernel.org, djwong@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@fromorbit.com, akpm@linux-foundation.org, Pankaj Raghav References: <20240313170253.2324812-1-kernel@pankajraghav.com> <20240313170253.2324812-5-kernel@pankajraghav.com> <7217df4e-470b-46ab-a4fc-1d4681256885@suse.de> <5e5523b1-0766-43b2-abb1-f18ea63906d6@pankajraghav.com> From: Hannes Reinecke In-Reply-To: <5e5523b1-0766-43b2-abb1-f18ea63906d6@pankajraghav.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: 8wq5xfkmjf8nsnhdgda5q1tjepxk55c3 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0993E12002E X-Rspam-User: X-HE-Tag: 1711447228-414649 X-HE-Meta: U2FsdGVkX1/BTDfzqy7Uwi+WJLXhkhi3P1gjbf1K2dw7PfGE9pyrcXtz6FZd8Db25mRPLRjzc9iD94KkCppOaXT5BCLJ5e3LDdyT5fHnt+ZhnGsCJBMlLMJ3cqj9h+M3mnYoZj+c5KNOCwYDfb8DCiJoN6nbJQ42wddtbsu1QuDZ3JrkNKi2VR8JGtYCW4bKoRDxdtwMT9Q2SvsiAa1tkv31kmB3abZ2RzbmsXeQZYE2OxRKmkZCgOw8BFBhI31X7R/l8i3L/O7LltuzxYWrODCBvEKWeANkatpCZTDEfHLSH+2UJ/3+11jz01HM3MK37tOwjvGLGu6uZDszmBaOTqxEgtnIJAMIvdToem+r4srFL6TH5vEywZVSAJdKKGNshS5exYNBFTW1nW8rKowq0cm6ZlbG3bpvsxEW7AqnSdcSBjBfV1pxOaRYQqF0ppqburGZNENDZNVCiO9gihRZZYHJhkUaFGX5KMDH9KEpYkWVzF2I5SLuhyT+kxzJHPvCktQRgZAgHbIphDTrDv+fsqNs9G+C236J0rMifMfDgA4bmQKfsnCKwGQwfDYR1TbXujwCS/9iuOecUp3cet0NRChT1LjfzaIENedSiT7wngiVjXyGhdPsvSKArPpy4JsAEFC/6SZu6TPLE+siUG+AWPEuCJCKf7ON+lUJ859vAhhZzYWkxJ4Jvyp2a9lOGRudJo7FGsfnLrIf0UlUVWoIXUnorfnWSi0fxR3Ry4r2oQvFLFk0mREQqrQKv5fO3pEc8gW6RH9kMoIPWnd9wopP9bGGHixMvtOxz4Hne2lYTf7WFjBsjcm9/fB5pSOZPXtKA1aW0MEoLiBOsnJq/dqlUrqtFw2v+YpLm2JFAmhvLpR3eENmGbDrAl1tqnaNtl9grfl9mDr7U7oQxz7SMlJ/oyHJ/TpmSoqKd3h1zV0IpguVAZe+7tEtpKfCxuGTK6qDdG0UfXc6LLr0Cm4FhwW EsSBxjC+ laPjRO5t/R29SSmATNnVTb43N4YVcOpUcPqtj6U1JvCXWe3h9+5eMzb3cR/UtvHN/TiWYfi4LSczPxRvImTaOLuGjoxOMSJC2SMlXdKs4EY7XtP7p26xSoLuYoigTT30vC3xf8A17SHci4yAYTZ06a6XCxTL6NE0j4oASjR9ZCv6AOVtPMT0lzvgK6d2RshBoAiqrcgxjdH9tUd+6vmVbKDO6ApuQh/dzR/ZLl2bDb8DsjnvGw79hBld3y7mO0dEAD3IM6ID1nCFOK2TsC8xQjk3PHbD0/vfa3RJ8wmY6znUu/rv/Xtxj8aeMu8KfgtaTUzG3CZxDa+sK0JPA1nw5YcPKWZLP9ECxtyylUUHccsXO+t6gJA0zuKD5yM1KSvkMWhEZTusKZsjoQGQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/26/24 10:44, Pankaj Raghav wrote: > Hi Hannes, > > On 26/03/2024 10:39, Hannes Reinecke wrote: >> On 3/25/24 19:41, Matthew Wilcox wrote: >>> On Wed, Mar 13, 2024 at 06:02:46PM +0100, Pankaj Raghav (Samsung) wrote: >>>> @@ -239,8 +239,8 @@ void page_cache_ra_unbounded(struct readahead_control *ractl, >>>>                * not worth getting one just for that. >>>>                */ >>>>               read_pages(ractl); >>>> -            ractl->_index++; >>>> -            i = ractl->_index + ractl->_nr_pages - index - 1; >>>> +            ractl->_index += folio_nr_pages(folio); >>>> +            i = ractl->_index + ractl->_nr_pages - index; >>>>               continue; >>>>           } >>>>   @@ -252,13 +252,14 @@ void page_cache_ra_unbounded(struct readahead_control *ractl, >>>>               folio_put(folio); >>>>               read_pages(ractl); >>>>               ractl->_index++; >>>> -            i = ractl->_index + ractl->_nr_pages - index - 1; >>>> +            i = ractl->_index + ractl->_nr_pages - index; >>>>               continue; >>>>           } >>> >>> You changed index++ in the first hunk, but not the second hunk.  Is that >>> intentional? >> >> Hmm. Looks you are right; it should be modified, too. >> Will be fixing it up. >> > You initially had also in the second hunk: > ractl->index += folio_nr_pages(folio); > > and I changed it to what it is now. > > The reason is in my reply to willy: > https://lore.kernel.org/linux-xfs/s4jn4t4betknd3y4ltfccqxyfktzdljiz7klgbqsrccmv3rwrd@orlwjz77oyxo/ > > Let me know if you agree with it. > Bah. That really is overly complicated. When we attempt a conversion that conversion should be stand-alone, not rely on some other patch modifications later on. We definitely need to work on that to make it easier to review, even without having to read the mail thread. Cheers, Hannes