From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D758CC83030 for ; Thu, 3 Jul 2025 11:30:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54AC46B0174; Thu, 3 Jul 2025 07:30:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FB196B0175; Thu, 3 Jul 2025 07:30:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EA596B0176; Thu, 3 Jul 2025 07:30:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2A7686B0174 for ; Thu, 3 Jul 2025 07:30:06 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9BB141A0176 for ; Thu, 3 Jul 2025 11:30:05 +0000 (UTC) X-FDA: 83622734370.26.961E2A8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id E215BC0006 for ; Thu, 3 Jul 2025 11:30:02 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qrhqkm15; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751542203; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XR4Paloy7yGkbdQFdRMPvTKd12cQqil1oejrUP5ZAHA=; b=u6P/j+/Yh9dWZnG3pZ0VnKBpnzYKOB+2BKCA155Sc4XZho2R7THVDSJbVRaj6Edx5dh4fA jbOAdcbA2hLENeVzAYgmwIkQf0/o85XoGGX6VmKawSMcK2kk3GI3sExINJEzukol3nb+FT 6pzvjWfoRk6QakFOcY0hC984YsDyhP4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qrhqkm15; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751542203; a=rsa-sha256; cv=none; b=LN55qRJt/Xw8saIPjLS/i5ewK8toadsBp6O5jnxQO1GrAh/CXZiZo2lwsRkPrGQgHl5kAc m/e0mFTbyWa2R5mfY0n6Ku/rxC8y9UjsjMfrLls0KfVFomOIjF0ojp/eatuFJIRLFvSPDh ARs8sSu3LaCSkONtea+hCezYNwJmp0s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751542202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XR4Paloy7yGkbdQFdRMPvTKd12cQqil1oejrUP5ZAHA=; b=Qrhqkm15jwwh4uz6zr5gbMCP59imcy2zoBGydiT9EQ6P5Uaddo2VUbpQAD15j8Tzn9MRd/ NeFxkpKyYSacLvLZfHYashGZ5Kb4AlYQwwE+IavYlp+3P+1BTTwJkLUI3+zYAmfvNB+7sS 8sciWevyybqKrrr8pCDYCDBdiOJiCIA= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-195-6TMZHtC3Pd-waMrU3ftoOA-1; Thu, 03 Jul 2025 07:30:01 -0400 X-MC-Unique: 6TMZHtC3Pd-waMrU3ftoOA-1 X-Mimecast-MFC-AGG-ID: 6TMZHtC3Pd-waMrU3ftoOA_1751542200 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-60995aa5417so4683194a12.1 for ; Thu, 03 Jul 2025 04:30:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751542200; x=1752147000; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XR4Paloy7yGkbdQFdRMPvTKd12cQqil1oejrUP5ZAHA=; b=UmboZIXKnvKdeaIE8Zig15yNe6kiUozeUVIr/ApwVVbBhg4R8TPimmjHAOkduONCQB VwC4Ow4xqbngqagJUEJ05MCXB0P8+bkgpikC9DQAle6G6NZUibWpzVGlRzfKkaMNWa6J 8kNlNkzGNUBUPzAPhi5ziApJpmWV/NZYVMOCyThMO1YNUK/K0w5oPrsc42udCbnuIWNj JVTIavsk62e5BYBlMiwnc9Bwd2OCfqkkMT5PMvBqyT4Z/KGvOBE7Fk5FfiAIb0WmSznm yBAOKS3Fv8Qt+6Zhb6wWsvqbchYBYJ22qVtRjnDtjZva0vGK6ZRkQlwL6XZ6yGBFjN2o R+Ww== X-Forwarded-Encrypted: i=1; AJvYcCXggkzI77ZFCsHpezwWFfmt8yUA9hnEa6r0MGv7De+wGkArUtuzlO/x058A2hKAm8MjOPo57TTRAA==@kvack.org X-Gm-Message-State: AOJu0Yx6Vy6wdM6t0eWLEyxOl2eWLuBoXsns/kuIhxLYubUn3X3f6tXl TTpON1UJ8b1ytF32ADW+u6o131ZzcpUHfv0TEp0Nv32Z8TPbTd+wqg6H1UuEasDdnubaZjNHu4z GxWMU9OofOOULZCkXyxG0Yx65ght80rmVCOpfnDrSVFYaAKzHlQay X-Gm-Gg: ASbGncuBSlw7fOsi0Cxc6dEQt+qrXL+Sxd66wmi+m2qyM1ULOXogMzbhh5bSujgUXa+ HfpxHdU76ZNHYb9Vk77tQLkhCiGf/Zquo4ByHLAeaExGDptDWUKstSE/8sx2uTPJLdCX1Z1Ttx1 1+EtKcqv0nhiuSvlNpQprhcJaitTwAvDoKnbFxVyn/PMF00/ZDbsV07vBKaOk1okgIzZT+ZN9rI tj5Yge/v5dFJvUJeBdSTmB0EM8ApWhv8lIRTS8f0+tXF1DYF9XP36fhrdr6pIt84fJArrh2tl4G XSijx4QUUrHc2qLAeuGPNqnWMKJ654tLlPTomnn8maOq X-Received: by 2002:a05:6402:35d4:b0:607:e3ec:f8ea with SMTP id 4fb4d7f45d1cf-60e52cb3a22mr5312582a12.6.1751542199589; Thu, 03 Jul 2025 04:29:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGImfxdx1oK2QGalG5wHR5ybyUV9H8EZUFbzVj3VCe3r+DjIH4hLsfXNYhOHhktRrDF9f6tog== X-Received: by 2002:a05:6402:35d4:b0:607:e3ec:f8ea with SMTP id 4fb4d7f45d1cf-60e52cb3a22mr5312546a12.6.1751542198979; Thu, 03 Jul 2025 04:29:58 -0700 (PDT) Received: from [10.32.64.156] (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-60c828bb1d8sm10548059a12.6.2025.07.03.04.29.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jul 2025 04:29:58 -0700 (PDT) Message-ID: <3a790038-cd63-4c4f-af05-e98aecb56bb8@redhat.com> Date: Thu, 3 Jul 2025 13:29:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mm/memory_hotplug: activate node before adding new memory blocks To: Hannes Reinecke Cc: Oscar Salvador , linux-mm@kvack.org References: <20250702073913.58247-1-hare@kernel.org> <20250702073913.58247-3-hare@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250702073913.58247-3-hare@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -r3JjmzO9uGRJVfN7WmmgCPh2qQd2D-En5fciuMobGI_1751542200 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E215BC0006 X-Stat-Signature: sjmz7wrctcbe967wfnposkaocn361fab X-Rspam-User: X-HE-Tag: 1751542202-375887 X-HE-Meta: U2FsdGVkX1/dghKVLMASyoaDbTNrZYLoMvA5rUYv8EQkb4nDKDFbg8TrNbLmNlFrnT7we8wCOdCuNyw3WnR+MSdKmsTZdV/3jJj50Y3VylK6uYc38uG+kpzIkPlzOTUH1Xpxt+FsTxkosKtr51N9WibPfAnqBUYy2N/lBa/RymmDJ8Ex1UY+80Eztv9FZG2troxLyVM8Wz9nOQqGNrJycBRX957eAFN09lDp45MAU4sGciBwUB75TnQg3I0iu7RyoX8/I7ovcs/TBy6KCheijU1d/djvCSGtQunkODe3XwwF9V39iVutyBHqEa6hg2goefQat2NlHSh2aDp5nNu65ly2/M38CsAAkTHzA6eI1idIPGb+KayunKjt6i/z2QnSo8zja3kHi9xKTHs2g6Qp98kHBWDFRMOK/iaFsecByekiP16mU+MDE7PjKBnkpceSzWwIKIwXZPYi74oKnmugZSF/JR1du/HwsdN+PWf9lHjL/WlDwt40YbYvq1ccIHb+iEefv/6gRHEU9mQzKh1RsE5zp+iFIZ861AZYhm0cDb5BgNJgU6rYZ2kQJIvEXY0zcxz8JhPILFKVWBIor1QsUia38+BflarLB/y86PnQxOPNAnZtv/PgUIJaVvZl93g+2pb4Cwt6AmN5DJasTUQaw2xovSbpjd0J26ctYGP3MQXU2hHeXWUYxbKVpfJbyBFBjk8j/E9cR0WMT6l2qe6sNBVJAGqyci2j2ySyfdf0Bg1rRyl1kkcKyD+lG+P12Xw9JWKIBrWEOV145iaiGyvrZiPjXQQt16M7TEWnzqaJ+H1ynpSQP+AKxucF5Zheh+ZGM4f/q+SA8z3QrlJlHPGpMccXWS9sbjXuUHQ/NtIht+T/HTJ4FE6/STu5f6vudzJQspagUbilaq9qfoIUvB5r8YU4AQAJu1dAxmYlTD1s+Xy6v3TfKPSWfZfgBI6AOIFqw1sgWXMkh8eAOtKtaTh fZIxmSbN ne/L49Lwlf1nGJkKpgbPvjdy4tXmYZbB/c0yuHPvQlSY3VR1E07FePATNJNgz50McFj6vpFI+sadLC8xcrgbseuRjFmjmgl15W8viGafutYfQHmbJA+6+dlcQ4W9x2Ge1paJhNi70JrSkx2kme2hNuuLshGjwEBfg1M1hIixVqDQILwr2ACvhdM3rcda6f4lDu1bpINmf/zdH00cWmhewk0W16nRr7DEz43lALAIYhZKZmckH8nVSkTH/orv7k8lXi9q169DMHC9EmIVonEWlhu/qlWwpNRDvTYhJDYprDEHIisF0dTQdFCqP/TkYLtUF04Qk4psvQrswuvCgaDviNs9x4TT/H+DTwhpAPoWZVi9frsNFkizJBRKUvZVpU/X3vcFqfdfcwyEeU+VGG2c+vEZJ9rQf3i4JmnUeY6F8//GcQbqm8+GNTqcN7wBwa9On+qfRRlfHqH7brONbCFr0aCHiKUi5gHMj5Xm7dersuJmLneIykx2OBycbxUsTsq20ezqa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.07.25 09:39, Hannes Reinecke wrote: > The sysfs attributes for memory blocks require the node ID to be > set and initialized, so move the node activation before adding > new memory blocks. This also has the nice side effect that the > BUG_ON() can be converted into a WARN_ON() as we now can handle > registration errors. > > Fixes: b9ff036082cd ("mm/memory_hotplug.c: make add_memory_resource use __try_online_node") We should CC stable. > Signed-off-by: Hannes Reinecke > --- > drivers/base/memory.c | 19 +++++++++---------- > include/linux/memory.h | 2 +- > mm/memory_hotplug.c | 32 +++++++++++++++++--------------- > 3 files changed, 27 insertions(+), 26 deletions(-) > > diff --git a/drivers/base/memory.c b/drivers/base/memory.c > index 2b951e5f8a27..d24a90e0ea96 100644 > --- a/drivers/base/memory.c > +++ b/drivers/base/memory.c > @@ -810,15 +810,14 @@ void memory_block_add_nid(struct memory_block *mem, int nid, > mem->zone = early_node_zone_for_memory_block(mem, nid); > else > mem->zone = NULL; > + /* > + * If this memory block spans multiple nodes, we only indicate > + * the last processed node. If we span multiple nodes (not applicable > + * to hotplugged memory), zone == NULL will prohibit memory offlining > + * and consequently unplug. > + */ > + mem->nid = nid; > } > - > - /* > - * If this memory block spans multiple nodes, we only indicate > - * the last processed node. If we span multiple nodes (not applicable > - * to hotplugged memory), zone == NULL will prohibit memory offlining > - * and consequently unplug. > - */ > - mem->nid = nid; I would not perform this change in this patch. It's not required here, right? We're simply re-setting the nid. Patch #3 can clean that up. Apart from that Acked-by: David Hildenbrand -- Cheers, David / dhildenb