From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 459CEC433EF for ; Thu, 9 Jun 2022 23:16:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90DF26B00B7; Thu, 9 Jun 2022 19:16:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 895DE6B00B8; Thu, 9 Jun 2022 19:16:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 735E86B00B9; Thu, 9 Jun 2022 19:16:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5D7826B00B7 for ; Thu, 9 Jun 2022 19:16:18 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2D88F211E5 for ; Thu, 9 Jun 2022 23:16:18 +0000 (UTC) X-FDA: 79560258036.12.A568E27 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id E7AF6120075 for ; Thu, 9 Jun 2022 23:16:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description; bh=s6f6JLtoaOli3gEhHTppp4fmxuJwb8QIU15eBakfOJU=; b=i3qj63WrYUNY43MsN7ARPnlv0w uhTtBf8MplRqkVMB/I9jOTstcPT6ZK+6y7m82ty5GKfMfhF92mGMAti1AG/OXZYAPUeJttdRU6UwF Y5O3WPbkmENJgFLqmh6wbK2eOgNf6Enb7sqWTh7i4qUab45mlSpZ3LVw826gFmWwhHquxIngcAy8S Gm8k4+KVgF6yTPW8u5Ayl956vcUcvRax5+ZOTb0FvlddSrT+XQb2bhvUgG55iQaUkRdpB7qxlpwLW 520dbhk/1P/Z6KN3O1BKt3GiFEJmhyjtSTMfCkQyd2PCnjNlHiclShan1cErMRn8vtPbnPCEOiBYt TO7/TPBA==; Received: from [2601:1c0:6280:3f0::aa0b] by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzRMu-00DvXN-9e; Thu, 09 Jun 2022 23:15:12 +0000 Message-ID: <3a773edf-f850-e83d-828d-19f91a373384@infradead.org> Date: Thu, 9 Jun 2022 16:14:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 01/12] x86/mce: use correct format characters Content-Language: en-US To: Bill Wendling , isanbard@gmail.com Cc: Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Daniel Kiper , Ross Philipson , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev References: <20220609221702.347522-1-morbo@google.com> <20220609221702.347522-2-morbo@google.com> From: Randy Dunlap In-Reply-To: <20220609221702.347522-2-morbo@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654816576; a=rsa-sha256; cv=none; b=KEEL4qEHfYDDrJxndvtxeZN7nFwDTVEk0vKqV0NdYwi8fmiJ1oQfEozLuDstyvYJrgOo2R rO3ANpabsEkrxL12+JZGqowAysseLZH4pJvuHPqFQrgcCFl8KwknAypcSS8P2bMRt8hEN4 XeVWit3gB/FtA8l1sJXCVTuwhgSyhP8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=i3qj63Wr; dmarc=none; spf=none (imf29.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=rdunlap@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654816576; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s6f6JLtoaOli3gEhHTppp4fmxuJwb8QIU15eBakfOJU=; b=qlFX/hFYzZINYF6pZEND6Zx+vbCV09dIPaV/XjActrCSTx4SUjVDRhdmky2KS9KjD6iyZI XjUE7/zV+cwKTXMcXlGmv7okAgyJARyReXH6FxMqSaR03dYz79DTcL+Qdx2geTvUriEWY9 lSrE2hO4WkHsMpnwboqP5ja30mnApU8= X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: E7AF6120075 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=i3qj63Wr; dmarc=none; spf=none (imf29.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=rdunlap@infradead.org X-Stat-Signature: fgo4r7eet8m7hgc4ibxdih6n9hb6ctfy X-HE-Tag: 1654816575-757960 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/9/22 15:16, Bill Wendling wrote: > From: Bill Wendling > > When compiling with -Wformat, clang emits the following warnings: > > arch/x86/kernel/cpu/mce/core.c:295:9: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] > panic(msg); > ^~~ > > Use a string literal for the format string. > > Link: https://github.com/ClangBuiltLinux/linux/issues/378 > Signed-off-by: Bill Wendling > --- > arch/x86/kernel/cpu/mce/core.c | 2 +- > scripts/Makefile.extrawarn | 4 ++-- Where is the scripts/ change? > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c > index 2c8ec5c71712..3d411b7c85ad 100644 > --- a/arch/x86/kernel/cpu/mce/core.c > +++ b/arch/x86/kernel/cpu/mce/core.c > @@ -292,7 +292,7 @@ static noinstr void mce_panic(const char *msg, struct mce *final, char *exp) > if (!fake_panic) { > if (panic_timeout == 0) > panic_timeout = mca_cfg.panic_timeout; > - panic(msg); > + panic("%s", msg); > } else > pr_emerg(HW_ERR "Fake kernel panic: %s\n", msg); > -- ~Randy