From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8630C61CE8 for ; Fri, 6 Jun 2025 11:51:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55E936B008A; Fri, 6 Jun 2025 07:51:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5362B6B008C; Fri, 6 Jun 2025 07:51:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 401756B0095; Fri, 6 Jun 2025 07:51:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 17EB06B008A for ; Fri, 6 Jun 2025 07:51:32 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B8DBF1420F9 for ; Fri, 6 Jun 2025 11:51:31 +0000 (UTC) X-FDA: 83524810782.15.B5B3150 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 785F940006 for ; Fri, 6 Jun 2025 11:51:29 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dffrT20r; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749210689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HBNIv4v4CDaVQ8ZIjf4kNfpcVgMGwx5JzlOzvqm3Fu4=; b=eAf3F0AgpBfFjlcPSmLb5Dhw908r5+0wKHQGWCL5BFX//R+xlwqc0qpVa6vpcS0HN/z3MX oJ7XOt6Tlvmu8qM9aDTwWEScT5iG2rVhwh46R/XHNbZkXFMgORHQ6mm4o9lz4i7p/WjmBL 94hEMUHdTvtVw/9O9/4cAb4twU+NVa8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dffrT20r; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749210689; a=rsa-sha256; cv=none; b=yIAR7WstqRo3oI1IxBL8xvWFt//fihLQKOdsuKHT6jSE2VIiIcKNdm/ExLksODHPcfcXOw ie2Tr7kSqO3ML4+1cABnUYglMz1a1Q2shoZ3/upBZ23vAFqaXAW7vfnonvfxtASDHPl8Vl S7B5M8TuoEZUjOgrp1P1GmJMZa2WxG0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749210688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=HBNIv4v4CDaVQ8ZIjf4kNfpcVgMGwx5JzlOzvqm3Fu4=; b=dffrT20rXXhOo6nYwTtFAFgxWjrDN9YFHlEdu+TY63rozhJQ963jjHycitsoIj6b3iLC5c l6N5u3Z6fSmP1ozCvHALquUtUOkOzOjgAbqEUyRPVofXWLdSHAGzAUQlatgLLLIIcSwdq8 M/fIACdQKrPtc4Ikl/tX24N4JQUDtwY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-aHPsxQVoNUuWaDk5nkHGcA-1; Fri, 06 Jun 2025 07:51:27 -0400 X-MC-Unique: aHPsxQVoNUuWaDk5nkHGcA-1 X-Mimecast-MFC-AGG-ID: aHPsxQVoNUuWaDk5nkHGcA_1749210687 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-450d6768d4dso13139465e9.2 for ; Fri, 06 Jun 2025 04:51:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749210686; x=1749815486; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=HBNIv4v4CDaVQ8ZIjf4kNfpcVgMGwx5JzlOzvqm3Fu4=; b=Vv4xZfterc2qek+ANL3JdCyJLFKg3Io3e4WgQY7fDDG4b6GJG3wf4i/x7TScXNRuGp Uco7l1EMQS3ZsuYvJSaLmcyNOE/4rO1An6igvHGkTdv5eojGklXJTxFMedNXQG/q3M3p HOF330SZOyRFhnwY0piUs02QGyPSAnWd2YpEGC4LwkgleGeLuXaJnWveV1byvzcYI46n uq09zR0oP6hkq4vMqi81gvY3v1VA3mdIOP5Hs9VS12Ln0gal8b9GALS6c1ZSRc6f+6SV H7EK4TtqgY2Bjp40CB9IPOLsd4L56XNnkH81rgl8o+AOTWTG7i6jeJg54bpKye5Z1g7g 3iyQ== X-Forwarded-Encrypted: i=1; AJvYcCWz0+VpR6fStnnSm3vxUEtFI2Cr+R8mtV7adxvd099rci8kmSvk/Ux84PlITpEnSou/LthqewC5DA==@kvack.org X-Gm-Message-State: AOJu0YwcX3E+OnmQP03n3SBOGeO0vjGX9eWkT3Fgbib8OwY6wIHcuaF9 TPaQsd82geWNWYbshwRjish6+cw/IQlomFtbCxDTOZa2TgBnv6dhiX0Q41Hl+WsamYND0rdLhkx BVXlP0ZLhTWcV2D7RF7ToZRLHWcQQs5H7Xs2G76xZtxyLevjLF3aC X-Gm-Gg: ASbGnctlDYxV318xk4tBYjJKf61Xvt7nC007vSupeWmC508WCoWytn9EjSlVTRa/gzq o0ueT9F/1oSrCpjIbxrNRhSwBotVMimdEeDclTdNYM+XWYKN5yE0iAN+uTuBatGunqU/dYOd+Wa k6SnfqBAJyZR4lMKhucN/pDQB8uoWIxoJgbh0k7OYQPHoAK6GhAxpGd1qpezpbt9Ml2Q+isM22C tz7JrUyIDXe0TKhMX2d73xrWeflF20tH9/NWSaceDLgDsIxrrMFQ277wGGn/lnAhvBwORHvwIS+ ifP/lcAMsiON+nmo4sFKsROkk5nqjwCgWyJkaFEikh9k0lB/xCNmULD+x8RmeLKBDdxMRUxkE2p kbXwpR9WY2rfvboNPT+rK2KBJY7TP178XFbols9+f2g== X-Received: by 2002:a05:600c:5396:b0:441:b3eb:570a with SMTP id 5b1f17b1804b1-452013681efmr36330175e9.2.1749210686521; Fri, 06 Jun 2025 04:51:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IElH7bwO57ALfHi1SkLqsprEBH0fmkDmJSbPoYUAVfRjcV047e6NdMnUnc45QEilr6SuOtg9w== X-Received: by 2002:a05:600c:5396:b0:441:b3eb:570a with SMTP id 5b1f17b1804b1-452013681efmr36329955e9.2.1749210686142; Fri, 06 Jun 2025 04:51:26 -0700 (PDT) Received: from ?IPV6:2003:d8:2f19:9c00:568:7df7:e1:293d? (p200300d82f199c0005687df700e1293d.dip0.t-ipconnect.de. [2003:d8:2f19:9c00:568:7df7:e1:293d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53243664fsm1672259f8f.65.2025.06.06.04.51.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 04:51:25 -0700 (PDT) Message-ID: <3a6f0f37-f4a9-46c0-bc3f-5c6dbf4a765d@redhat.com> Date: Fri, 6 Jun 2025 13:51:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 06/10] drivers,cxl: Use node-notifier instead of memory-notifier To: Oscar Salvador , Andrew Morton Cc: Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250605142305.244465-1-osalvador@suse.de> <20250605142305.244465-7-osalvador@suse.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250605142305.244465-7-osalvador@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: iEB3q9GwORpj6X0zXIF5gDaq_dO9MHxzYgoK9mIrhF4_1749210687 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 9k59mcqbhorfwoqxt56youmtptmtq1dc X-Rspamd-Queue-Id: 785F940006 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1749210689-582588 X-HE-Meta: U2FsdGVkX1/gR6wkV70HsDREsja14oW0IbOwKOM0hqiRwvpiuWzaPuuhV9lvvbWlfWFGCuNnoWxRr3uLE9skRf/9UPHw5Cfty5cs2J0uT513l4ig7h+iD+Cu+dvtNAzpv0NAuJiTpYKnyCVhU1sblv9otS87z7FP4ysUrU4Gv3Z8e3xgxJ8+MFNCeVWLZP5kU7ycLix4UeX5CcYGVvnwUQorIZfG85uOn95J+Bf7nhLBairI6QCCUeVcnRi4HmhF4geVOa+sDJCKp1NhhrpwRG2s6Rd0YL/dSnjyhgaBORiIcLuVQsWifA9ippUDWqIiPqc9It+1bF/hf30LVFX+Jwlip7Kwcel7pYZb1r9rfAruRkRnO2sI9Yia9rb1MKDE78+srxU7xu+cIHJlY3ySLuQmXP3SvUmiw0Fx5W4ddMA+ifz/UU3uzmcUPyrxbL+GfPh8R6JsDUQpaLQE8o+1H1EAPIeVu5EiwLXKHGKkk3cw7LUXLL0HUuLa/KxD6Ya/DIp37sITHc48DabejsRrWPxlL9S/9I18hFaomzfVCDjN9J1UfTgNcOqEZ3GwBO6zyGEC88yHV95FfCYcrM5hExz5PagY1kWvD2TjWk6L8yU0z1/uWwbZ8FbnugFjyXCCP+8spO3WhtxZVt+IXmId0VNbKM/8bk3VyBHn3jOHco2yi/s/0jM1/eDe1gsaViObw/gsKrlhdPoSHws0XbWzMNwxkkEaKi+Ug6lFMKj7W6zDCTGI0i45qFxbXS16jNrGAShJNtud7364EbuSpiHP73b7E+wzx6ETfAxYA+J6C3Cr4WzTaci+tMTO33lpkICbP8ERLiIa3j9W45iXy8/gZuayPc8jHC8ZPThR1psg1MGg/Fd4hagAFu7wRDqqPqwmWIAE+ZNo4xDxwxsaxT7Rj6C8U6zuNM8oXia9VZteNU7XM3pT0SOvmwvKcGQqT3RB+P2J8o1rneG+B04uFRN 0iwPfZ+l 9TNs5W95T/8ZuldlQh77sN12dBhABf5oxhpdQaUxQmPvtBm8SaRAA1PVuXO+8TmXVJdpaPx8gH8suy/D/Ul1FAuoqO3uY/wAxRi2r20Ya7KzwMYjirhPGi22Cpw3Bv4G81+xfRBB9sUvDgae3YokiMJNGEA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.06.25 16:22, Oscar Salvador wrote: > memory-tier is only concerned when a numa node changes its memory state, > specifically when a numa node with memory comes into play for the first > time, because it needs to get its performance attributes to build a proper > demotion chain. > So stop using the memory notifier and use the new numa node notifer > instead. > > Signed-off-by: Oscar Salvador > Reviewed-by: Jonathan Cameron > Reviewed-by: Harry Yoo > Reviewed-by: Vlastimil Babka > --- > drivers/cxl/core/region.c | 16 ++++++++-------- > drivers/cxl/cxl.h | 4 ++-- > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c > index c3f4dc244df7..a8477a3e175c 100644 > --- a/drivers/cxl/core/region.c > +++ b/drivers/cxl/core/region.c > @@ -2432,12 +2432,12 @@ static int cxl_region_perf_attrs_callback(struct notifier_block *nb, > unsigned long action, void *arg) > { > struct cxl_region *cxlr = container_of(nb, struct cxl_region, > - memory_notifier); > - struct memory_notify *mnb = arg; > - int nid = mnb->status_change_nid; > + node_notifier); > + struct node_notify *mnb = arg; > + int nid = mnb->nid; > int region_nid; > > - if (nid == NUMA_NO_NODE || action != MEM_ONLINE) > + if (nid == NUMA_NO_NODE || action != NODE_ADDED_FIRST_MEMORY) Dito, one would expect "nid == NUMA_NO_NODE" to never even happen here. -- Cheers, David / dhildenb