From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC2B5C48BF8 for ; Mon, 19 Feb 2024 15:19:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 890CE6B0088; Mon, 19 Feb 2024 10:19:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 867936B0089; Mon, 19 Feb 2024 10:19:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72F556B008A; Mon, 19 Feb 2024 10:19:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6371D6B0088 for ; Mon, 19 Feb 2024 10:19:05 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0864816045E for ; Mon, 19 Feb 2024 15:19:05 +0000 (UTC) X-FDA: 81808911450.14.A3AF744 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf06.hostedemail.com (Postfix) with ESMTP id 949BF180005 for ; Mon, 19 Feb 2024 15:19:01 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=LFCePNxG; spf=pass (imf06.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708355941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yVGjdmY5iAHugXQNWJ8/Fw9WYRlDYQRwbAMRx27rxPM=; b=C/lyA70wS109t+TTYSV9zdio7N50OzO6jGSyCJhQVs/DGyv/1i77sng+z8L7IL1+kqiDoK Fe9wEzAinesPkLOnNry5Ib0haOahq0AKQCi2X1I/euhgm5jf9XRgJx5ITv618PNc/+eXhT vOEAkhfyV/VkJr6cmJzQqNCL3m+JBCE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708355941; a=rsa-sha256; cv=none; b=1N+/NuvG0at582irRhMVavfOiickT8l10sONS4cJKKQrozy4H4kRJqu7hPbZuHct1ykYnc fqMrRTbeR3PiZKu8hjXpCN7d0J22k1/cPuAT60jhSJUSEDUUp/7GjlsyGox0KOVPK6fb7R F4CrcDVEDo0fJ8ki4xmO/PXLwpak6GU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=LFCePNxG; spf=pass (imf06.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41JF0tbI026387; Mon, 19 Feb 2024 15:18:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=yVGjdmY5iAHugXQNWJ8/Fw9WYRlDYQRwbAMRx27rxPM=; b=LFCePNxGdnySouVA2yXL6+Qi29ZtkUS0RrO4zeIIXkC5MKTbZfm3D3/y99NCVTJ3w0tS a37pdUHXfxHvlO3DwsLcUuHUinFkATgQ4PpASTzDUNJVCYKw+XYjSHDkWaWgGSKq6m/C XoxVAMiakJQEkWGndQnoDd2DzdrTxfRvCzOOC7X7BojSJdAqupCGynyYvQpk4fsmM7To V+AAijx5SCNKa9wv/PLm0TYtmNlMkZT2xupyasxf9fkRQ7lxkgfFzSoYTuPL7CxRWdCX BKNHF454FR8E7NXmsrli1LPvQJsBqQpBTRyyPU7+WsOLL+GscJ0oy9bce53DoU5FXYfa gA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wc81bb45x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 19 Feb 2024 15:18:49 +0000 Received: from m0353728.ppops.net (m0353728.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 41JF13sD027418; Mon, 19 Feb 2024 15:18:49 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wc81bb44f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 19 Feb 2024 15:18:48 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 41JDGDt5014406; Mon, 19 Feb 2024 15:18:47 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3wb9u29dws-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 19 Feb 2024 15:18:47 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 41JFIibA16450056 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Feb 2024 15:18:47 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BD66558067; Mon, 19 Feb 2024 15:18:44 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 28C1858052; Mon, 19 Feb 2024 15:18:36 +0000 (GMT) Received: from [9.109.245.191] (unknown [9.109.245.191]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 19 Feb 2024 15:18:33 +0000 (GMT) Message-ID: <3a64efcc-9a9d-4973-92f8-d76899f01868@linux.ibm.com> Date: Mon, 19 Feb 2024 20:48:31 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mm/mempolicy: Avoid the fallthrough with MPOLD_BIND in mpol_misplaced. Content-Language: en-US To: Michal Hocko Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Aneesh Kumar , Huang Ying , Dave Hansen , Mel Gorman , Ben Widawsky , Feng Tang , Andrea Arcangeli , Peter Zijlstra , Ingo Molnar , Rik van Riel , Johannes Weiner , Matthew Wilcox , Mike Kravetz , Vlastimil Babka , Dan Williams , Hugh Dickins , Kefeng Wang , Suren Baghdasaryan References: <9c3f7b743477560d1c5b12b8c111a584a2cc92ee.1708097962.git.donettom@linux.ibm.com> From: Donet Tom In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: U-OLzk4O98MX92nF8yp1-quPYt5Up4G6 X-Proofpoint-GUID: NJ0Rt-lau9wYBECklNCSjEcuji-DF5vn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-19_11,2024-02-19_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 mlxscore=0 mlxlogscore=999 lowpriorityscore=0 clxscore=1015 phishscore=0 adultscore=0 bulkscore=0 suspectscore=0 impostorscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402190114 X-Rspamd-Queue-Id: 949BF180005 X-Rspam-User: X-Stat-Signature: sy5zpdnwgudeh1beixb66w8edff13dsh X-Rspamd-Server: rspam03 X-HE-Tag: 1708355941-570560 X-HE-Meta: U2FsdGVkX188yBQVaRx0fISuhtVvG1KgEdYpcoOsKGdqlxXqabGOLWKwz/2aeWZ80uW0KKCfTTyssT+Uj1dN+Z8N5z38cPcaJfbfCy6K/t0ivXhq2OOwlY6a9mWam31fCUL5bEtczQRXeX3ZovPW00suthlltcvdcVxwlmhldvnXSvEUy2w25JGqgYr+r3AsF/Y3LM9WQr+QPqe9iY1JnqJauI/nlgpPoQvL+/NkRPLrDHVu9NQxpBfWcF92A33bY2JJAnqGcc/3OmpsGXXY+micQYfSAVD3abhnko79p1hQ3aJTcdFxz4t7G23Oa44swhB+YchPlfffV9kosVMPmk/QRllqGfPg1KOZdXWQIP2N74xdThjTwY3XhRNoShrUJyG+vcVM88U/ZqdTbVSswK13c8l3/Kp1NeuOvwAylfrfnW2Lw6iWxL/bvR07eSGiFCxH3EfAGq0aPmJE9kYnTUKOYgdPLdvbviYuhmXplM+Xl8EyDAMbLSuo/XLsMdUtx76364QWu1nKqqYalsDjKcNJp4wz4hHbbIxA7HSuaft97xf3+I1xYkmIQ3p8wJeo9o3QI6cGHyekjIxH+lSoNmW360BBXxV53bdu/b6pbEwgEREQu1aY5iRrhPLOKGFly0siGc9imKy0UFXHJG2qrMWD15bnPzEcCMtyNJWytNsrYrxUzpjwQ9p5SjqtNMaexxh5xS6OagYn9Sldr/7Wc6fd3NLFPTqLNpWM92/nGgol0dtsxdWVdVihIkGxhH43T5qLPDdgjYotO5tTfCa/SzUf6X+8Ugw1tQn4OZvXN3S+mDw3dyFjfzOMXgpBnaZmEE2YO6X4Wt1VdBUqEvBreaynoiYvSOGXA1MyVSk8uGXBrD07mmOGxBzMHffpQzLmqGWCoZ6ardKIdoZ8XYbQ2vDGyHqHCEZ7FnU4Bp7GGn0U2lg1+5fNgjcm+spu6MQAJLqTHd1nuAY0CZfLMNX xZKX/xdM 8iKvD+SZbSNeF9UiMC+6+HVhUo/6dc2uTXdR5tPbYRC2bgLXWR+eOR8MKkq81DX055AJuAoYvooN9JCgvHeaIEO9iEhmp+2n0lEWim7iIMhIrvv7rMj9EpcPOvugWPteRy9nZLjVWodI9SluCexp+itN7uan+fJqHFah5r/qTgQXmJyGl/livhxR/IIlKxRZJcrGrm3CIKapkSjEHlXh1oXgVcvsFVYLzXhy+l6HqInCCVw9irZhj0hYjb2KirqqXONTr2syaDsnUPnpj3usq5MJ45uFOZmOrhE1eS/tmzALhxxVYP0cLfLA89KRd3l3mRcuTCgXSeatOsGyRJ9QDHoJY+bMymD03c/AXhwuUCb/MKBGJ/ySZ1YxvZbHAU7yu/x0HZSUKTJslK6pjctjH4BFMVxjpfMIePnDE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/19/24 17:32, Michal Hocko wrote: > On Sat 17-02-24 01:31:34, Donet Tom wrote: >> We will update MPOL_PREFERRED_MANY in the follow up patch. This change >> is required for that. > Why is it a separate patch then? Does it make review of the next patch > easier? If so make it explicit in the changelog. Hi Michal In this patch there is no functional changes. This is just re-arrangement of code. Patch 3 is the actual fix .It will not look nice if we mix these patches. As you said it is easy for reviewing also. That's why we kept it as a separate patch. Thanks Donet Tom > >> Signed-off-by: Aneesh Kumar K.V (IBM) >> Signed-off-by: Donet Tom >> --- >> mm/mempolicy.c | 10 +++++++++- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/mm/mempolicy.c b/mm/mempolicy.c >> index 8478574c000c..73d698e21dae 100644 >> --- a/mm/mempolicy.c >> +++ b/mm/mempolicy.c >> @@ -2515,7 +2515,15 @@ int mpol_misplaced(struct folio *folio, struct vm_area_struct *vma, >> break; >> goto out; >> } >> - fallthrough; >> + >> + if (node_isset(curnid, pol->nodes)) >> + goto out; >> + z = first_zones_zonelist( >> + node_zonelist(thisnid, GFP_HIGHUSER), >> + gfp_zone(GFP_HIGHUSER), >> + &pol->nodes); >> + polnid = zone_to_nid(z->zone); >> + break; >> >> case MPOL_PREFERRED_MANY: >> /* >> -- >> 2.39.3