From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F5D0C4708A for ; Thu, 27 May 2021 17:12:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B24AC61176 for ; Thu, 27 May 2021 17:12:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B24AC61176 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6A4AF6B0070; Thu, 27 May 2021 13:12:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64D306B0071; Thu, 27 May 2021 13:12:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FCDE6B0072; Thu, 27 May 2021 13:12:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B96AF6B0070 for ; Thu, 27 May 2021 13:12:18 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id AF40F181AF5CA for ; Thu, 27 May 2021 17:12:16 +0000 (UTC) X-FDA: 78187654272.34.46B26CA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 518C7A0001D8 for ; Thu, 27 May 2021 17:12:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622135535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8Tj882GRDYNKA/Odur5I8qEQKwf2uVi6wQUPaTSmUGk=; b=HrCJpxEGjNmvGTuHgWD5CAt6PACA4sihNoSY0/sQY/ZzPddTY1rqJ9gOqHpuGAQm/Lkr9g Bo40t6dAnWbktp9i/Vm1YcuwLYjxNFHIFzRRPdDNgsqw1a6kyEzFqiNA6PhTMZ1WuFEW5l PxVFKhA9AGLdJhd2Nyu56tnIbPsxCDk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-552-M1KAoR5FM7qxPykHV44kwg-1; Thu, 27 May 2021 13:12:13 -0400 X-MC-Unique: M1KAoR5FM7qxPykHV44kwg-1 Received: by mail-wm1-f70.google.com with SMTP id o10-20020a05600c4fcab029014ae7fdec90so447669wmq.5 for ; Thu, 27 May 2021 10:12:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=8Tj882GRDYNKA/Odur5I8qEQKwf2uVi6wQUPaTSmUGk=; b=DDKC/gx+GJxbvzCNThdrv/dILBRWxXTPUr/qNsKbINCBSo9Xw8IjO9NbO7YbimUNuW mdkRyMhnQSoABItJAQaD7wFXKtzCWl1wVNyE6FlCwPl9pSvGZlb0V0Al+Gm/CB3Ibtzx rrtJsK8AdMDndopXU4vfwMkTEh00nYPAvIu9p/hbaUm4Mnz+8lfKWvV6T4oAIDB5eAPz runLVssZT2IGpeZRqBUITNNEpKeEFbkEq5AU5a1SVdHaWSBMvOrSnboqVL2L1cEhT4Pj TUtzivFJjljw17pVJMwQtNEQEDVvEix6aDt9i+E3fcd/EA+FVNNq8JTbIZaYLSA2So2O SBlA== X-Gm-Message-State: AOAM531PKeLhL6CQI8dHcPkMZ7pGWGibW34pY8XJTPBe2ThS895GoNPR eG6O+I+MIOalfxxAaIsGm/7xtIUYBQbhpl87Qx5i8huyE6yKnvjh0ZaqP7imAytv182CTVGczJU OdB5MhX5ha58= X-Received: by 2002:a1c:3d05:: with SMTP id k5mr4669361wma.9.1622135532241; Thu, 27 May 2021 10:12:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzfH6a8f34/9c06VAR9VtQNYysw/6uRvDZUrv050Ei6nDvYjtR9kqnXZGaQdB/PD53PwEWPHA== X-Received: by 2002:a1c:3d05:: with SMTP id k5mr4669322wma.9.1622135531909; Thu, 27 May 2021 10:12:11 -0700 (PDT) Received: from [192.168.3.132] (p4ff230a8.dip0.t-ipconnect.de. [79.242.48.168]) by smtp.gmail.com with ESMTPSA id l8sm4338822wry.55.2021.05.27.10.12.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 10:12:11 -0700 (PDT) Subject: Re: Arm64 crash while reading memory sysfs To: Mike Rapoport , Qian Cai Cc: Andrew Morton , Catalin Marinas , Anshuman Khandual , Ard Biesheuvel , Linux Memory Management List , Will Deacon , Marc Zyngier , Linux Kernel Mailing List , Linux ARM References: From: David Hildenbrand Organization: Red Hat Message-ID: <3a5fa459-cd00-8a65-3ee1-debc51424a7c@redhat.com> Date: Thu, 27 May 2021 19:12:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HrCJpxEG; spf=none (imf15.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 518C7A0001D8 X-Stat-Signature: cppypun47i16n16m8edwy8446g7wokam X-HE-Tag: 1622135531-39293 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> [ 259.216661][ T1417] test_pages_in_a_zone: pfn 8000 is not valid >> [ 259.226547][ T1417] page:00000000f4aa8c5c is uninitialized and poisoned >> [ 259.226560][ T1417] page dumped because: VM_BUG_ON_PAGE(PagePoisoned(p)) > > Can you please try Anshuman's patch "arm64/mm: Drop HAVE_ARCH_PFN_VALID": > > https://lore.kernel.org/lkml/1621947349-25421-1-git-send-email-anshuman.khandual@arm.com > > It seems to me that the check for memblock_is_memory() in > arm64::pfn_valid() is what makes init_unavailable_range() to bail out for > section parts that are not actually populated and then we have > VM_BUG_ON_PAGE(PagePoisoned(p)) for these pages. > Oh, that makes sense to me. -- Thanks, David / dhildenb