From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A88ACC4345F for ; Mon, 22 Apr 2024 17:09:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D20A66B007B; Mon, 22 Apr 2024 13:09:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD0E66B0082; Mon, 22 Apr 2024 13:09:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBF3D6B0083; Mon, 22 Apr 2024 13:09:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9EC426B007B for ; Mon, 22 Apr 2024 13:09:52 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 19AD1A0C87 for ; Mon, 22 Apr 2024 17:09:52 +0000 (UTC) X-FDA: 82037805024.18.A611B50 Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf30.hostedemail.com (Postfix) with ESMTP id 7833E8001C for ; Mon, 22 Apr 2024 17:09:49 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=NxWiT9lo; spf=pass (imf30.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713805789; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uu1fQ5aDkJ7i8NXdfX4/kF4zNceh7SWgYxlEI7xiCJ0=; b=hLlx/HFR+lRs5IFOE6iilTjIy8PB4o/Gu5DM7m7UdG/F2jL8+UBxymenUEgpYN8w7Q7bOB 976ohFPPjlfUO618XVQ7O4OuAWnp7iB2htJ5YPhzqCkOSDbYzsQrSGZ3+U4VrTk1yQ7P7L xV29rzhxpVle9IyQDyWnMpyJwNSUDSE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713805789; a=rsa-sha256; cv=none; b=we7yF1m08+KNQ4DnWptfFOvlev8xtD0dbBURl8lt/K9wMohdKAzJDQQcpMHkh+27dQd3E3 zV9L6JllxY9N/H6URaT4+ShRoRCmIGBFRKqKEjJXhWqKAk8fSZpp/X6hFPSgFfg3K+LV4T hUASzNYxT4Slwo0xNUNC26pRBMahQIc= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=NxWiT9lo; spf=pass (imf30.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gentwo.org; s=default; t=1713805788; bh=JFrXiAuCRssshnI751GUQOAPaApYFYT+iqnCDATsYTQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=NxWiT9lo8aYBXWmWeAoqakFxROWvlFNl5fRsVFgPyPLvANIXgdr4KOWnZNSo0nbQa pOYhwfDN0BoN+kzXqUPdGlAzx3oGlVI8gj7KagI1B1pWxsKc2vwjN2DveL7Z4af+XT iYZjyeNLUosOMu8z3M9Xkt2DI8Jm1i1CCTZXRXwA= Received: by gentwo.org (Postfix, from userid 1003) id 4582E4021E; Mon, 22 Apr 2024 10:09:48 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 44BD840206; Mon, 22 Apr 2024 10:09:48 -0700 (PDT) Date: Mon, 22 Apr 2024 10:09:48 -0700 (PDT) From: "Christoph Lameter (Ampere)" To: Hyunmin Lee cc: linux-mm@kvack.org, Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: Re: [PATCH] mm/slub: create kmalloc 96 and 192 caches regardless cache size order In-Reply-To: <20240420062954.6816-1-hyunminlr@gmail.com> Message-ID: <3a5d2cf3-2823-8c5e-80b4-6e92000d7f4b@gentwo.org> References: <20240420062954.6816-1-hyunminlr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7833E8001C X-Stat-Signature: pd3yudy8msusyhkrq9t7y39r55jjmqcq X-HE-Tag: 1713805789-2403 X-HE-Meta: U2FsdGVkX1+WNjlAVn94jaDQ/yKtpHDpLW+3Ziphqn0txZNqR9/usfaeokbSJR/0o9WH4mlyrJhkBysEoQVCPxDWw7UfgbMDJ1hHIY3gMiAHZUjkeOpR4GIKoBVAaZ4X0VmOUo6OqL/v3bAS1OT0S3+XjWbtMxdHOCEC+2VZPY9jrukZowC1LFTALHlxYcx13x0IodnAMhGjtepc40mAf4TjPa2f7jbQNVaWnhe5E4qFHJFrgcyy/Mi6Jw/6tUqGR5g0A/eDq2Lu+uqxuQEZQHi+W9hDvDOkWMexftzvJqgXq4B2NxIl0NFuhWUsrQfVq+w8Zbn/GRthfkpMFaXg5uF61U43CSDekMIviMZBbVtHZb4bo+oF7ovCO9KEHUc54wOxvUuoOtV3lghFeRegVb6hkxLq54CeFTRfoyrs2hzWkZQhd00KVx3VtIlkKSY25FsfLS+EtDLGDiOTBLkM29HX5YomS8XNVq5NUOANIFb0CS/s7/a6tVg5c3nOfJji9dH157Dgk64cKALnRbYDQ5fYEoCDyPxNFnBobm5ovzEfCoRDOcpthPR/m8xMXgsM1YHXmd8QPC6iSA8ZvbUOVMnXAxW3o2o98L3o5Mq1F4AHQTNb15h1DMWWqrbEfVrF/AvLmzE28hb+nGAWvtwOL3arLrjqG9SUi6jxNqCa/6OJQklU0UYfXfXftw9m0HDWY68ZJAaX+xc/1u27b1qJmhJxFIBvC9fe7hodCw6WoWs3zV8JtLr0Mk2VUII3bZqcTjhvVshLZ2krpEZTS6/UWtNQG7wvCc2JVaTbFNVXLL88kVw5PIgSwDrzfhJaGPCWxVitXHO7GYs4l3euO4FtrAh4DfCFO8RMzZ8BfAYANmRVH8CVM+sII+yh4nUKoBeFa3UJh2R/0Li3DZBLnJ24+5p/LlY1P+FqbppgxPUyfsigTPdQfF7OfajLb8+hBnTCGdluDfFjgoliuTyjHzO 70qI1njP 74kP9lVp1tpmPtgRPCIqeoBM5nFh8oAOIXryKwTHu9aJsy1sIZYpzuk691Vgh7Prk3xfEqOO1csgYYoN+khD2robvm6nWxxo1u+D5NA11BjcT1nf4rzG9QeDTkhZtg954DN4vUqnOS6eQN46k6OYHmPwAl7DDsgMiGPEmfm4vIugx03eInbd9g2VUON5elEg1HsTwYUVlEBzo0pO0g3fDhrFukPuaQUo1GJucGpXnHuhMISA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 20 Apr 2024, Hyunmin Lee wrote: > For SLAB the kmalloc caches needed to be created in ascending sizes in > order. However, the constraint is not necessary anymore because SLAB has > been deprecated and SLUB doesn't need to comply with the constraint. Thus, > kmalloc 96 and 192 caches can be created after the other size kmalloc > caches are created instead of checking every time to find their order to > be created. Also, this change could prevent engineers from being confused > by the deprecated constraint. Ok but you are creating index 1 2 after going through KMALLOC_SHIFT_LOW to KMALLOC_SHIFT_HIGH. 1 and 2 should come before the loop in order to make it easily readable. At that point you can also skip the check for the kmalloc caches already being present I think.