From: "Christoph Lameter (Ampere)" <cl@gentwo.org>
To: Hyunmin Lee <hyunminlr@gmail.com>
Cc: linux-mm@kvack.org, Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>
Subject: Re: [PATCH] mm/slub: create kmalloc 96 and 192 caches regardless cache size order
Date: Mon, 22 Apr 2024 10:09:48 -0700 (PDT) [thread overview]
Message-ID: <3a5d2cf3-2823-8c5e-80b4-6e92000d7f4b@gentwo.org> (raw)
In-Reply-To: <20240420062954.6816-1-hyunminlr@gmail.com>
On Sat, 20 Apr 2024, Hyunmin Lee wrote:
> For SLAB the kmalloc caches needed to be created in ascending sizes in
> order. However, the constraint is not necessary anymore because SLAB has
> been deprecated and SLUB doesn't need to comply with the constraint. Thus,
> kmalloc 96 and 192 caches can be created after the other size kmalloc
> caches are created instead of checking every time to find their order to
> be created. Also, this change could prevent engineers from being confused
> by the deprecated constraint.
Ok but you are creating index 1 2 after going through KMALLOC_SHIFT_LOW
to KMALLOC_SHIFT_HIGH. 1 and 2 should come before the loop in
order to make it easily readable.
At that point you can also skip the check for the kmalloc caches already
being present I think.
prev parent reply other threads:[~2024-04-22 17:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 6:29 Hyunmin Lee
2024-04-22 0:28 ` David Rientjes
2024-04-22 17:09 ` Christoph Lameter (Ampere) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a5d2cf3-2823-8c5e-80b4-6e92000d7f4b@gentwo.org \
--to=cl@gentwo.org \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hyunminlr@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox