From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5278E77197 for ; Tue, 7 Jan 2025 08:48:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D9016B00A4; Tue, 7 Jan 2025 03:48:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 18B3D6B00A8; Tue, 7 Jan 2025 03:48:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF7466B00AA; Tue, 7 Jan 2025 03:48:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CEEBF6B00A4 for ; Tue, 7 Jan 2025 03:48:26 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 70B671A0581 for ; Tue, 7 Jan 2025 08:48:26 +0000 (UTC) X-FDA: 82980029412.16.5913FBC Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf29.hostedemail.com (Postfix) with ESMTP id 3A931120005 for ; Tue, 7 Jan 2025 08:48:23 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=ThByKpEZ; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Qxd8FH66; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf29.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1736239703; a=rsa-sha256; cv=pass; b=R164Vryf8BZdsnFeJnVdiiz+jrSCl1hkt7X+RfoXOmxPaPwZg8ene0iUghyXQCGyVqHYjp WpgDyLf5HmznN55S8oLwRyiRGqJIPOAQ7Mxj5alFLVi/I13YUKXCBys0medUUBDoOBc88M Awf4cpbc91JqecPjp4S/djePqAa6fkM= ARC-Authentication-Results: i=2; imf29.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=ThByKpEZ; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Qxd8FH66; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf29.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736239703; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PF49lxglnngKKkMx84jfjS9VvC0Norf0MkKdZkyD5ro=; b=P5hit9XVO66hJCSbzAuHvWh1WAkga0X8IMcElL/tJl2Tp2W+pZ2+51tNAu/DOD1W9hSWGI Z302ARuFVCa+ap2W9T+D5qASQq/JzcJQM77Ui5uZgUk1ctGQOch5udOt6Ddo3Ha5PHuh5E LpC3vXbLBoKi22earUMfWi1wCpCm/8E= Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5072u1pC001043; Tue, 7 Jan 2025 08:48:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=PF49lxglnngKKkMx84 jfjS9VvC0Norf0MkKdZkyD5ro=; b=ThByKpEZadGpWcVBXY3QPP7MxbjbntLi3b MubXvdu0nngazKE+SoeJlkD1v0qpqxdVoxfECXYJ+wtMqaNgHCiIomCN4laS2Apd xz0dCxdevnweaMGZ5TyaFqUfOTlvuN/SmPmX9Fh7LpjJaj92L22/FWO1C0P3dGQw nL6KQiaL5g84UXedbiam8KxE2n1h9400ycUHcutuXTQrG0axRTjcB0PXA/Oj0bLg qe8CNru4x5OcnENX7mqk+BHyVbqjK/oBVcDIlEZpVLSwTRaaLnq/Y4PPTbwThtIL eg5xn9suuW0rdgEJjgwRAoT10WVIuUsO3Gb8bN+OcUnYryUQ6C1Q== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 43xudc4b61-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 Jan 2025 08:48:14 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5078CBaN020955; Tue, 7 Jan 2025 08:48:13 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2177.outbound.protection.outlook.com [104.47.73.177]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 43xue88asg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 Jan 2025 08:48:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gZCpqTqIZWaOqZduPevHqXU1Kj7MHcr0+lzd7Yy1OH/HucyDr6sQDegWawmX2XFzWV89h8Z7z11WfgKx9lbavxp2o35PihzKcSN+HThCxGXRLYo3PLqZELVgHiJvcsKKpfCAfhWP9ZuPHJRk3vdpjuDQz0WSSxn2wDqC59rxlyU3EfdiMpfGcby2fabKspe9DZygKnaAMehOL3gDusTcvnj6gCrisqMY7nhPC+htn7ZVkVFPPbSuWZSgRssZ+Kw0fU0qDj1k/Cf9evkK4/SjbrXIQABClsqvryn38HOFrwr6GYN0g3ztpiqnvx5ugmQxSCGxVdKadOqwftlPw6Lh7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PF49lxglnngKKkMx84jfjS9VvC0Norf0MkKdZkyD5ro=; b=XGCc/54wybyqD0D8FyCj8N03FkyWhS7FMyiEAh8Tp3T9gdOUT/P5YeUF56hwV+22MsY/gqPPdMB+6uoZPDzNXDZvrNZCNXpJVSndP7PjfhdYhyh+83YQ6zTE8eR71P7s5Lmt9vA4HJn5E5F4uAJVNJQW0IXza8+UhocVFKAqXqKUF0dlWzT44fsv3wGOpYASZLcONAYdyYNf24gr2aJgxQd4NanVD+tFekWOVP4VGmDZjeKplNgCi08sRoFV8JSa8otkymyvF4rwj5diChA3jHye0kswc+geAjRjcqH5EP1sTdZ7T12Bl3CzYlNPLfZWiW1KC/Uf0/NJciIJWDz4YA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PF49lxglnngKKkMx84jfjS9VvC0Norf0MkKdZkyD5ro=; b=Qxd8FH66Ao6xHJtw+HykdohcMFqz7QufMdrDd4Jd04vB3F4f7JfJahWblOD5IbTbZc0osrV8HVYc3CVMrXbERtbRHMv4N1fLgtw3H01p3517OHk7JQPcAcYrTIUax+vVCBpl7LDwUD8nx+aV3GMFZbfWk+uaJSEAIKLYURwjMMI= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by DS0PR10MB7127.namprd10.prod.outlook.com (2603:10b6:8:df::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.17; Tue, 7 Jan 2025 08:48:02 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%4]) with mapi id 15.20.8314.015; Tue, 7 Jan 2025 08:48:01 +0000 Date: Tue, 7 Jan 2025 08:47:55 +0000 From: Lorenzo Stoakes To: Huacai Chen Cc: Huacai Chen , Andrew Morton , linux-mm@kvack.org, Koichiro Den , Sebastian Andrzej Siewior , Mark Rutland , Charalampos Mitrodimas Subject: Re: [PATCH] Simple fix Message-ID: <3a5ad843-6d00-4e8c-9f77-f53282cef4b3@lucifer.local> References: <7gd4skn6l4i3liu6cvzmgqlrwxc3rukrnau7lnpyhmfyjuvqwl@gdwgybedp5gs> <20250107011848.689556-1-chenhuacai@loongson.cn> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250107011848.689556-1-chenhuacai@loongson.cn> X-ClientProxiedBy: LO4P265CA0142.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c4::16) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|DS0PR10MB7127:EE_ X-MS-Office365-Filtering-Correlation-Id: 73f3632f-8e71-4deb-2124-08dd2ef7fe3f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?4z8eMJrfT5mGhRpI9b7JbFWtzkScudf9f/E8e/22PlzVs3SEE+CliUUowPpi?= =?us-ascii?Q?vofKxAjvhn9uYqQhJBFAuT9zliIYXF/vEEE/O4SF2IlsXdNijhy7YRseUOBJ?= =?us-ascii?Q?nTO9krfiw8LlgnKBrDVGU7TCr9AqD2SmAne/KQkqucOIq1JSA8Lp+BqeWfSG?= =?us-ascii?Q?fmq9xk80TIUpXTdumE6FmJA0Tr+5yOQJiSXv2MMNVnWdR5QASr2T/zb3h5Xc?= =?us-ascii?Q?MWS4cnfoCZF/OANhCRmnMzSd2hTnf5tNMlAJQ8dmfDQdwKD5X07nGHam6qZh?= =?us-ascii?Q?YiqFtoST8YojIDjlZU21iR55CR2zPzC52pM73z1TOyJTJDUfHfRHMMizWGvn?= =?us-ascii?Q?cncVYK0vNBudYoCC6jhJ6Z0yi1XWxB5gXMStXwTIwmGP3L/9Vy/Wt0ntv0WX?= =?us-ascii?Q?BxbA81lOwzPHMtkU6AZrTBzLU1CWsAIfw2Jsud1MNEYYz6n4fMopN26RM+vs?= =?us-ascii?Q?wEZkaDgk4EWKe8TCl81WacY0kMuFm5Nyi3ntv1XWf7nnQpzx1oolhgVeRMl0?= =?us-ascii?Q?fPhFjdlOWXadisfCuDMVLmP4FmebtDIHmSKarNxDlhL9YG54QCKLNRSSdpFH?= =?us-ascii?Q?f60VLqe7FuJmMkD1VYn8uLBuHGktbNfAJObwHm3rDwAqMXjjcUO+f0gWhPlu?= =?us-ascii?Q?Fa1/OopChoDGu6g8rcYv+wk3HKNhP33UcRZUlqK/9hWWKhS0cuYe0fOEqXNm?= =?us-ascii?Q?2ZdZhfNEda34JnSPmIoyuKm5qa+0Xtn19jVKHgFOQ7Hip5x1qqbgAUebjqOs?= =?us-ascii?Q?BrEtmfQxxaothHKGNyg7fVcJKkOTn0HlSteRgKyCQkN3GSwJr3qz7ppCkQOv?= =?us-ascii?Q?Zgr16XIFjF4kyTbv7qAho3uumXyBz/8eW/ysxg+VgHQZEmm+Nv4upnVyoHtl?= =?us-ascii?Q?6K1zzPVyy44EfCcb/DVa8Uf00rfatx+Pg6nccSmol5NxJKbokiPjOkXyJjPM?= =?us-ascii?Q?RIsLcUHM4hcdbQEQk47mI7fquy0IIyLa7+q6tqysmrMQNbHI1kK6fk8dKkUW?= =?us-ascii?Q?yGdzcKZ4oIcpQm268vKLGOoU5nXSK89bjKa7kavRccGN2D8rxDZ0v5Xm1KpG?= =?us-ascii?Q?GdADA4D5kJFQfuEZ+fEKrjxYqvlulRQfipY/BHk8kPeLxxQeI9IV2aDkjp1b?= =?us-ascii?Q?hSC8LsyPWUg20/QddhWSKeHSrKRvxeV2KqXChCBq+/FK2oZ9JlvBQgWIX51t?= =?us-ascii?Q?UCImg9r6po7/6PAhkPGDivX2aCV9+4fVk4W7VbfvIIbL1Eo91IQIkx4fK9iP?= =?us-ascii?Q?f2m4kBUOZ750FQjFTaCLOlVKiNefhLYyDuZRxc/6C+jZwXiTaSogjWKWd6xy?= =?us-ascii?Q?PHyEPXwSxWi9egjAOn7wp4ggXammM87LZfDVw6FibjzeTgyBffnWQHj5PBLT?= =?us-ascii?Q?YiVU5KIjA2S+G6Jg3nzzwuyyCE5a?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?u90G/ljw5AiKrgFZPvmJR6/49C7HYY6B8PRe3HbNmOs8zRTrA4myT7bBtzRo?= =?us-ascii?Q?uiNqpxnP0Yd0rIO1+oOyF2Xy2IiIAKvTM+1GQCop5B7n6FP/TMfXNbYNgOrK?= =?us-ascii?Q?dl6i51DQCpU9OkPIS9j3nPvbSxSKD2r2ZTqdVxunx3KnQ2K0zh6Tux5m1Wu9?= =?us-ascii?Q?20qSUtxiviCVJyHPIKxpZE3iR03Fj4lChXOXWto2GjH5dZmsFVuvwqd/2mnv?= =?us-ascii?Q?ngxgyvADfzjJ0j5qZ2znsdWtg0EFg9mfl0S3RTTmVriAq3c7BOkQsGFObuXI?= =?us-ascii?Q?hCot08NBK+H/45gqFI2ydEoAhJSc7K+wgLc/BzjU6W4IakmtoMG9fcAisyLG?= =?us-ascii?Q?fhMHJMT0BwDQSRlRFAHi3QGQqei3fSfPhvcuO0BbHP9h7S21UjntJQ1udS6T?= =?us-ascii?Q?zd8RpdrOROKS0f9PRRNao1P6pTE03K/ArxURF+psEaBEtVUy1feDq6RIXCeV?= =?us-ascii?Q?vC/ni2fU6vk4oQMCD9yfJ24ixMARys2hEqHZkfTKr81VMvKGhzTN+yRIRVxW?= =?us-ascii?Q?Af7zWckIdGgqiqsQX2olIKok4DaCKuTy2F21fp67nqexoPzAtPdNSeX6k32Z?= =?us-ascii?Q?D1oz/eSiSpJ7/3Lg6s7vfFyvqCk3Dz9AxWELKYDle9RddjkdIWpe3jySocN3?= =?us-ascii?Q?aQR6PV/+AlpL4y8FX2txzLnH3VH/i+NSFnoNvpXLVSNNm5Rswjy7P9tiHA9a?= =?us-ascii?Q?mPRG/6XS8SdlqWb9SSQzld528vznpzCVzJTZrnu8H2YCJ1ePQjqdQwq6LYkY?= =?us-ascii?Q?dOUTq6kQmYQ8Gj9Z2FhByTkTwKoPbEVQJjNBbTug5XPdEHHKgvENxIRkQbHI?= =?us-ascii?Q?dgFdlf57pVoJHJ0seNoWnp03opXj/+qDuPSQz6lz0Pj/XR5RQpAjlSJqmnOz?= =?us-ascii?Q?fB/VOdbzy3PFqlgyERio+BX7MWwe6/jjbl3GDpmX+KcxetD3AffIckT96ltN?= =?us-ascii?Q?4CA7zrWYvXFGQ8apgkXZPCpOINUiwNhduT7ROeymZU4NBt6e/IiLcGFvhiT0?= =?us-ascii?Q?7Ta0PZ4b8GpL/Kb9sJqVIfiKl9q1Ovxq4guLD05qH51IOovnD6J1GulVR0Yw?= =?us-ascii?Q?fFSX6uCG+HwCsrFg/RY8FD9alvw/YWeJpGFX0SqEPqCvNuZjvKRzCw3ifakg?= =?us-ascii?Q?aIikXt2dNn4+bMxOFPHd5LPhQ4lnLELfjb+fQ3dBVBDAl2ctA9zS44UN/e2E?= =?us-ascii?Q?U+dMpdQak07qvTVi12EFhowa6SBwNOmKsINsHkZEeYxP4ZtlsPKsA97ZYSmz?= =?us-ascii?Q?pdThP4fJwLGkMe/6mKUFdJikt/5B+wsEWGDPC+9XWGeLYec9Is1508VcooC+?= =?us-ascii?Q?aWWAj5mxbOmQo7jpBZoKDqaRG6aZUyJH/lS6pgdzFOUMlPoM8+qsgLsLJbGj?= =?us-ascii?Q?FP3MiPJPsOEHClhaBCrBqJrVLTxsZiZtwJftqYbjMbMGdHYs/Ys8RJGWRfEd?= =?us-ascii?Q?JxZXvbUyFnPGcnaWjHg4BUGJT2NPB8pdP0QXBXpImlKZqHnVzRVe/8G3Hh/a?= =?us-ascii?Q?bkOpFu77HUMoAnOkMCKjiT6kcoL5IWdwpBfzAH47SnB1+RP1MERfYwM6Jzjc?= =?us-ascii?Q?uVj2Tkx4BG2pcL2TXVqEB1Ouc8C+UobmJ/fE0oPcBkldvnipcOmpudlIiDX1?= =?us-ascii?Q?qQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: yw0xNKS9DkAcucCOYbjUH4r8xlz0JaFz5mwxyktKyweh8MkMPyON86CRHCGNyeByoutFMD3bAo5N0SHxxonabNGGx3hhKruR93xunTEL70wTOoUIOCBON6xuFuqLinULCuALi+48D8tMN5ywby4OPIBGbDK2O+h9qn0ImJ0pe/vaKjNm96d5ebdFzmxxSJfDFkkF9gjyN7kKYevkSmwxz0/BBLd/kwYSaVPamaMCnrGl4C9bGwOq28zNF8gLEoKqXBE849dtPJCbP4T2qXx/yDouEcZOq+jgYzhozS68TT9c/ZcMe6OyGMcbltZZ3eTgxIuQ+3vw/cpVpYhgYQZD/hiWcxy9ePSDKYlbp9xAIGw1ds9DN6YGxx47BWTyGLFO4RPdQu9vFPD5cqiTktBuLqdIzsbkBu24egS+D313svm8nR3PxX9qgxR4zCaumq60wgfRDF8nn7VvdDsjTXt5SlYy2XhG2fJ7cgEXJmHaNsjqEcfFMznvAtVkOZfkTdx7Ruc57gToNkwT8rDhRz0f368P/kbri6f0gZfk7my7WlCk1NFq5nDzS3RuirDroduSW3t5AqLkb+h1UP9HCAYYz0Vhw7gXuAjBcPB19LfxVSs= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73f3632f-8e71-4deb-2124-08dd2ef7fe3f X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2025 08:48:01.5705 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SJVus1grOfy9oDw3ZUwjZRFeRvpQpZWmxdXL1yOcuojUrQa/VkBVZ+GQgq4qM8/XdcLHDej3D0Ts91k3M9kEYvWTbpx65L7uz2xJ2FOcyZY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7127 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-02_03,2025-01-06_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0 malwarescore=0 mlxscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501070073 X-Proofpoint-ORIG-GUID: uNRHcH4AtOt1brs7iSERVEgxJL3oavko X-Proofpoint-GUID: uNRHcH4AtOt1brs7iSERVEgxJL3oavko X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3A931120005 X-Stat-Signature: 4f696g7dc4saio7qc3u3st87rtm1rg79 X-HE-Tag: 1736239703-584128 X-HE-Meta: U2FsdGVkX1/3sr4rT+6FerIxnQ5n48ipu0LlOx19PX9R9gyhJflFK0QLVPRIr3dXeoL++hWO4KzipJTuGkWpj4SbBMteaY7L4QRncpC6LweuhUjeQGWEEKthebYDfAvH2ahzBIIuAoLIZ07N6DoW2+Jn1uhdfN9GpiSi7IV7x5YETmFbfsHy5JNP1jPHsBEhP4FUe6ykLA7UDQed3MQcI+uLXqFWayGUQPixSQAA9pyvtGLYZMoMr3tIv7qfoP5tui+J0tLP8H5vbH5yVJ6L/Jra6no3cQt3Ddb9ssDviLPzTWYyIzHlYaFsaRd7DAGwM4esw1iYZGlZDo5NSKaiCTJ9eftgGMwu7Xxq9RgVfxn4QaPINGfwPW2kvHpDI8aalIUq6CSVxMl++phOmVRM7OMky1NjfEN+PwZS7MBWIzypmYOn1KyVN7K+VV/TrAMWHZaX/dBTVUs5JPKhzT9kd+T9GmTDhTo3lzBeF0s4Ur3eCP2ANLrTJBUIyLMMUdQB5XCQS06mTkR3BapHkxAsahQV7F4r3m32aX2R/v9Ff6a8TOWIT6l+GTtd6USVelyF8VkXQpCUyg+GMk3e/L4I47nolldoRZrtYaEv2MiGh4TTlQEhJqCC9DtEP4TziAvDWboiW8WGBISlh7xfCqWE4CTfTm1owJDMkPPbNbd56IHfMcNyiVJe7XgUL4fya7ilicQ2WNL8Te7ruqva2N7u7Rzw7+AVB2ODo2OFymzRLBxXS7O6u4Um1dL68t7qygdljaV5f4CmLg6yQUIqmuNw3qk/mosGlEdbt/fdSedn2uIEGKJj3cHoeWRMLbWro8zjrjK9GTEGEhATE7nhkMFdq7KL6Sl02MAO6DHbutmTHWaQ2pp4Hb3h4svBOLdi9S9XKm9zQuGjvEQd2lK1eKNKcOryIrgruMEeyrvFdfTsmQ2ZENamqKZpTmhbRot9lBtXxLb5DlgZXfA34EFWLee o0f3rpka AiseBBbq3pZfnMcjyMCV9JwQrXQyAtWUfUcg7IJR5nyXiLfyUxdMePO+oT0pbcpHaqGDQGLTyl55h95WZxlmDGAwme3FUY8lEGe2hFSe36UqKyJKHhMQU4ZByK//HewvtdX3e6HmyRvVMymgjVMLQzrrIVbHM1fEzxCea7HzWcsEvy2ussXf8m82oyUfPJhKOV7alxwHIoGaRG9v0gxcwvh0b05CYOd+5rD7KVRMNe80H2GseTffYB3hzlVTC/DFW1eit3X2XJfFR/KCrYJEjQ5RqmVR8YAgUotFOuwjzOs918/8Ob94Xdp9IdzPYT7LH0AkwYXtLfSVOLO0jYfgIcH3pWq3OG8dFFfIMstnAg8c7Kj3jQXV4uoJ0TOC2wLTFeEu8HgPCDsabh52ozRUHVw6uMCNyY7spRpDcSKdZD/K9++qqKtVcBK9KYejp7ygYuRYVkKXmXGMgpBVI9LM5pUsDgK8DUTZhBz1OcXV2g1S63AL90gJBQgsZNqGJYKOwkuJYwx2hpqOUrz+l46pTJaMZcUkij9mLcA+m X-Bogosity: Ham, tests=bogofilter, spamicity=0.004821, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 07, 2025 at 09:18:48AM +0800, Huacai Chen wrote: > Hi, all, I like simple fixes, so is this acceptable (based on an early > version from Koichiro Den)? No not at all. This is bizarre - in the mail you are replying to Koichiro agrees with me that the approach of his code that you've sent here (I don't know why) is fundamentally broken and suggest another. I am at a loss as to why you've sent this? Perhaps a miscommunication somewhere? :) In any case, please don't send '[PATCH] xxx' mails that aren't intended to be patches, a better form of this would be to say 'oh can we just do...' then to put this code in the mail underneath, without any '[PATCH]' prefix. But please do review the discussion - the below is insufficient as simple as it is (sadly) because the boot CPU's delayed work will never be executed. I will take a look at Koichiro's new approach as soon as I am able. Cheers! > --- > mm/vmstat.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 0889b75cef14..1badc24a21ff 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -2122,10 +2122,15 @@ static void __init start_shepherd_timer(void) > { > int cpu; > > - for_each_possible_cpu(cpu) > + for_each_possible_cpu(cpu) { > INIT_DEFERRABLE_WORK(per_cpu_ptr(&vmstat_work, cpu), > vmstat_update); > > + /* Will be enabled on vmstat_cpu_online() */ > + if (!cpu_online(cpu)) > + disable_delayed_work_sync(&per_cpu(vmstat_work, cpu)); > + } > + > schedule_delayed_work(&shepherd, > round_jiffies_relative(sysctl_stat_interval)); > } > -- > 2.43.5 >