From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91578C021A4 for ; Thu, 13 Feb 2025 06:37:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15D126B007B; Thu, 13 Feb 2025 01:37:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 10D9B280001; Thu, 13 Feb 2025 01:37:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F16F46B008A; Thu, 13 Feb 2025 01:37:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D39B06B007B for ; Thu, 13 Feb 2025 01:37:50 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 775F3160667 for ; Thu, 13 Feb 2025 06:37:50 +0000 (UTC) X-FDA: 83113965900.24.CDFDE68 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf24.hostedemail.com (Postfix) with ESMTP id C7079180007 for ; Thu, 13 Feb 2025 06:37:48 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf24.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739428668; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LSpeGfgC7pYptQQDUDvPNJZqEbzKC18YJD1dB9yctpE=; b=hmm73hCHgVvNx2iN3rCDnGs2/jjSDrFCa9YFdxxPLnvBy/3V+NY+zTo9p59RLfrHpl+6Oe ujQFme6cRF0a+jdca3tqr1EZAlRAlV64DcexxxnXW1xnyCLD6R+ZEfaUe/tI8Q9dVzklpL Hkai4LJczoAApb3DhqPifckEGlUo9Iw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf24.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739428668; a=rsa-sha256; cv=none; b=XTXUhY4cJOPBw0VKD5vhWbgpqfw0O7tOtyDO1yqA6+BKoIzhAh26FiriYdbSWlfMnn3s5+ wbIAw/JmZ3opRl+E6iRbENETFG63IwCUsagJQhiqOp3qMsUzQ5M6rYf30M0cdLkiJGopWl Jo/6nKbxZ2h4Mxg0iM6AigDIgTCJxtE= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ED9531756; Wed, 12 Feb 2025 22:38:08 -0800 (PST) Received: from [10.162.16.135] (a077893.blr.arm.com [10.162.16.135]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DA8D13F6A8; Wed, 12 Feb 2025 22:37:46 -0800 (PST) Message-ID: <3a2b1431-9b66-4256-888a-b7f0fd3a3df2@arm.com> Date: Thu, 13 Feb 2025 12:07:44 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/mm_init.c: use round_up() to align movable range To: Wei Yang , rppt@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org References: <20250207100453.9989-1-richard.weiyang@gmail.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20250207100453.9989-1-richard.weiyang@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: C7079180007 X-Stat-Signature: 73pwjasgfgsycrwk4akj1en3xq9rdcbg X-HE-Tag: 1739428668-879730 X-HE-Meta: U2FsdGVkX1/tuIOkTCOWsiIOZwo6JOS1Yp5OdFp/QPMlo1rJ4ZosTHONJFGu1d0UBb3dlEgjy2X9FMpvzSxnwYm4zoOxfkJIBUFtmv3594q0mt38XTzfsZThjKTovRniK4lW6PA1Y7VO7Hb4RJ2lNPdNUn8rj+J//mxUaUw7jVV/DA2BBdZlxRO7CGBeu/DNeCLZR6pxR1SYUTmorZ99nqwlqQCVHpuELRdbW97fMrJLdxGZxAdd1CNxT0tiG6MTPVsv+ucyhKE6MmXnmeoOh2ejwCZp4Z/WNzErwyVOQz+6U0s0csbLEMjwDCjmM65AV9zlItLzq2RldsCtJmbVp9shLa3mEvDeKzJx+aouyIFHkc+wunDP41jSRRZusb6SQopLx7l8bVePj3v/iaKZrpzSJMXRbI4w2KvD+z2o0S8SQlNK2veKJSlivvzi/IJbCAyBGOjEYqR2Uz/mQIg0nMLdISd9Q0kvXPuB3yEykgFXnnxntAEslGWrOS1BtyL3P7rdZmZta0Ppw84Hn5pZUSY4jjtlScNa5/itVKYMDJwPMZGI/zni04Pj+NiCE5pRuhNZmLG2+vJvfnoS/0vp/nrgSh5iFm2Uhl46VhbRL5LtUefYeCMEsurRjcwXjAbYzQrT6cJUP1YrUIj5RrpsP1HJpar7l+0rABogXIx9WN78d5zk6Q0ubKRLL3HwEBfCu5X+8x9vvY5KCJMbBhtpyrPTEh+lgst358fGiApBkmsTg+cxFePjub8BMhBlYDasdM0zKDWzJyrCHbwVo0L8hrHSK7ko8i17A2dMUrRx79U3/j0pK9Iy2O3AUZHUkflIRSQJ0pUVRwhrPm11WdDEDD7oILmJynT6Y4baGsdGn+YXxGdIzoGxL4nhlc91Qrw2lUz1vGL+al0Mn8fOHrylxFIpIV4FyH+y3pxG98t8U1F47dYMf/3IzC8snOG5Dz6p9Lx8dUT/1zyG3q3Tzn5 HZLKB27K IDqRIp+UcC9S9MTdbveDHgrBuUotKgath67qHauILmW7MLq7mYibLKSYZFXQ/g2hwFo3zoUSZq1JdXerUubuyLTkceApTiIK/zSTl7MPBclEQdoDHImija85kZIPbsHpJXHZnSX8cKC1rLmV0Bq2ci3ci0Ksw+Tx/mtT9/jzcWXs8TpXIfFDI6eXHw71mdOw9j3MIR1L1z3sU1tYvOFPnMm6nlVD4yrWvmcJiE1w8I/+Rv6ioUEQu0OPzsRqyUfCNjXp1t1xk2V58gGYwqTog6ijbgNT1Bj7dua0/lRnJBXtZAmVz7XANUpowQC0kOohWkmsHoDCo6Pe/dGU6iJcO6Sn1Wg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/7/25 15:34, Wei Yang wrote: > Since MAX_ORDER_NR_PAGES is power of 2, let's use a faster version. > > Signed-off-by: Wei Yang > --- > mm/mm_init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index dec4084fe15a..99ef70a8b63c 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -438,7 +438,7 @@ static void __init find_zone_movable_pfns_for_nodes(void) > * was requested by the user > */ > required_movablecore = > - roundup(required_movablecore, MAX_ORDER_NR_PAGES); > + round_up(required_movablecore, MAX_ORDER_NR_PAGES); > required_movablecore = min(totalpages, required_movablecore); > corepages = totalpages - required_movablecore; > > @@ -549,7 +549,7 @@ static void __init find_zone_movable_pfns_for_nodes(void) > unsigned long start_pfn, end_pfn; > > zone_movable_pfn[nid] = > - roundup(zone_movable_pfn[nid], MAX_ORDER_NR_PAGES); > + round_up(zone_movable_pfn[nid], MAX_ORDER_NR_PAGES); > > get_pfn_range_for_nid(nid, &start_pfn, &end_pfn); > if (zone_movable_pfn[nid] >= end_pfn) Reviewed-by: Anshuman Khandual