From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B12AAC77B62 for ; Wed, 29 Mar 2023 23:49:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27C536B0078; Wed, 29 Mar 2023 19:49:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22A7D6B007D; Wed, 29 Mar 2023 19:49:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A4C26B007E; Wed, 29 Mar 2023 19:49:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EB8636B0078 for ; Wed, 29 Mar 2023 19:49:39 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AFCC01A08D2 for ; Wed, 29 Mar 2023 23:49:39 +0000 (UTC) X-FDA: 80623580478.29.8825553 Received: from esa6.hgst.iphmx.com (esa6.hgst.iphmx.com [216.71.154.45]) by imf16.hostedemail.com (Postfix) with ESMTP id 43C27180004 for ; Wed, 29 Mar 2023 23:49:37 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=dbIZDTIe; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b="eaHQO/5Y"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com; spf=pass (imf16.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.154.45 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680133777; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RIP7ZToVJ7YAQYVab9ZPXk+46JeGgPwccShxfEnezxo=; b=PAahiMF7VW1w38+eNSJbTKMbtB/t4WX0NZqr4/vx0hwqZYpjYME7/qzhLe/xdthFxdpMEO iRnARNKo1JyUYM/SEz37gpE7h6nd7N+293oBwiGdppxSkgj+XXFHjCRUf9l7DuHDTvK4TP AnddXTukYP50MJWYxKPSMGeiWJqwmbE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=dbIZDTIe; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b="eaHQO/5Y"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com; spf=pass (imf16.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.154.45 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680133777; a=rsa-sha256; cv=none; b=uFPyFioSEoIdsE1GRsXvXedKHWC3sc0Ol//5E6Q3SJy3gx6NUT96WydJuS3SEDaGJL5T/1 MGtKxcm92/8QN3zJ7PukwMKsB7xAYMHNGNbSd2Rab149knm/5wtcEPAQTZ1+Y7MMsO3pzc v5GNv+ogisSdFBZ2UODQLPDJPR5yOeg= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680133777; x=1711669777; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=sWeg/sDXtlTL83A5IYwbAyKHpDQ9ojOEouG2K7X3x6k=; b=dbIZDTIeEj/t1MefBdT8PHsFN6Sshvo8m5hgfTN/Z917j0Wyf0Z50Zq9 Kbu9Z3eAqsAGjys5xSOCib6kZtm4ckZXO6dl4zqGovANurD8CPMZPHAuB lpQAzAezBVpz8rnIeoZmAksPiWmN9nvXNPupu1HXz2Jv9bw3+NZVph7ON Al0QsVQBwYIVRm+cDC/G+DSK+eAndwonlp/IimyVAvYzytSj+OyqcWXtX tlCu40h6EixmDzCKnVYjj8A9RlflpI52uWCeT8l2zj4T8v3l1Za9jiDx5 KmEXZdL5P6Pn9o00IRbHbzD+kczV0oy0+TDm+neIbKU/K433Adh64g+jM g==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="226829279" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:49:36 +0800 IronPort-SDR: mbKqPoaDxMaHAkpc1ukuvIY5BBg3oPy3MmMOXMm6LJbcrRMlneJrVEUc6iJ4m98N8rUcjZbeI4 GENpHE6j0E1ix1/ngmheCAoi4U4YHc86tQOoyMXwUAwDE0TSKa9dl+1K2ttVlfYTPc/gZ7ksZV BCPaaoz4YhD4nI5ny2MyoELR9rv8VdrEpspQ3cCFbvYxGPJK+JZs0B9hkvF+GgEPPKekjgL7xE zSRCF1GuZQPhLTfessZhZdChKftt0Y9v7dIO9OE2TesudZp/5OByXQqdB2VVgZoa3eSgoPYWKf CIs= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:00:04 -0700 IronPort-SDR: Wjjrc+FOZfse0l1+Rdg5wiF83QPsjwUTkO0pTbQOdmNUue9wJhSW5PpznaqyXbpCIJAExDRN06 e9OopsOKGHEXfBEZNET3uOstvOX+QCGOtKXS3UA5YAtrPgZ9nSkrYn3awcJrDx7nfb/SSBlDyw LQcfC1eQPtCsLd13IaEv5Rb71WB56nJSDGA2Y/jov0Yuf4krYC6m4c+VsTwiVZV2ql4XwF47lK g4U+4zBVenZ3b0Dg/DlpVtcvVpCo8yGP7EwnyaTn2PiHA7VlsoHVwZQ3k9uWdw9n0SUdQWSGG6 LDc= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:49:36 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn3Dv4wnFz1RtW1 for ; Wed, 29 Mar 2023 16:49:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680133774; x=1682725775; bh=sWeg/sDXtlTL83A5IYwbAyKHpDQ9ojOEouG 2K7X3x6k=; b=eaHQO/5YdYiXFsYm/m2wbzwCkEugBw14d0oKzXplSjZHTHWaRMM Rk0oZrO1z2yUn1Hja/n7bNucPqxcM0Cs6MfA2oa5h6VvS/F+VwOLHewkiZbvidXq gDXx1HIvRbO67fIYxbiBlENDBGzrGfFDypIQ83l3S9bnFvOFbwL3JmPEG4sD2OTO 76DtyQ7WNA/kwrwtHL3kwg8jBFayqspuA7w9tm1p7sbrrGBUG1jymW1uO8NTGsZw 4ntmN9Q3t7uWNfK3ZSSPuOWo7F29Q7SKKF1YRQBAS+5Jpz6sJVj7x+cnUiM+9wnB fQ+/Rw2jrr+amC1EN1ET3pZO7+qaPVJ+Smg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Zj5y6aSw4uFY for ; Wed, 29 Mar 2023 16:49:34 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn3Dq22DKz1RtVm; Wed, 29 Mar 2023 16:49:31 -0700 (PDT) Message-ID: <3a0f0c92-63cb-3624-c2fe-049a76d1a64a@opensource.wdc.com> Date: Thu, 30 Mar 2023 08:49:30 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 18/19] dm-crypt: check if adding pages to clone bio fails Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 43C27180004 X-Stat-Signature: 8cteghz6z5ddjkfy6od3bfxtreuoe5zt X-HE-Tag: 1680133777-95637 X-HE-Meta: U2FsdGVkX1/4o/6UJQNfsr6AUjWVvEkTHQ0NiWRAAIjmoEFCkmdywXZFsmovRgOQRxf3+diug4Muq/MN4DqWW7l4eBEfAw2/IZuIXmzbCh0AVi0TAUcFOj4UH9sSRNvVv3L8Ajwp6EbGKphgSIWUa2ksqZ12rMFBZr0k0U4cSi3laHZXJWxDW1RvWNRe675GjstM3tl0x6hhs472+IPH3rCSD306HTBNXI1BSug/jnwno8wHElaezI8MR2uXzVWDiBL/KgLIGXQW06+U/IdcBdQZiNPsYEWiWnP1IN0j9V41RvFPvUVJzCo8G3H9V9LRoIMknVMC2F74XyjZTqkTnqYkob+PpxjQyifAMEHe0Rx2yA/uNbNsVio6lm2E7DNXEeRQHLkZ0/q9Mx3zn5iDHfOhwDgoFqtwMD7x9UrgP67Ldz+zYPFecZEZw1mKayieAnLz1HpZueLKqF2PWQU6GO5yV2wL0OaaB2bxEgrbMUhs+k6NBr096RYVa7AJv3GOfq7bNw1SknT9HowMlofQT09/UD0tTMTMPVdS2JcRmCpC8AkyVZINCQ9BPnXeoNwJ9NBtJIUH0cVI2V2JO1rQSh6KgXSKb8oZxhA6unWSDAOShns24X9I6MzUwBi0Wi7VZXFZbTMl6paSd6eLITk+5Z724zVGyJeli6pbghzsQLR6Y6BGGnPwO86MAHb6mU2WSlq7GCmiNKQo9mMfE7SumAi3RW/eOp92cuhEZ40XwLYRFd5pgovqs4W9DA3Q+ieDDEFpHRTZfOOfb/0iX+T4hUvz4MaQMfQJA/9oku/eFtF9FLebR0YmXX0x5ClTK3RaoOcdnnUGkZN1lHz1MHAowtSfJ9uLJe1AQIOQ134VU1zel5mF8qe1yGrw5D+FEUSAn63m3CYvZPfFiiuDr9ImdfmPbkSe4Jht0wHBqRFySNT7T4ySnn+09JDZAuUsIjIq+U4bFugE/FMewSx7L5K 7ZkLxCTx uoLxOYmEkZYBdiJm0y/Frw60B+eLkaD3cGJCahPaEisO1YJRVgwZcX5gWwHGzGkgbwJ3+Ojxpx/jd+uO33mRNQOoXeepY9jC5gPIkap8Y5RHAAuxSc1pmq0RA3q+/FgKLcDTiVbMSC1fhOuC/Ut/CfYPZKKFFICPNQP+tjN5vdgvSt3SQrp1CxLfA0jwks6yhZovqkmeMMwwWRoJMaJBQTANUtaMG44gQZ7IJWInlXYEgArcnC0G1F26bIxXk0NeAbuKLlC/ljIHyyoUq4AxLeL3OGX06FbONv+Tx2ZV7pGuECR/bcNrdhJRkdMVUUdiy3iLI8fQFne6X576LJcdNzINYhKB7tA45zkmgb7DcRco6/Pbv7FZpE44nwu5bBtk0gf30DswOfoOHJBzlGNqirymUQZaiDE1NmsomI7vAfoQYmu9AQvaYF+VguS0J+aVD+i37JAbSXoXcb4zObC5gVEX1b681Ouxoy+9n6bxgLC33r92St8zI8dpdbpsaMT3WOYtTC5iMabuIs9/H9xBwZ2rgHboJQfhYjQIAMtf/a/oEIVzh4dzjnPDrx4goZYqSj7nKP2x+a8RB+uXcMVHAdMo8+qAbwJi/+02pFYIyJJqfxFaCAbpDv3984tFxCrD5wGFWphWRqef5Qxk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/30/23 02:06, Johannes Thumshirn wrote: > Check if adding pages to clone bio fails and if bail out. Nope. The code retries with direct reclaim until it succeeds. Which is very suspicious... > > This way we can mark bio_add_pages as __must_check. > > Signed-off-by: Johannes Thumshirn With the commit message fixed, Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research