From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9B12C4332F for ; Tue, 18 Oct 2022 22:43:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 439B56B0071; Tue, 18 Oct 2022 18:43:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C1866B0072; Tue, 18 Oct 2022 18:43:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 263E46B0073; Tue, 18 Oct 2022 18:43:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 120576B0071 for ; Tue, 18 Oct 2022 18:43:28 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D52A21410D1 for ; Tue, 18 Oct 2022 22:43:27 +0000 (UTC) X-FDA: 80035548054.30.52F83FF Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf21.hostedemail.com (Postfix) with ESMTP id 4F5191C0028 for ; Tue, 18 Oct 2022 22:43:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666133007; x=1697669007; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=qxulG9G/t9vwt+iUnsW6mUi/P6PmpV9ptb8IJUKW4BE=; b=OAQcB1uQ2Q2PoMxj+DyaB8JorRopc6Q6jG34XBITjrWYH0I1ezem5HuE T9Vv6HGKDXbgtb89T9q0B5kF2uVd2onab/TneWi81OEDu8nWJoVUt2lyO TPuyKFACA6wI+hcIAoBB1PUhsbtuuZ3QecLd9ALQIMYnPX1RR8Y9JvO+h uT0Ob4k4ttAhksE82s6tUJ35NC9kUo7asn8Mgw3Xp5CNgbJi5TWQuKkjo dYjX6kcrc7zlwr9EuxXnCHXliZVL14QrlN21xht/H8yCCh0mlYYF8eqKz lDOXdyUeksg92v2iQ7hUb+2wQYvpYgbwB0aTEEMSL3+IctOoyDznw9LKZ Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="289571074" X-IronPort-AV: E=Sophos;i="5.95,194,1661842800"; d="scan'208";a="289571074" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 15:43:26 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="660033283" X-IronPort-AV: E=Sophos;i="5.95,194,1661842800"; d="scan'208";a="660033283" Received: from jjsopko-mobl.amr.corp.intel.com (HELO [10.213.163.40]) ([10.213.163.40]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 15:43:24 -0700 Message-ID: <3a0dd700-ce2e-e1ec-ee8b-74cd68c360b7@intel.com> Date: Tue, 18 Oct 2022 15:43:24 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCHv10 10/15] x86/mm, iommu/sva: Make LAM and SVM mutually exclusive Content-Language: en-US To: "Kirill A. Shutemov" Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , x86@kernel.org, Kostya Serebryany , Andrey Ryabinin , Andrey Konovalov , Alexander Potapenko , Taras Madan , Dmitry Vyukov , "H . J . Lu" , Andi Kleen , Rick Edgecombe , Bharata B Rao , Jacob Pan , Ashok Raj , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20221018113358.7833-1-kirill.shutemov@linux.intel.com> <20221018113358.7833-11-kirill.shutemov@linux.intel.com> <20221018223341.tiyypudh6k63mnnb@box.shutemov.name> From: Dave Hansen In-Reply-To: <20221018223341.tiyypudh6k63mnnb@box.shutemov.name> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666133007; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8h9ss8oLHvUfPBTfJRUDsknp21AQ+tsGL8pzOBfiUXI=; b=BCGDeQ1ozX6ePz8L29budY+N5jJih0dvqF9dvfzrw08gRR19ILdyV9iAOz4Zovg9lspe4r MSVZSQFBLKYYblCgr2Gm/tYMx3Suvbo0Dm2RND7xeAGu+jLNC7wD9UBl8EflUc99FjWbDe PrLMdlBH0YZmGYoOz/kZho0NBhHGBmo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=OAQcB1uQ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666133007; a=rsa-sha256; cv=none; b=ZS8UHe5QqFGyNQzYxqlvGswrGzAA9qnKktWPBVfMdRHj+uJcBPIFpuCdnUXXBxaUaJRUqG LHfTezgB48xD6053hxPh7pjC5rCig62zODT/l3MgTfctb19dOPAhHiNzWefn/Zrt/8rWbv 12OlNfdFWpIcd5C5aSjFt4DOJBS7wAg= Authentication-Results: imf21.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=OAQcB1uQ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=dave.hansen@intel.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4F5191C0028 X-Rspam-User: X-Stat-Signature: kdejjekob9n9kqgaekyzmbwpkst1w7rr X-HE-Tag: 1666133007-402515 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/18/22 15:33, Kirill A. Shutemov wrote: >> Is this #ifdef really necessary? CONFIG_IOMMU_SVA selects IOASID, >> without which pasid_valid() is just stubbed out to 0. > mm->pasid is only defined for CONFIG_IOMMU_SVA=y. > > Do you want me to add mm_has_valid_pasid()? A quick grep makes it look like pasid_valid() could be *replaced* with mm_has_pasid_valid() since all the places doing pasid_valid() do it with mm->pasid.