From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <owner-linux-mm@kvack.org>
Received: from mail-pf0-f200.google.com (mail-pf0-f200.google.com [209.85.192.200])
	by kanga.kvack.org (Postfix) with ESMTP id 748426B0390
	for <linux-mm@kvack.org>; Wed, 12 Apr 2017 21:03:22 -0400 (EDT)
Received: by mail-pf0-f200.google.com with SMTP id 89so3865285pfj.9
        for <linux-mm@kvack.org>; Wed, 12 Apr 2017 18:03:22 -0700 (PDT)
Received: from mail-pg0-x243.google.com (mail-pg0-x243.google.com. [2607:f8b0:400e:c05::243])
        by mx.google.com with ESMTPS id w5si22045417pgf.403.2017.04.12.18.03.21
        for <linux-mm@kvack.org>
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Wed, 12 Apr 2017 18:03:21 -0700 (PDT)
Received: by mail-pg0-x243.google.com with SMTP id o123so8206752pga.1
        for <linux-mm@kvack.org>; Wed, 12 Apr 2017 18:03:21 -0700 (PDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH] mm: add VM_STATIC flag to vmalloc and prevent from
 removing the areas
From: Ho-Eun Ryu <hoeun.ryu@gmail.com>
In-Reply-To: <20170412173151.GA23054@infradead.org>
Date: Thu, 13 Apr 2017 10:03:14 +0900
Content-Transfer-Encoding: quoted-printable
Message-Id: <3F99A1DC-3DEF-4EEB-AD6E-7848D7A6049D@gmail.com>
References: <1491973350-26816-1-git-send-email-hoeun.ryu@gmail.com>
 <20170412060218.GA16170@infradead.org>
 <AC5E3048-6E2B-4DBE-80BA-AAE2D3EED969@gmail.com>
 <20170412173151.GA23054@infradead.org>
Sender: owner-linux-mm@kvack.org
List-ID: <linux-mm.kvack.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Andreas Dilger <adilger@dilger.ca>, Vlastimil Babka <vbabka@suse.cz>, Michal Hocko <mhocko@suse.com>, Chris Wilson <chris@chris-wilson.co.uk>, Ingo Molnar <mingo@kernel.org>, zijun_hu <zijun_hu@htc.com>, Matthew Wilcox <mawilcox@microsoft.com>, Thomas Garnier <thgarnie@google.com>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, linux-arch@vger.kernel.org, linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>


> On 13 Apr 2017, at 2:31 AM, Christoph Hellwig <hch@infradead.org> =
wrote:
>=20
> On Wed, Apr 12, 2017 at 08:42:08PM +0900, Hoeun Ryu wrote:
>>=20
>>> On Apr 12, 2017, at 3:02 PM, Christoph Hellwig <hch@infradead.org> =
wrote:
>>>=20
>>>> On Wed, Apr 12, 2017 at 02:01:59PM +0900, Hoeun Ryu wrote:
>>>> vm_area_add_early/vm_area_register_early() are used to reserve =
vmalloc area
>>>> during boot process and those virtually mapped areas are never =
unmapped.
>>>> So `OR` VM_STATIC flag to the areas in vmalloc_init() when =
importing
>>>> existing vmlist entries and prevent those areas from being removed =
from the
>>>> rbtree by accident.
>>>=20
>>> How would they be removed "by accident"?
>>=20
>> I don't mean actual use-cases, but I just want to make it robust =
against like programming errors.
>=20
> Oh, ok.  The patch makes sense then, although the changelog could use
> a little update.

OK, I will.
Any other suggestions for code itself ?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>