From: Ho-Eun Ryu <hoeun.ryu@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Andreas Dilger <adilger@dilger.ca>,
Vlastimil Babka <vbabka@suse.cz>, Michal Hocko <mhocko@suse.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
Ingo Molnar <mingo@kernel.org>, zijun_hu <zijun_hu@htc.com>,
Matthew Wilcox <mawilcox@microsoft.com>,
Thomas Garnier <thgarnie@google.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
linux-arch@vger.kernel.org, linux-mm@kvack.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: add VM_STATIC flag to vmalloc and prevent from removing the areas
Date: Thu, 13 Apr 2017 10:03:14 +0900 [thread overview]
Message-ID: <3F99A1DC-3DEF-4EEB-AD6E-7848D7A6049D@gmail.com> (raw)
In-Reply-To: <20170412173151.GA23054@infradead.org>
> On 13 Apr 2017, at 2:31 AM, Christoph Hellwig <hch@infradead.org> wrote:
>
> On Wed, Apr 12, 2017 at 08:42:08PM +0900, Hoeun Ryu wrote:
>>
>>> On Apr 12, 2017, at 3:02 PM, Christoph Hellwig <hch@infradead.org> wrote:
>>>
>>>> On Wed, Apr 12, 2017 at 02:01:59PM +0900, Hoeun Ryu wrote:
>>>> vm_area_add_early/vm_area_register_early() are used to reserve vmalloc area
>>>> during boot process and those virtually mapped areas are never unmapped.
>>>> So `OR` VM_STATIC flag to the areas in vmalloc_init() when importing
>>>> existing vmlist entries and prevent those areas from being removed from the
>>>> rbtree by accident.
>>>
>>> How would they be removed "by accident"?
>>
>> I don't mean actual use-cases, but I just want to make it robust against like programming errors.
>
> Oh, ok. The patch makes sense then, although the changelog could use
> a little update.
OK, I will.
Any other suggestions for code itself ?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-04-13 1:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 5:01 Hoeun Ryu
2017-04-12 6:02 ` Christoph Hellwig
2017-04-12 11:42 ` Hoeun Ryu
2017-04-12 17:31 ` Christoph Hellwig
2017-04-13 1:03 ` Ho-Eun Ryu [this message]
2017-04-13 4:17 ` Anshuman Khandual
2017-04-14 0:25 ` Hoeun Ryu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F99A1DC-3DEF-4EEB-AD6E-7848D7A6049D@gmail.com \
--to=hoeun.ryu@gmail.com \
--cc=adilger@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=chris@chris-wilson.co.uk \
--cc=hch@infradead.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mawilcox@microsoft.com \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=thgarnie@google.com \
--cc=vbabka@suse.cz \
--cc=zijun_hu@htc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox