From: Zi Yan <ziy@nvidia.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "\"Huang,
Ying\"" <ying.huang@intel.com>,
Ryan Roberts <ryan.roberts@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
"\"Yin, Fengwei\"" <fengwei.yin@intel.com>,
Yu Zhao <yuzhao@google.com>, Vlastimil Babka <vbabka@suse.cz>,
"\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Kemeng Shi <shikemeng@huaweicloud.com>,
Mel Gorman <mgorman@techsingularity.net>,
Rohan Puri <rohan.puri15@gmail.com>,
Mcgrof Chamberlain <mcgrof@kernel.org>,
Adam Manzanares <a.manzanares@samsung.com>,
"\"Vishal Moola (Oracle)\"" <vishal.moola@gmail.com>
Subject: Re: [PATCH v1 1/4] mm/compaction: enable compacting >0 order folios.
Date: Mon, 13 Nov 2023 14:22:30 -0500 [thread overview]
Message-ID: <3F771C36-C889-448D-89B0-2202CF5EF7E2@nvidia.com> (raw)
In-Reply-To: <ZVJrTEDRzjIfL7kq@casper.infradead.org>
[-- Attachment #1: Type: text/plain, Size: 606 bytes --]
On 13 Nov 2023, at 13:30, Matthew Wilcox wrote:
> On Mon, Nov 13, 2023 at 12:01:54PM -0500, Zi Yan wrote:
>> + /* this makes migrate_pages() split the source page and retry */
>> + if (folio_order(src) > 0)
>> + return NULL;
>
> Nit: folio_test_large() is more efficient than folio_order() > 0.
> The former simply tests the bit, while the second tests the bit, then
> loads folio->_order to check it's >0. We know it will be, but there's
> no way to tell gcc that if the bit is set, this value is definitely not 0.
Got it. Make sense. Will change it in next version. Thanks.
--
Best Regards,
Yan, Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]
next prev parent reply other threads:[~2023-11-13 19:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 17:01 [PATCH v1 0/4] Enable >0 order folio memory compaction Zi Yan
2023-11-13 17:01 ` [PATCH v1 1/4] mm/compaction: enable compacting >0 order folios Zi Yan
2023-11-13 18:30 ` Matthew Wilcox
2023-11-13 19:22 ` Zi Yan [this message]
2023-11-20 9:18 ` Baolin Wang
2023-11-20 14:05 ` Zi Yan
2023-11-13 17:01 ` [PATCH v1 2/4] mm/compaction: add support for >0 order folio memory compaction Zi Yan
2024-01-09 15:18 ` Ryan Roberts
2024-01-09 15:25 ` Zi Yan
2023-11-13 17:01 ` [PATCH v1 3/4] mm/compaction: optimize >0 order folio compaction with free page split Zi Yan
2023-11-22 10:26 ` Ryan Roberts
2023-11-22 14:35 ` Zi Yan
2023-11-13 17:01 ` [PATCH v1 4/4] mm/compaction: optimize >0 order folio compaction by sorting source pages Zi Yan
2023-11-21 15:46 ` [PATCH v1 0/4] Enable >0 order folio memory compaction Ryan Roberts
2023-11-21 16:45 ` Zi Yan
2023-11-21 17:11 ` Ryan Roberts
2024-01-02 20:50 ` Zi Yan
2024-01-03 9:12 ` Ryan Roberts
2024-01-03 15:51 ` Zi Yan
2024-01-05 22:56 ` Zi Yan
2023-11-24 14:58 ` Ryan Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F771C36-C889-448D-89B0-2202CF5EF7E2@nvidia.com \
--to=ziy@nvidia.com \
--cc=a.manzanares@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=fengwei.yin@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=mgorman@techsingularity.net \
--cc=rohan.puri15@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=shikemeng@huaweicloud.com \
--cc=vbabka@suse.cz \
--cc=vishal.moola@gmail.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox