* Re: 2.5.67-mm1
2003-04-08 11:22 2.5.67-mm1 Andrew Morton
@ 2003-04-08 13:01 ` William Lee Irwin III
2003-04-08 13:17 ` 2.5.67-mm1 Ed Tomlinson
` (4 subsequent siblings)
5 siblings, 0 replies; 29+ messages in thread
From: William Lee Irwin III @ 2003-04-08 13:01 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, linux-mm
On Tue, Apr 08, 2003 at 04:22:39AM -0700, Andrew Morton wrote:
> +remove-nr_reverse_maps.patch
> Remove /proc/meminfo:ReverseMaps. It is measurably expensive.
This is fine. The changelog comment doesn't look right though. It says
it's inferrable from slabinfo; it's meant to measure the number of
reverse mappings performed, or aggregate faulted-in virtualspace on the
system, or the number of PTE's pointing at userspace data.
The internal fragmentation within slabs is a separate notion.
pte_chains carry more than a single pointer, so the net utilization and
internal fragmentation of the things allocated can be computed from
nr_reverse_maps/(#pte_chains * NR_PTE), and is very different from the
internal fragmentation of slabs (there is no relationship whatsoever).
This stuff has been disturbed on several occasions, and effectively
lost whatever meaning it had left after PG_direct anyway, regardless
of who changed it to mean what, as the accounting was never adjusted to
remove PG_direct reverse mappings (the actions, not any kind of space)
from the count due to not being able to identify the notion that would
be measured by it. nr_shared_reverse_maps? It's dead, kill it.
-- wli
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: 2.5.67-mm1
2003-04-08 11:22 2.5.67-mm1 Andrew Morton
2003-04-08 13:01 ` 2.5.67-mm1 William Lee Irwin III
@ 2003-04-08 13:17 ` Ed Tomlinson
2003-04-08 15:31 ` 2.5.67-mm1 Randy.Dunlap
2003-04-08 16:10 ` 2.5.67-mm1 Andrew Morton
2003-04-08 14:08 ` 2.5.67-mm1 William Lee Irwin III
` (3 subsequent siblings)
5 siblings, 2 replies; 29+ messages in thread
From: Ed Tomlinson @ 2003-04-08 13:17 UTC (permalink / raw)
To: Andrew Morton, linux-kernel, linux-mm
Hi,
This does not boot here. I loop with the following message.
i8042.c: Can't get irq 12 for AUX, unregistering the port.
irq 12 is used (correctly) by my 20267 ide card. My mouse is
usb and AUX is not used.
Ideas?
Ed Tomlinson
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: 2.5.67-mm1
2003-04-08 13:17 ` 2.5.67-mm1 Ed Tomlinson
@ 2003-04-08 15:31 ` Randy.Dunlap
2003-04-08 15:39 ` 2.5.67-mm1 Ed Tomlinson
2003-04-08 16:18 ` 2.5.67-mm1 Ed Tomlinson
2003-04-08 16:10 ` 2.5.67-mm1 Andrew Morton
1 sibling, 2 replies; 29+ messages in thread
From: Randy.Dunlap @ 2003-04-08 15:31 UTC (permalink / raw)
To: Ed Tomlinson; +Cc: akpm, linux-kernel, linux-mm
On Tue, 8 Apr 2003 09:17:15 -0400 Ed Tomlinson <tomlins@cam.org> wrote:
| Hi,
|
| This does not boot here. I loop with the following message.
|
| i8042.c: Can't get irq 12 for AUX, unregistering the port.
|
| irq 12 is used (correctly) by my 20267 ide card. My mouse is
| usb and AUX is not used.
|
| Ideas?
I guess that's due to my early kbd init patch.
So why do you have i8042 configured into your kernel?
The loop doesn't terminate? Do you get the same message (above)
over and over again?
--
~Randy
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: 2.5.67-mm1
2003-04-08 15:31 ` 2.5.67-mm1 Randy.Dunlap
@ 2003-04-08 15:39 ` Ed Tomlinson
2003-04-08 16:14 ` 2.5.67-mm1 Randy.Dunlap
2003-04-08 16:18 ` 2.5.67-mm1 Ed Tomlinson
1 sibling, 1 reply; 29+ messages in thread
From: Ed Tomlinson @ 2003-04-08 15:39 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: akpm, linux-kernel, linux-mm
On April 8, 2003 11:31 am, Randy.Dunlap wrote:
> On Tue, 8 Apr 2003 09:17:15 -0400 Ed Tomlinson <tomlins@cam.org> wrote:
> | Hi,
> |
> | This does not boot here. I loop with the following message.
> |
> | i8042.c: Can't get irq 12 for AUX, unregistering the port.
> |
> | irq 12 is used (correctly) by my 20267 ide card. My mouse is
> | usb and AUX is not used.
> |
> | Ideas?
>
> I guess that's due to my early kbd init patch.
> So why do you have i8042 configured into your kernel?
One, What exactly configures it? Two my keyboard is not usb, just
my mouse.
> The loop doesn't terminate? Do you get the same message (above)
> over and over again?
Yes, until I trigger a reboot (SysReq+B).
Ed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: 2.5.67-mm1
2003-04-08 15:39 ` 2.5.67-mm1 Ed Tomlinson
@ 2003-04-08 16:14 ` Randy.Dunlap
0 siblings, 0 replies; 29+ messages in thread
From: Randy.Dunlap @ 2003-04-08 16:14 UTC (permalink / raw)
To: Ed Tomlinson; +Cc: akpm, linux-kernel, linux-mm
On Tue, 8 Apr 2003 11:39:58 -0400 Ed Tomlinson <tomlins@cam.org> wrote:
| On April 8, 2003 11:31 am, Randy.Dunlap wrote:
| > On Tue, 8 Apr 2003 09:17:15 -0400 Ed Tomlinson <tomlins@cam.org> wrote:
| > | Hi,
| > |
| > | This does not boot here. I loop with the following message.
| > |
| > | i8042.c: Can't get irq 12 for AUX, unregistering the port.
| > |
| > | irq 12 is used (correctly) by my 20267 ide card. My mouse is
| > | usb and AUX is not used.
| > |
| > | Ideas?
| >
| > I guess that's due to my early kbd init patch.
| > So why do you have i8042 configured into your kernel?
|
| One, What exactly configures it? Two my keyboard is not usb, just
| my mouse.
CONFIG_SERIO=y
CONFIG_SERIO_I8042=y
Is your keyboard PS/2 or PC-AT-like, or something else?
| > The loop doesn't terminate? Do you get the same message (above)
| > over and over again?
|
| Yes, until I trigger a reboot (SysReq+B).
Interesting. If I force that register IRQ 12 to fail, I just get this
one time:
i8042.c: Can't get irq 12 for AUX, unregistering the port.
serio: i8042 AUX port at 0x60,0x64 irq 12
serio: i8042 KBD port at 0x60,0x64 irq 1
Just saw Andrew's email...
--
~Randy
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: 2.5.67-mm1
2003-04-08 15:31 ` 2.5.67-mm1 Randy.Dunlap
2003-04-08 15:39 ` 2.5.67-mm1 Ed Tomlinson
@ 2003-04-08 16:18 ` Ed Tomlinson
1 sibling, 0 replies; 29+ messages in thread
From: Ed Tomlinson @ 2003-04-08 16:18 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: akpm, linux-kernel, linux-mm
On April 8, 2003 11:31 am, Randy.Dunlap wrote:
> | This does not boot here. I loop with the following message.
> |
> | i8042.c: Can't get irq 12 for AUX, unregistering the port.
> |
> | irq 12 is used (correctly) by my 20267 ide card. My mouse is
> | usb and AUX is not used.
> |
> | Ideas?
>
> I guess that's due to my early kbd init patch.
Just to confirm, removing the above patch lets me
boot just fine.
Thanks
Ed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: 2.5.67-mm1
2003-04-08 13:17 ` 2.5.67-mm1 Ed Tomlinson
2003-04-08 15:31 ` 2.5.67-mm1 Randy.Dunlap
@ 2003-04-08 16:10 ` Andrew Morton
2003-04-08 16:50 ` 2.5.67-mm1 Ed Tomlinson
1 sibling, 1 reply; 29+ messages in thread
From: Andrew Morton @ 2003-04-08 16:10 UTC (permalink / raw)
To: Ed Tomlinson; +Cc: linux-kernel, linux-mm
Ed Tomlinson <tomlins@cam.org> wrote:
>
> Hi,
>
> This does not boot here. I loop with the following message.
>
> i8042.c: Can't get irq 12 for AUX, unregistering the port.
>
> irq 12 is used (correctly) by my 20267 ide card. My mouse is
> usb and AUX is not used.
>
Does the below patch help? Probably not...
And does reverting
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.67/2.5.67-mm1/broken-out/earlier-keyboard-init.patch
fix it?
Thanks.
diff -puN drivers/input/serio/i8042.c~i8042-share-irqs drivers/input/serio/i8042.c
--- 25/drivers/input/serio/i8042.c~i8042-share-irqs 2003-04-08 09:05:16.000000000 -0700
+++ 25-akpm/drivers/input/serio/i8042.c 2003-04-08 09:05:59.000000000 -0700
@@ -235,7 +235,8 @@ static int i8042_open(struct serio *port
if (i8042_mux_open++)
return 0;
- if (request_irq(values->irq, i8042_interrupt, 0, "i8042", NULL)) {
+ if (request_irq(values->irq, i8042_interrupt,
+ SA_SHIRQ, "i8042", NULL)) {
printk(KERN_ERR "i8042.c: Can't get irq %d for %s, unregistering the port.\n", values->irq, values->name);
values->exists = 0;
serio_unregister_port(port);
@@ -570,7 +571,7 @@ static int __init i8042_check_mux(struct
* Check if AUX irq is available.
*/
- if (request_irq(values->irq, i8042_interrupt, 0, "i8042", NULL))
+ if (request_irq(values->irq, i8042_interrupt, SA_SHIRQ, "i8042", NULL))
return -1;
free_irq(values->irq, NULL);
@@ -641,7 +642,7 @@ static int __init i8042_check_aux(struct
* in trying to detect AUX presence.
*/
- if (request_irq(values->irq, i8042_interrupt, 0, "i8042", NULL))
+ if (request_irq(values->irq, i8042_interrupt, SA_SHIRQ, "i8042", NULL))
return -1;
free_irq(values->irq, NULL);
_
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: 2.5.67-mm1
2003-04-08 16:10 ` 2.5.67-mm1 Andrew Morton
@ 2003-04-08 16:50 ` Ed Tomlinson
0 siblings, 0 replies; 29+ messages in thread
From: Ed Tomlinson @ 2003-04-08 16:50 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, linux-mm
On April 8, 2003 12:10 pm, Andrew Morton wrote:
> Does the below patch help?
Yes. With it 67-mm1 boots. I do find the following in dmesg though:
CPU: AMD-K6(tm) 3D+ Processor stepping 01
Checking 'hlt' instruction... OK.
POSIX conformance testing by UNIFIX
Initializing RT netlink socket
mtrr: v2.0 (20020519)
pty: 256 Unix98 ptys configured
Bad boy: i8042 (at 0xc0320738) called us without a dev_id!
Bad boy: i8042 (at 0xc0320852) called us without a dev_id!
Bad boy: i8042 (at 0xc020a9e8) called us without a dev_id!
serio: i8042 AUX port at 0x60,0x64 irq 12
Bad boy: i8042 (at 0xc020a9e8) called us without a dev_id!
input: AT Set 2 keyboard on isa0060/serio0
serio: i8042 KBD port at 0x60,0x64 irq 1
PCI: PCI BIOS revision 2.10 entry at 0xfb520, last bus=1
PCI: Using configuration type 1
BIO: pool of 256 setup, 14Kb (56 bytes/bio)
Box seems to work fine. There is nothing plugged onto AUX
as my mouse is USB. The keyboard is plugged into the other
PS2 port...
Ed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: 2.5.67-mm1
2003-04-08 11:22 2.5.67-mm1 Andrew Morton
2003-04-08 13:01 ` 2.5.67-mm1 William Lee Irwin III
2003-04-08 13:17 ` 2.5.67-mm1 Ed Tomlinson
@ 2003-04-08 14:08 ` William Lee Irwin III
2003-04-08 16:43 ` 2.5.67-mm1 Helge Hafting
` (2 subsequent siblings)
5 siblings, 0 replies; 29+ messages in thread
From: William Lee Irwin III @ 2003-04-08 14:08 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, linux-mm
On Tue, Apr 08, 2003 at 04:22:39AM -0700, Andrew Morton wrote:
> http://www.zip.com.au/~akpm/linux/patches/2.5/2.5.67-mm1.gz
> Will appear sometime at
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.67/2.5.67-mm1/
> . sparc64 is now using gcc-3.x, so there is a patch here to make gcc-2.95
> the minimum required version.
> . A few rmap-speedup patches reduce the rmap CPU tax by 25-30% on a P4
> . Various other cleaups, speedups and fixups.
task_vsize() mysteriously appeared on my profiles. This should remove
it from them by using the already in-use elsewhere for rlimit checks
mm->total_vm for the benefit of O(1) cachelines touched.
--- virgin-2.5.67/fs/proc/task_mmu.c Wed Jan 15 08:46:04 2003
+++ wli-2.5.67-1/fs/proc/task_mmu.c Tue Apr 8 06:57:27 2003
@@ -45,13 +45,7 @@
unsigned long task_vsize(struct mm_struct *mm)
{
- struct vm_area_struct *vma;
- unsigned long vsize = 0;
-
- for (vma = mm->mmap; vma; vma = vma->vm_next)
- vsize += vma->vm_end - vma->vm_start;
-
- return vsize;
+ return PAGE_SIZE * mm->total_vm;
}
int task_statm(struct mm_struct *mm, int *shared, int *text,
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: 2.5.67-mm1
2003-04-08 11:22 2.5.67-mm1 Andrew Morton
` (2 preceding siblings ...)
2003-04-08 14:08 ` 2.5.67-mm1 William Lee Irwin III
@ 2003-04-08 16:43 ` Helge Hafting
2003-04-09 9:42 ` 2.5.67-mm1 cause framebuffer crash at bootup Helge Hafting
2003-05-28 11:14 ` 2.5.67-mm1 bootcrash, possibly IDE or RAID Helge Hafting
5 siblings, 0 replies; 29+ messages in thread
From: Helge Hafting @ 2003-04-08 16:43 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, linux-mm
Devfs fails to find all partitions with 2.5.67-mm1, plain 2.5.67 is fine
I have 2 scsi disks, and 2.5.67-mm1 find only some of the partitions
when I boot. Below is ls -l listings for /dev/discs/disc0 and
/dev/discs/disc1. Note the missing stuff - linux wasn't at all
happy when the device for /usr couldn't be found at boot time.
Running cfdisk showed that the partitions were there though.
Helge Hafting
2.5.67-mm1: ls -l /dev/discs/disc0/
total 0
brw-rw---- 1 root disk 8, 0 Jan 1 1970 disc
crw------- 1 root root 21, 0 Jan 1 1970 generic
brw-rw---- 1 root disk 8, 1 Jan 1 1970 part1
brw-rw---- 1 root disk 8, 8 Jan 1 1970 part8
2.5.67: ls -l /dev/discs/disc0/
totalt 0
brw-rw---- 1 root disk 8, 0 1970-01-01 01:00 disc
crw------- 1 root root 21, 0 1970-01-01 01:00 generic
brw-rw---- 1 root disk 8, 1 1970-01-01 01:00 part1
brw-rw---- 1 root disk 8, 2 1970-01-01 01:00 part2
brw-rw---- 1 root disk 8, 3 1970-01-01 01:00 part3
brw-rw---- 1 root disk 8, 5 1970-01-01 01:00 part5
brw-rw---- 1 root disk 8, 6 1970-01-01 01:00 part6
brw-rw---- 1 root disk 8, 7 1970-01-01 01:00 part7
brw-rw---- 1 root disk 8, 8 1970-01-01 01:00 part8
And the second disk:
2.5.67-mm1: ls -l /dev/discs/disc1/
total 0
brw-rw---- 1 root disk 8, 16 Jan 1 1970 disc
crw------- 1 root root 21, 1 Jan 1 1970 generic
brw-rw---- 1 root disk 8, 17 Jan 1 1970 part1
brw-rw---- 1 root disk 8, 18 Jan 1 1970 part2
brw-rw---- 1 root disk 8, 22 Jan 1 1970 part6
brw-rw---- 1 root disk 8, 23 Jan 1 1970 part7
brw-rw---- 1 root disk 8, 24 Jan 1 1970 part8
2.5.67: ls -l /dev/discs/disc1/
totalt 0
brw-rw---- 1 root disk 8, 16 1970-01-01 01:00 disc
crw------- 1 root root 21, 1 1970-01-01 01:00 generic
brw-rw---- 1 root disk 8, 17 1970-01-01 01:00 part1
brw-rw---- 1 root disk 8, 18 1970-01-01 01:00 part2
brw-rw---- 1 root disk 8, 21 1970-01-01 01:00 part5
brw-rw---- 1 root disk 8, 22 1970-01-01 01:00 part6
brw-rw---- 1 root disk 8, 23 1970-01-01 01:00 part7
brw-rw---- 1 root disk 8, 24 1970-01-01 01:00 part8
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: 2.5.67-mm1 cause framebuffer crash at bootup
2003-04-08 11:22 2.5.67-mm1 Andrew Morton
` (3 preceding siblings ...)
2003-04-08 16:43 ` 2.5.67-mm1 Helge Hafting
@ 2003-04-09 9:42 ` Helge Hafting
[not found] ` <20030409030534.619f7fa0.akpm@digeo.com>
[not found] ` <20030409031845.185d853f.akpm@digeo.com>
2003-05-28 11:14 ` 2.5.67-mm1 bootcrash, possibly IDE or RAID Helge Hafting
5 siblings, 2 replies; 29+ messages in thread
From: Helge Hafting @ 2003-04-09 9:42 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, linux-mm, vandrove, jsimmons
2.5.67 works with framebuffer console, 2.5.67-mm1 dies before activating
graphichs mode on two different machines:
smp with matroxfb, also using a patch that makes matroxfb work in 2.5
up with radeonfb, also using patches that fixes the broken devfs in mm1.
I use devfs and preempt in both cases, and monolithic kernels without module
support.
2.5.67-mm1 works if I drop framebuffer support completely.
Here is the printed backtrace for the radeon case, the matrox case was
similiar:
<a few lines scrolled off screen>
pcibios_enable_device
pci_enable_device_bars
pci_enable_device
radeonfb_pci_register
sysfs_new_inode
pci_device_probe
bus_match
device_attach
bus_add_device
kobject_add
device_add
pci_bus_add_devices
pci_bus_add_devices
pci_scan_bus_parented
pcibios_scan_root
pci_legacy_init
do_initcalls
init_workqueues
init+0x36
init+0x00
kernel_thread_helper
code: Bad EIP value <0>Kernel panic:attempt to kill init!
sysrq worked and let me reboot. No filesystems were
mounted at this point.
Helge Hafting
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: 2.5.67-mm1 bootcrash, possibly IDE or RAID
2003-04-08 11:22 2.5.67-mm1 Andrew Morton
` (4 preceding siblings ...)
2003-04-09 9:42 ` 2.5.67-mm1 cause framebuffer crash at bootup Helge Hafting
@ 2003-05-28 11:14 ` Helge Hafting
2003-05-28 11:13 ` William Lee Irwin III
5 siblings, 1 reply; 29+ messages in thread
From: Helge Hafting @ 2003-05-28 11:14 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, linux-mm
2.5.69-mm8 is fine, 2.5.67-mm1 dies before mounting anything read-write.
The early kernel boot is fine, the penguin appear,
a bunch of the usual messages scroll by too fast to read,
and then it hangs.
The kernel is UP, with preempt & devfs. All filesystems
are ext2. This kernel has no module support.
Root is on raid-1, there are two
ide disks connected to this controller on separate cables:
00:02.5 IDE interface: Silicon Integrated Systems [SiS] 5513 [IDE]
Here's the decoded crash, written down by hand:
<stuff scrolled off screen>
bio_endio
_end_that_request_first
ide_end_request
ide_dma_intr
ide_intr
ide_dma_intr
handle_IRQ_event
do_IRQ
default_idle
default_idle
common_interrupt
default_idle
default_idle
default_idle
cpu_idle
rest_init
start_kernel
unknown_bootoption
<0>Kwrnel Panic fatal exception in interrupt
in interrupt - not syncing
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: 2.5.67-mm1 bootcrash, possibly IDE or RAID
2003-05-28 11:14 ` 2.5.67-mm1 bootcrash, possibly IDE or RAID Helge Hafting
@ 2003-05-28 11:13 ` William Lee Irwin III
2003-05-28 11:34 ` 2.5.70-mm1 " Helge Hafting
0 siblings, 1 reply; 29+ messages in thread
From: William Lee Irwin III @ 2003-05-28 11:13 UTC (permalink / raw)
To: Helge Hafting; +Cc: Andrew Morton, linux-kernel, linux-mm
On Wed, May 28, 2003 at 01:14:28PM +0200, Helge Hafting wrote:
> 2.5.69-mm8 is fine, 2.5.67-mm1 dies before mounting anything read-write.
> The early kernel boot is fine, the penguin appear,
> a bunch of the usual messages scroll by too fast to read,
> and then it hangs.
> The kernel is UP, with preempt & devfs. All filesystems
> are ext2. This kernel has no module support.
> Root is on raid-1, there are two
> ide disks connected to this controller on separate cables:
> 00:02.5 IDE interface: Silicon Integrated Systems [SiS] 5513 [IDE]
Well, bugs were fixed since 2.5.67-mm1. Just upgrade to the most recent
kernel (2.5.70-mm1).
-- wli
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: 2.5.70-mm1 bootcrash, possibly IDE or RAID
2003-05-28 11:13 ` William Lee Irwin III
@ 2003-05-28 11:34 ` Helge Hafting
2003-05-28 11:35 ` William Lee Irwin III
0 siblings, 1 reply; 29+ messages in thread
From: Helge Hafting @ 2003-05-28 11:34 UTC (permalink / raw)
To: William Lee Irwin III; +Cc: Andrew Morton, linux-kernel, linux-mm
William Lee Irwin III wrote:
> On Wed, May 28, 2003 at 01:14:28PM +0200, Helge Hafting wrote:
>
>>2.5.69-mm8 is fine, 2.5.67-mm1 dies before mounting anything read-write.
Argh. I meant 2.5.70-mm1. Followup to the wrong message. :-(
The early kernel boot is fine, the penguin appear,
a bunch of the usual messages scroll by too fast to read,
and then it hangs.
The kernel is UP, with preempt & devfs. All filesystems
are ext2. This kernel has no module support.
Root is on raid-1, there are two
ide disks connected to this controller on separate cables:
00:02.5 IDE interface: Silicon Integrated Systems [SiS] 5513 [IDE]
Here's the decoded crash, written down by hand:
<stuff scrolled off screen>
bio_endio
_end_that_request_first
ide_end_request
ide_dma_intr
ide_intr
ide_dma_intr
handle_IRQ_event
do_IRQ
default_idle
default_idle
common_interrupt
default_idle
default_idle
default_idle
cpu_idle
rest_init
start_kernel
unknown_bootoption
<0>Kwrnel Panic fatal exception in interrupt
in interrupt - not syncing
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: 2.5.70-mm1 bootcrash, possibly IDE or RAID
2003-05-28 11:34 ` 2.5.70-mm1 " Helge Hafting
@ 2003-05-28 11:35 ` William Lee Irwin III
2003-05-28 22:59 ` 2.5.70-mm1 bootcrash, possibly RAID-1 Helge Hafting
0 siblings, 1 reply; 29+ messages in thread
From: William Lee Irwin III @ 2003-05-28 11:35 UTC (permalink / raw)
To: Helge Hafting; +Cc: Andrew Morton, linux-kernel, linux-mm
On Wed, May 28, 2003 at 01:34:16PM +0200, Helge Hafting wrote:
> Here's the decoded crash, written down by hand:
> <stuff scrolled off screen>
> bio_endio
> _end_that_request_first
> ide_end_request
> ide_dma_intr
> ide_intr
> ide_dma_intr
> handle_IRQ_event
> do_IRQ
> default_idle
> default_idle
> common_interrupt
This is unusual; I'm having trouble very close to this area. There is
a remote chance it could be the same problem.
Could you log this to serial and get the rest of the oops/BUG? If it's
where I think it is, I've been looking at end_page_writeback() and so
might have an idea or two.
-- wli
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: 2.5.70-mm1 bootcrash, possibly RAID-1
2003-05-28 11:35 ` William Lee Irwin III
@ 2003-05-28 22:59 ` Helge Hafting
2003-05-28 23:18 ` Andrew Morton
` (3 more replies)
0 siblings, 4 replies; 29+ messages in thread
From: Helge Hafting @ 2003-05-28 22:59 UTC (permalink / raw)
To: William Lee Irwin III, Andrew Morton, linux-kernel, linux-mm, neilb
On Wed, May 28, 2003 at 04:35:44AM -0700, William Lee Irwin III wrote:
>
> This is unusual; I'm having trouble very close to this area. There is
> a remote chance it could be the same problem.
>
> Could you log this to serial and get the rest of the oops/BUG? If it's
> where I think it is, I've been looking at end_page_writeback() and so
> might have an idea or two.
I tried 2.5.70-mm1 on the dual celeron at home. This one has
scsi instead of ide, so I guess it is a RAID-1 problem.
This machine has root on raid-1 too. I believe there where
several oopses in a row, I captured all of the last one
thanks to a framebuffer with a small font. Here it is:
Unable to handle kernel paging request at virtual address 8a8a8ab6
*pde=0 OOPS 0000 [#1]
EIP at put_all_bios+0x47/0x80
(edx was the register containing 8a8a8a8a)
Process swapper pid=0 threadinfo c1352000 task=c13f52d0
Call trace:
raid_end_bio_io
raid1_end_request
scsi_request_fn
bio_endio
_end_that_request_first
scsi_end_request
__wake_up
scsi_io_completion
scsi_delete_timer
sd_rw_intr
sym_wakeup_done
scsi_finish_command
scsi_softirq
timer_interrupt
do_softirq
do_IRQ
default_idle
default_idle
common_interrupt
default_idle
default_idle
default_idle
cpu_idle
printk
<0> Kernel panic:fatal exception in interrupt
in interrupt - not syncing
reboot in 300 seconds
This looks very similiar to the partial trace
from the ide machine,
it had everything from _end_that_request_first
down to the three default_idles, but with ide
instead of scsi functions.
Helge Hafting
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: 2.5.70-mm1 bootcrash, possibly RAID-1
2003-05-28 22:59 ` 2.5.70-mm1 bootcrash, possibly RAID-1 Helge Hafting
@ 2003-05-28 23:18 ` Andrew Morton
2003-05-28 23:30 ` Paul E. Erkkila
` (2 subsequent siblings)
3 siblings, 0 replies; 29+ messages in thread
From: Andrew Morton @ 2003-05-28 23:18 UTC (permalink / raw)
To: Helge Hafting; +Cc: wli, linux-kernel, linux-mm, neilb
Helge Hafting <helgehaf@aitel.hist.no> wrote:
>
> On Wed, May 28, 2003 at 04:35:44AM -0700, William Lee Irwin III wrote:
> >
> > This is unusual; I'm having trouble very close to this area. There is
> > a remote chance it could be the same problem.
> >
> > Could you log this to serial and get the rest of the oops/BUG? If it's
> > where I think it is, I've been looking at end_page_writeback() and so
> > might have an idea or two.
>
> I tried 2.5.70-mm1 on the dual celeron at home. This one has
> scsi instead of ide, so I guess it is a RAID-1 problem.
> This machine has root on raid-1 too. I believe there where
> several oopses in a row, I captured all of the last one
> thanks to a framebuffer with a small font. Here it is:
>
> Unable to handle kernel paging request at virtual address 8a8a8ab6
> *pde=0 OOPS 0000 [#1]
> EIP at put_all_bios+0x47/0x80
> (edx was the register containing 8a8a8a8a)
> Process swapper pid=0 threadinfo c1352000 task=c13f52d0
> Call trace:
> raid_end_bio_io
> raid1_end_request
That's POISON_BEFORE: "use of uninitialised memory", not "use of freed
memory".
I fiddled with the slab poisoning values, and shall undo that.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: 2.5.70-mm1 bootcrash, possibly RAID-1
2003-05-28 22:59 ` 2.5.70-mm1 bootcrash, possibly RAID-1 Helge Hafting
2003-05-28 23:18 ` Andrew Morton
@ 2003-05-28 23:30 ` Paul E. Erkkila
2003-05-29 1:08 ` Neil Brown
2003-05-29 4:27 ` Alain Toussaint
2003-05-29 13:22 ` John Stoffel
3 siblings, 1 reply; 29+ messages in thread
From: Paul E. Erkkila @ 2003-05-28 23:30 UTC (permalink / raw)
To: Helge Hafting
Cc: William Lee Irwin III, Andrew Morton, linux-kernel, linux-mm, neilb
I'm having a similar problem here with 2.5.70. I can't
seem to get the entire stack trace though, but with a
stripped down kernel config it seems to be when during
the time MD starts working.
Machine is an asus p4c8000, intel ich5, using the IDE
part not sata. I'm also using /dev/md0 as my root
partition.
Hope that helps, i'm trying to find a null modem to
get a real capture ;).
-pee
Helge Hafting wrote:
>On Wed, May 28, 2003 at 04:35:44AM -0700, William Lee Irwin III wrote:
>
>
>>This is unusual; I'm having trouble very close to this area. There is
>>a remote chance it could be the same problem.
>>
>>Could you log this to serial and get the rest of the oops/BUG? If it's
>>where I think it is, I've been looking at end_page_writeback() and so
>>might have an idea or two.
>>
>>
>
>I tried 2.5.70-mm1 on the dual celeron at home. This one has
>scsi instead of ide, so I guess it is a RAID-1 problem.
>This machine has root on raid-1 too. I believe there where
>several oopses in a row, I captured all of the last one
>thanks to a framebuffer with a small font. Here it is:
>
>Unable to handle kernel paging request at virtual address 8a8a8ab6
>*pde=0 OOPS 0000 [#1]
>EIP at put_all_bios+0x47/0x80
>(edx was the register containing 8a8a8a8a)
>Process swapper pid=0 threadinfo c1352000 task=c13f52d0
>Call trace:
>raid_end_bio_io
>raid1_end_request
>scsi_request_fn
>bio_endio
>_end_that_request_first
>scsi_end_request
>__wake_up
>scsi_io_completion
>scsi_delete_timer
>sd_rw_intr
>sym_wakeup_done
>scsi_finish_command
>scsi_softirq
>timer_interrupt
>do_softirq
>do_IRQ
>default_idle
>default_idle
>common_interrupt
>default_idle
>default_idle
>default_idle
>cpu_idle
>printk
><0> Kernel panic:fatal exception in interrupt
>in interrupt - not syncing
>reboot in 300 seconds
>
>This looks very similiar to the partial trace
>from the ide machine,
>it had everything from _end_that_request_first
>down to the three default_idles, but with ide
>instead of scsi functions.
>
>Helge Hafting
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: 2.5.70-mm1 bootcrash, possibly RAID-1
2003-05-28 23:30 ` Paul E. Erkkila
@ 2003-05-29 1:08 ` Neil Brown
2003-05-29 7:14 ` Zwane Mwaikambo
0 siblings, 1 reply; 29+ messages in thread
From: Neil Brown @ 2003-05-29 1:08 UTC (permalink / raw)
To: pee
Cc: Helge Hafting, William Lee Irwin III, Andrew Morton,
linux-kernel, linux-mm
Greetings all.
I think this might fix the bug, but I haven't looked very closely
yet. I will expore it more deeply when I get time.
NeilBrown
----------- Diffstat output ------------
./drivers/md/raid1.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff ./drivers/md/raid1.c~current~ ./drivers/md/raid1.c
--- ./drivers/md/raid1.c~current~ 2003-05-29 11:05:03.000000000 +1000
+++ ./drivers/md/raid1.c 2003-05-29 11:05:08.000000000 +1000
@@ -137,7 +137,7 @@ static void put_all_bios(conf_t *conf, r
BUG();
bio_put(r1_bio->read_bio);
r1_bio->read_bio = NULL;
- }
+ } else
for (i = 0; i < conf->raid_disks; i++) {
struct bio **bio = r1_bio->write_bios + i;
if (*bio) {
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: 2.5.70-mm1 bootcrash, possibly RAID-1
2003-05-29 1:08 ` Neil Brown
@ 2003-05-29 7:14 ` Zwane Mwaikambo
2003-05-29 7:32 ` Zwane Mwaikambo
0 siblings, 1 reply; 29+ messages in thread
From: Zwane Mwaikambo @ 2003-05-29 7:14 UTC (permalink / raw)
To: Neil Brown
Cc: pee, Helge Hafting, William Lee Irwin III, Andrew Morton,
linux-kernel, linux-mm
On Thu, 29 May 2003, Neil Brown wrote:
> I think this might fix the bug, but I haven't looked very closely
> yet. I will expore it more deeply when I get time.
>
> NeilBrown
No go;
raid0: comparing sdd1(4193152) with sdd1(4193152)
raid0: END
raid0: ==> UNIQUE
raid0: 1 zones
raid0: looking at sdc1
raid0: comparing sdc1(4193152) with sdd1(4193152)
raid0: EQUAL
raid0: FINAL 1 zones
raid0: multiple devices for 1 - aborting!
slab error in cache_free_debugcheck(): cache `size-32': double free, or memory before object was overwritten
Call Trace:
[<c0148da3>] kfree+0xf3/0x2e0
[<c0366a64>] raid0_run+0x234/0x250
[<c0366a64>] raid0_run+0x234/0x250
[<c012529a>] printk+0x1ca/0x280
[<c0371fa4>] do_md_run+0x2f4/0x560
[<c0371fbb>] do_md_run+0x30b/0x560
[<c012529a>] printk+0x1ca/0x280
[<c03724f2>] autorun_array+0x82/0xa0
[<c012529a>] printk+0x1ca/0x280
[<c03726ff>] autorun_devices+0x1ef/0x230
[<c0375569>] autostart_arrays+0x29/0xba
[<c036f8f6>] mddev_put+0x16/0xb0
[<c0250728>] capable+0x18/0x40
[<c03737de>] md_ioctl+0x56e/0x5a0
[<c0169759>] blkdev_open+0x29/0x30
[<c015f0dc>] dentry_open+0x14c/0x230
[<c0148c2a>] kmem_cache_free+0x1ca/0x250
[<c02a2f0b>] blkdev_ioctl+0x8b/0x3b1
[<c01747d6>] sys_ioctl+0x156/0x310
[<c056f6b7>] md_run_setup+0x57/0x80
[<c056ef28>] prepare_namespace+0x8/0xa0
[<c01050fb>] init+0x5b/0x210
[<c01050a0>] init+0x0/0x210
[<c01070e5>] kernel_thread_helper+0x5/0x10
--
function.linuxpower.ca
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: 2.5.70-mm1 bootcrash, possibly RAID-1
2003-05-29 7:14 ` Zwane Mwaikambo
@ 2003-05-29 7:32 ` Zwane Mwaikambo
2003-05-30 1:59 ` Neil Brown
0 siblings, 1 reply; 29+ messages in thread
From: Zwane Mwaikambo @ 2003-05-29 7:32 UTC (permalink / raw)
To: Neil Brown
Cc: pee, Helge Hafting, William Lee Irwin III, Andrew Morton,
linux-kernel, linux-mm
How does the following patch look for the double free.
On Thu, 29 May 2003, Zwane Mwaikambo wrote:
> slab error in cache_free_debugcheck(): cache `size-32': double free, or memory before object was overwritten
> Call Trace:
> [<c0148da3>] kfree+0xf3/0x2e0
> [<c0366a64>] raid0_run+0x234/0x250
> [<c0366a64>] raid0_run+0x234/0x250
> [<c012529a>] printk+0x1ca/0x280
> [<c0371fa4>] do_md_run+0x2f4/0x560
> [<c0371fbb>] do_md_run+0x30b/0x560
> [<c012529a>] printk+0x1ca/0x280
> [<c03724f2>] autorun_array+0x82/0xa0
> [<c012529a>] printk+0x1ca/0x280
> [<c03726ff>] autorun_devices+0x1ef/0x230
> [<c0375569>] autostart_arrays+0x29/0xba
> [<c036f8f6>] mddev_put+0x16/0xb0
> [<c0250728>] capable+0x18/0x40
> [<c03737de>] md_ioctl+0x56e/0x5a0
> [<c0169759>] blkdev_open+0x29/0x30
> [<c015f0dc>] dentry_open+0x14c/0x230
> [<c0148c2a>] kmem_cache_free+0x1ca/0x250
> [<c02a2f0b>] blkdev_ioctl+0x8b/0x3b1
> [<c01747d6>] sys_ioctl+0x156/0x310
> [<c056f6b7>] md_run_setup+0x57/0x80
> [<c056ef28>] prepare_namespace+0x8/0xa0
> [<c01050fb>] init+0x5b/0x210
> [<c01050a0>] init+0x0/0x210
> [<c01070e5>] kernel_thread_helper+0x5/0x10
Index: linux-2.5/drivers/md/raid0.c
===================================================================
RCS file: /home/cvs/linux-2.5/drivers/md/raid0.c,v
retrieving revision 1.31
diff -u -p -B -r1.31 raid0.c
--- linux-2.5/drivers/md/raid0.c 27 May 2003 04:06:15 -0000 1.31
+++ linux-2.5/drivers/md/raid0.c 29 May 2003 06:35:17 -0000
@@ -85,10 +85,8 @@ static int create_strip_zones (mddev_t *
conf->devlist = kmalloc(sizeof(mdk_rdev_t*)*
conf->nr_strip_zones*mddev->raid_disks,
GFP_KERNEL);
- if (!conf->devlist) {
- kfree(conf);
+ if (!conf->devlist)
return 1;
- }
memset(conf->strip_zone, 0,sizeof(struct strip_zone)*
conf->nr_strip_zones);
@@ -194,7 +192,6 @@ static int create_strip_zones (mddev_t *
return 0;
abort:
kfree(conf->devlist);
- kfree(conf->strip_zone);
return 1;
}
--
function.linuxpower.ca
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: 2.5.70-mm1 bootcrash, possibly RAID-1
2003-05-29 7:32 ` Zwane Mwaikambo
@ 2003-05-30 1:59 ` Neil Brown
2003-05-31 16:13 ` Paul E. Erkkila
0 siblings, 1 reply; 29+ messages in thread
From: Neil Brown @ 2003-05-30 1:59 UTC (permalink / raw)
To: Zwane Mwaikambo
Cc: pee, Helge Hafting, William Lee Irwin III, Andrew Morton,
linux-kernel, linux-mm
On Thursday May 29, zwane@linuxpower.ca wrote:
> How does the following patch look for the double free.
>
Thanks. It is a good start, but there are other problems with freeing
things on error paths. This patch should fix it all.
NeilBrown
--------------------------------------------
Fix up freeing of kmalloc structures
Some paths free things twice, others free un-initialised values :-(
Not any more.
----------- Diffstat output ------------
./drivers/md/raid0.c | 17 ++++++++---------
1 files changed, 8 insertions(+), 9 deletions(-)
diff ./drivers/md/raid0.c~current~ ./drivers/md/raid0.c
--- ./drivers/md/raid0.c~current~ 2003-05-30 11:40:06.000000000 +1000
+++ ./drivers/md/raid0.c 2003-05-30 11:47:03.000000000 +1000
@@ -85,10 +85,8 @@ static int create_strip_zones (mddev_t *
conf->devlist = kmalloc(sizeof(mdk_rdev_t*)*
conf->nr_strip_zones*mddev->raid_disks,
GFP_KERNEL);
- if (!conf->devlist) {
- kfree(conf);
+ if (!conf->devlist)
return 1;
- }
memset(conf->strip_zone, 0,sizeof(struct strip_zone)*
conf->nr_strip_zones);
@@ -235,6 +233,8 @@ static int raid0_run (mddev_t *mddev)
goto out;
mddev->private = (void *)conf;
+ mddev->strip_zone = NULL;
+ mddev->devlist = NULL;
if (create_strip_zones (mddev))
goto out_free_conf;
@@ -273,7 +273,7 @@ static int raid0_run (mddev_t *mddev)
nb_zone*sizeof(struct strip_zone*));
conf->hash_table = kmalloc (sizeof (struct strip_zone *)*nb_zone, GFP_KERNEL);
if (!conf->hash_table)
- goto out_free_zone_conf;
+ goto out_free_conf;
size = conf->strip_zone[cur].size;
for (i=0; i< nb_zone; i++) {
@@ -296,12 +296,11 @@ static int raid0_run (mddev_t *mddev)
blk_queue_merge_bvec(&mddev->queue, raid0_mergeable_bvec);
return 0;
-out_free_zone_conf:
- kfree(conf->strip_zone);
- conf->strip_zone = NULL;
-
out_free_conf:
- kfree (conf->devlist);
+ if (conf->strip_zone)
+ kfree(conf->strip_zone);
+ if (conf->devlist)
+ kfree (conf->devlist);
kfree(conf);
mddev->private = NULL;
out:
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: 2.5.70-mm1 bootcrash, possibly RAID-1
2003-05-30 1:59 ` Neil Brown
@ 2003-05-31 16:13 ` Paul E. Erkkila
0 siblings, 0 replies; 29+ messages in thread
From: Paul E. Erkkila @ 2003-05-31 16:13 UTC (permalink / raw)
To: Neil Brown
Cc: Zwane Mwaikambo, Helge Hafting, William Lee Irwin III,
Andrew Morton, linux-kernel, linux-mm
With patch applied to lastest BK I get this on bootup.
(manual copy)
blk_queue_segment_boundary: set to minimum fff
raid1: raid set md0 active with 2 out of 2 mirrors
md: ... autorun DONE.
---------------[ cut here ] -------------
kernbel BUG at drivers/md/raid1.c:145!
invalid operand: 000 [#1]
CPU: 0
EIP: 0060:[<c025d7df>] Not tainted
EFLAGS: 00010097
EIP is at put_all_bios+0x59/0x85
eax: 00000000 ebx: 00000001 exc: 00000010 edx: f7ffb800
esi: f7d5ddb4 edi: 00000003 ebp: c036bdf8 esp: c036bde8
ds: 007 es: 007b ss:0068
Process swapper (pid: 0, threadinfo=c036a000 task=c02f3000)
Stack: f7fcf900 f7d80480 00000046 f7d5dd80 c036be18 c025d8fc f7d80480
f7d4dd80
00000000 f7d5dd80 00000001 0000000c c036be18 c025da43 f7d5dd80
f7f9f880
00000003 00000000 00000001 00000004 00000000 c18f5ch4 f7d6fce0
0000000c
Call Trace:
[<c025d8fc>] raid_end_bio_io+0x55/0x92
[<c025da43>] raid1_end_request+0x10a/0x196
[<c013042c>] mempool_free+0x32/0x65
[<c014a420>] bio_endio+0x55/0x7a
[<c01ef559>] __end_that_request_first+0x1f1/0x20d
[<c023c0a4>] ide_end_request+0x58/0x118
[<c024f3cb>] ide_dma_intr+0x9d/0xba
[<c023d43f>] ide_intr+0xb9/0x12e
[<c024f34e>] ide_dma_intr+0x0/0xba
[<c010c279>] handle_IRQ_event+0x3c/0xfd
[<c010c48f>] do_IRQ+0x80/0xd6
[<c0108be9>] default_idle+0x0/0x2c
[<c0108be9>] default_idle+0x0/0x2c
[<c010acd4>] common_interrupt+0x18/0x20
[<c0108be9>] default_idle+0x0/0x2c
[<c0108be9>] default_idle+0x0/0x2c
[<c0108c10>] default_idle+0x27/0x2c
[<c0108c81>] cpu_idle+0x31/0x3a
[<c0105000>] _stext+0x0/0x2a
[<c036c678>] start_kernel+0x152/0x177
[<c036c401>] unknown_bootoption+0x0/0xfa
Code: 0f 0b 91 00 85 96 2d c0 89 14 24 e8 7e c2 ee ff c7 06 00 00
<0>Kernel panic: Fatal exception in interrupt
In interrupt handler - not syncing
Neil Brown wrote:
>On Thursday May 29, zwane@linuxpower.ca wrote:
>
>
>>How does the following patch look for the double free.
>>
>>
>>
>
>Thanks. It is a good start, but there are other problems with freeing
>things on error paths. This patch should fix it all.
>
>NeilBrown
>
>--------------------------------------------
>Fix up freeing of kmalloc structures
>
>Some paths free things twice, others free un-initialised values :-(
>Not any more.
>
>
> ----------- Diffstat output ------------
> ./drivers/md/raid0.c | 17 ++++++++---------
> 1 files changed, 8 insertions(+), 9 deletions(-)
>
>diff ./drivers/md/raid0.c~current~ ./drivers/md/raid0.c
>--- ./drivers/md/raid0.c~current~ 2003-05-30 11:40:06.000000000 +1000
>+++ ./drivers/md/raid0.c 2003-05-30 11:47:03.000000000 +1000
>@@ -85,10 +85,8 @@ static int create_strip_zones (mddev_t *
> conf->devlist = kmalloc(sizeof(mdk_rdev_t*)*
> conf->nr_strip_zones*mddev->raid_disks,
> GFP_KERNEL);
>- if (!conf->devlist) {
>- kfree(conf);
>+ if (!conf->devlist)
> return 1;
>- }
>
> memset(conf->strip_zone, 0,sizeof(struct strip_zone)*
> conf->nr_strip_zones);
>@@ -235,6 +233,8 @@ static int raid0_run (mddev_t *mddev)
> goto out;
> mddev->private = (void *)conf;
>
>+ mddev->strip_zone = NULL;
>+ mddev->devlist = NULL;
> if (create_strip_zones (mddev))
> goto out_free_conf;
>
>@@ -273,7 +273,7 @@ static int raid0_run (mddev_t *mddev)
> nb_zone*sizeof(struct strip_zone*));
> conf->hash_table = kmalloc (sizeof (struct strip_zone *)*nb_zone, GFP_KERNEL);
> if (!conf->hash_table)
>- goto out_free_zone_conf;
>+ goto out_free_conf;
> size = conf->strip_zone[cur].size;
>
> for (i=0; i< nb_zone; i++) {
>@@ -296,12 +296,11 @@ static int raid0_run (mddev_t *mddev)
> blk_queue_merge_bvec(&mddev->queue, raid0_mergeable_bvec);
> return 0;
>
>-out_free_zone_conf:
>- kfree(conf->strip_zone);
>- conf->strip_zone = NULL;
>-
> out_free_conf:
>- kfree (conf->devlist);
>+ if (conf->strip_zone)
>+ kfree(conf->strip_zone);
>+ if (conf->devlist)
>+ kfree (conf->devlist);
> kfree(conf);
> mddev->private = NULL;
> out:
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: 2.5.70-mm1 bootcrash, possibly RAID-1
2003-05-28 22:59 ` 2.5.70-mm1 bootcrash, possibly RAID-1 Helge Hafting
2003-05-28 23:18 ` Andrew Morton
2003-05-28 23:30 ` Paul E. Erkkila
@ 2003-05-29 4:27 ` Alain Toussaint
2003-05-29 13:22 ` John Stoffel
3 siblings, 0 replies; 29+ messages in thread
From: Alain Toussaint @ 2003-05-29 4:27 UTC (permalink / raw)
To: linux-mm
> Unable to handle kernel paging request at virtual address 8a8a8ab6
> *pde=0 OOPS 0000 [#1]
> EIP at put_all_bios+0x47/0x80
> (edx was the register containing 8a8a8a8a)
> Process swapper pid=0 threadinfo c1352000 task=c13f52d0
I've seen something similar too when installing Gentoo on my box (stock
gentoo kernel 2.4.20 with the royal bunch of patch they put in),i was in the
bootstrap process building glibc,system is a Celery 566 with 512MB of ram (+
512MB of swap enabled during the install,don't think it was needed
though),the hard disk (maxtor 40GB) is hooked to a promise Ultra133TX2 card
but the dvd drive and the cd burner are hooked to the stock controller (Via
694Z mainboard),all are set to master,there's no slave device and the
computer has a gazillions fans making as much noise as a boeing 747 in order
to keep everything cool and i don't overclock.
Alain
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: 2.5.70-mm1 bootcrash, possibly RAID-1
2003-05-28 22:59 ` 2.5.70-mm1 bootcrash, possibly RAID-1 Helge Hafting
` (2 preceding siblings ...)
2003-05-29 4:27 ` Alain Toussaint
@ 2003-05-29 13:22 ` John Stoffel
3 siblings, 0 replies; 29+ messages in thread
From: John Stoffel @ 2003-05-29 13:22 UTC (permalink / raw)
To: Helge Hafting
Cc: William Lee Irwin III, Andrew Morton, linux-kernel, linux-mm, neilb
Helge> On Wed, May 28, 2003 at 04:35:44AM -0700, William Lee Irwin III wrote:
>>
>> Could you log this to serial and get the rest of the oops/BUG? If it's
>> where I think it is, I've been looking at end_page_writeback() and so
>> might have an idea or two.
Helge> I tried 2.5.70-mm1 on the dual celeron at home. This one has
Helge> scsi instead of ide, so I guess it is a RAID-1 problem.
Helge> This machine has root on raid-1 too. I believe there where
Helge> several oopses in a row, I captured all of the last one
Helge> thanks to a framebuffer with a small font. Here it is:
I've finally gotten 2.5.70-mm1 compiled and bootable on my system, but
with my /home being RAID1, I was getting crashes that looked alot like
this as well. This was a Dual PIII Xeon 550, with a mix of IDE and
SCSI drives. /home was on a pair of 18gb SCSI disks, RAID1.
I also had problems with the new AIC7xxx driver and had to drop back
to the old one to get a boot. I think. Lots and lots of confusion
here.
John
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
^ permalink raw reply [flat|nested] 29+ messages in thread