From: Dave Hansen <haveblue@us.ibm.com>
To: Andrew Morton <akpm@digeo.com>
Cc: linux-mm@kvack.org, Paul Larson <plars@linuxtestproject.org>
Subject: [PATCH] remove unnecessary PAE pgd set
Date: Wed, 30 Apr 2003 16:42:25 -0700 [thread overview]
Message-ID: <3EB05F61.5070404@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 444 bytes --]
With PAE on, there are only 4 PGD entries. The kernel ones never
change, so there is no need to copy them when a vmalloc fault occurs.
This was this was causing problems with the split pmd patches, but it is
still correct for mainline.
Tested with and without PAE. I ran it in a loop turning on and off 10
swap partitions, which is what excited the original bug.
http://bugme.osdl.org/show_bug.cgi?id=640
--
Dave Hansen
haveblue@us.ibm.com
[-- Attachment #2: vmal_fault-optimization-PAE-2.5.68-0.patch --]
[-- Type: text/plain, Size: 553 bytes --]
--- linux-2.5.68-vmal_fault/arch/i386/mm/fault.c.orig Wed Apr 30 13:36:49 2003
+++ linux-2.5.68-vmal_fault/arch/i386/mm/fault.c Wed Apr 30 13:36:18 2003
@@ -405,7 +405,15 @@
if (!pgd_present(*pgd_k))
goto no_context;
+ /*
+ * kernel pmd pages are shared among all processes
+ * with PAE on. Since vmalloc pages are always
+ * in the kernel area, this will always be a
+ * waste with PAE on.
+ */
+#ifndef CONFIG_X86_PAE
set_pgd(pgd, *pgd_k);
+#endif
pmd = pmd_offset(pgd, address);
pmd_k = pmd_offset(pgd_k, address);
next reply other threads:[~2003-04-30 23:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-30 23:42 Dave Hansen [this message]
2003-05-01 3:22 ` William Lee Irwin III
2003-05-01 3:39 ` Dave Hansen
2003-05-01 3:45 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB05F61.5070404@us.ibm.com \
--to=haveblue@us.ibm.com \
--cc=akpm@digeo.com \
--cc=linux-mm@kvack.org \
--cc=plars@linuxtestproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox