linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: Christoph Hellwig <hch@lst.de>
Cc: manfred@colorfullife.com, gerg@snapgear.com, linux-mm@kvack.org
Subject: Re: [PATCH][RFC] uClinux slab limits
Date: Wed, 13 Nov 2002 17:36:24 -0800	[thread overview]
Message-ID: <3DD2FE18.72968FEE@digeo.com> (raw)
In-Reply-To: <20021114020934.A17934@lst.de>

Christoph Hellwig wrote:
> 
> +#ifndef CONFIG_MMU
> +       CN("size-262144"),
> +       CN("size-524288"),
> +       CN("size-1048576"),
> +#ifdef CONFIG_LARGE_ALLOCS
> +       CN("size-2097152"),
> +       CN("size-4194304"),
> +       CN("size-8388608"),
> +       CN("size-16777216"),
> +       CN("size-33554432"),
> +#endif /* CONFIG_LARGE_ALLOCS */
> +#endif /* CONFIG_MMU */
>  };
>  #undef CN
> 

You could just do:

#if CONFIG_LARGEST_SLAB_ORDER >= 20
	CN("size-1048576"),
#endif
#if CONFIG_LARGEST_SLAB_ORDER >= 21
	CN("size-2097152"),
#endif
#if CONFIG_LARGEST_SLAB_ORDER >= 22
	CN("size-4194304"),
#endif

etcetera.


But I think it'd be better to just remove those statically initialised
tables and put a good old for-loop in kmem_cache_init().
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/

      reply	other threads:[~2002-11-14  1:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-14  1:09 Christoph Hellwig
2002-11-14  1:36 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DD2FE18.72968FEE@digeo.com \
    --to=akpm@digeo.com \
    --cc=gerg@snapgear.com \
    --cc=hch@lst.de \
    --cc=linux-mm@kvack.org \
    --cc=manfred@colorfullife.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox