From: Andrew Morton <akpm@digeo.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch] generic nonlinear mappings, 2.5.44-mm2-D0
Date: Tue, 22 Oct 2002 12:23:41 -0700 [thread overview]
Message-ID: <3DB5A5BD.D3E00B4A@digeo.com> (raw)
In-Reply-To: <20021022184938.A2395@infradead.org>
Christoph Hellwig wrote:
>
> On Tue, Oct 22, 2002 at 07:57:00PM +0200, Ingo Molnar wrote:
> > the attached patch (ontop of 2.5.44-mm2) implements generic (swappable!)
> > nonlinear mappings and sys_remap_file_pages() support. Ie. no more
> > MAP_LOCKED restrictions and strange pagefault semantics.
> >
> > to implement this i added a new pte concept: "file pte's". This means that
> > upon swapout, shared-named mappings do not get cleared but get converted
> > into file pte's, which can then be decoded by the pagefault path and can
> > be looked up in the pagecache.
> >
> > the normal linear pagefault path from now on does not assume linearity and
> > decodes the offset in the pte. This also tests pte encoding/decoding in
> > the pagecache case, and the ->populate functions.
>
> Ingo,
>
> what is the reason for that interface? It looks like a gross performance
> hack for misdesigned applications to me, kindof windowsish..
>
So that evicted pages in non-linear mappings can be reestablished
at fault time by the kernel, rather than by delegation to userspace
via SIGBUS.
We seem to have lost a pte_page_unlock() from fremap.c:zap_pte()?
I fixed up the ifdef tangle in there within the shpte-ng patch
and then put the pte_page_unlock() back.
I also added a page_cache_release() to the error path in filemap_populate(),
if install_page() failed.
The 2TB file size limit for mmap on non-PAE is a little worrisome.
I wonder if we can only instantiate the pte_file() bit if the
mapping is using MAP_POPULATE? Seems hard to do.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-10-22 19:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-22 17:57 Ingo Molnar
2002-10-22 17:49 ` Christoph Hellwig
2002-10-22 19:23 ` Andrew Morton [this message]
2002-10-22 20:27 ` Ingo Molnar
2002-10-22 20:38 ` Alan Cox
2002-10-22 20:42 ` Ingo Molnar
2002-10-22 21:18 ` Alan Cox
2002-10-23 19:09 ` Bryan O'Sullivan
2002-10-22 20:49 ` Ingo Molnar
2002-10-22 20:19 ` Ingo Molnar
2002-10-23 2:05 ` Andrea Arcangeli
2002-10-23 7:19 ` Ingo Molnar
2002-10-23 11:50 ` Andrea Arcangeli
2002-10-23 14:20 ` Ingo Molnar
2002-10-23 14:23 ` Andrea Arcangeli
2002-10-22 19:13 ` Rik van Riel
2002-10-22 22:27 ` David S. Miller
2002-10-22 22:56 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DB5A5BD.D3E00B4A@digeo.com \
--to=akpm@digeo.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox