From: Andrew Morton <akpm@digeo.com>
To: Badari Pulavarty <badari@us.ibm.com>
Cc: Chuck Lever <cel@citi.umich.edu>, linux-mm@kvack.org
Subject: Re: [PATCH] 2.5.38-mm3 : use struct file to call generic_file_direct_IO
Date: Thu, 26 Sep 2002 09:44:20 -0700 [thread overview]
Message-ID: <3D933964.91C114F4@digeo.com> (raw)
In-Reply-To: <OFA4BB5A35.3807A0D1-ON88256C40.00593B2F@boulder.ibm.com>
Badari Pulavarty wrote:
>
> Hi Andrew & Chuck,
>
> This patch looks good. As we discussed earlier, this breaks "raw" driver.
Yes, Chuck's patch is clearly the right thing to do. I got caught
out cheating :(
The problem was caused by the consolidation of the raw driver - it
does not have a file * for the target blockdev inode.
> I can fix it. Please let me know, if you want me to work on it.
>
OK, thanks. I guess we can either:
- Just create a temp struct file on the stack (bit risky)
- Change the raw device's userspace API and make raw bind to
fd's, not majors/minors
- Change rw_raw_dev to call inode->i_mapping->aops->direct_IO
directly.
The latter sounds suitable ;) I should have done that on
day one.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-09-26 16:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-26 16:13 Badari Pulavarty
2002-09-26 16:44 ` Andrew Morton [this message]
2002-09-26 19:08 ` Benjamin C.R. LaHaise
-- strict thread matches above, loose matches on Subject: below --
2002-09-26 15:47 Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D933964.91C114F4@digeo.com \
--to=akpm@digeo.com \
--cc=badari@us.ibm.com \
--cc=cel@citi.umich.edu \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox