From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF012C433FE for ; Tue, 1 Nov 2022 05:39:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED4B36B0072; Tue, 1 Nov 2022 01:39:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5E6D6B0073; Tue, 1 Nov 2022 01:39:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFE5D6B0074; Tue, 1 Nov 2022 01:39:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BC42C6B0072 for ; Tue, 1 Nov 2022 01:39:36 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8CEAC1605A9 for ; Tue, 1 Nov 2022 05:39:36 +0000 (UTC) X-FDA: 80083771152.19.F020F81 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf12.hostedemail.com (Postfix) with ESMTP id 4027B40003 for ; Tue, 1 Nov 2022 05:39:36 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id u8-20020a17090a5e4800b002106dcdd4a0so17890368pji.1 for ; Mon, 31 Oct 2022 22:39:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GooxocOMqoXlKVZTwGoGZ/Eyf8dLJyIprbhLabvf/YY=; b=bVUoBx6xICMR9Hhh1/Zth+k71EuBM78A0dyKnNRgRzmWnY9eaayexFtY5QGLbrjlTe 0ZTf6aVADDunFYrFPg2FPXZGMGCJXmCYeg9ZpFh98LV+LRkR3HHhBVqkHDag4oyNOvZe DBnxjxLFhfONizT+kOgUKdptg44w+1dgu1Li1t5BPZGZ9LnVYSmo8QPOCUF591qFWhnx s3Zc6J30F1AS5kfT+seGjeCK+JXJGr1hcC6N1L/mx1OJz3NiJOWiGHFR8TnvTXZGTa+Z s7nq+CqmoaSAT5nLaTFSpBs1RnpC6zj5ZAkdVr16+9nfltxneunAl3iK+N7NJdqvfV0C 9Npw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GooxocOMqoXlKVZTwGoGZ/Eyf8dLJyIprbhLabvf/YY=; b=FQP4JxShYyMn2r0sK7hV/uqc03w6rLyuaoNH4oAv6sfDHAI1/3rhnsYplVu/J7WJ39 OY4UBG83D5gE2WgQ+h9mm8Br7cc/ZLin3vH9Q6wcpJ0PAN2C2iMMltNh0eblMvZGx9fF TFp4o9m+1Lw8xt243LhpLroUak+RvO+SdCq8/0FkfR/Z64ss4fdPXBiBKKKtmwLvVX1t 2ncL4u37MDaY2WiYj6TXoLqmYQbGmo5WXhl4GLXB9ou9N7hyIeEdFs9h7theN4A6tEwq WreBGA4SGgpybAHh5dI/gpILaRNcyFFkVxLw+e1mCp3nOlKPuABtgX7ygpNX6Hl5m8n0 ocVQ== X-Gm-Message-State: ACrzQf1GhP+BWkB+rf+nGpbhuQnZPKp8whby8ARUPUufR88qn5bY414x DobGPaQTuQnICBmrriLsKM0= X-Google-Smtp-Source: AMsMyM4UVgMrxIzU+XbzR5BB5pUNNdkwI7lrtNtDtfuV+w2acIw49L5bZT7c6Hw0qNZZcClC+vJ9bw== X-Received: by 2002:a17:90a:2bc9:b0:212:8210:c92d with SMTP id n9-20020a17090a2bc900b002128210c92dmr18433376pje.38.1667281175018; Mon, 31 Oct 2022 22:39:35 -0700 (PDT) Received: from smtpclient.apple (c-24-6-216-183.hsd1.ca.comcast.net. [24.6.216.183]) by smtp.gmail.com with ESMTPSA id r10-20020a170902c60a00b0017f48a9e2d6sm5345373plr.292.2022.10.31.22.39.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 31 Oct 2022 22:39:34 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [PATCH RFC 10/10] mm/hugetlb: Comment at rest huge_pte_offset() places From: Nadav Amit In-Reply-To: <20221030213045.335680-1-peterx@redhat.com> Date: Mon, 31 Oct 2022 22:39:33 -0700 Cc: Linux-MM , kernel list , James Houghton , Mike Kravetz , David Hildenbrand , Andrea Arcangeli , Rik van Riel , Andrew Morton , Muchun Song , Miaohe Lin Content-Transfer-Encoding: quoted-printable Message-Id: <3D896ED0-5600-4E55-8509-3F0E355FF692@gmail.com> References: <20221030212929.335473-1-peterx@redhat.com> <20221030213045.335680-1-peterx@redhat.com> To: Peter Xu X-Mailer: Apple Mail (2.3696.120.41.1.1) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667281176; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GooxocOMqoXlKVZTwGoGZ/Eyf8dLJyIprbhLabvf/YY=; b=iZGry2OcfqlBDOM6Bi9c1BHrKncilncYKDfIJ1Z/f6qSAXgc8dBNkUi7IEwi0oXOD+Hx5t eMtCGJjO+t4nLU79GDR9jVJpX7/qPLSSvMulgrtz+nREX/qZcc814Gut1OsBwgsoLViR2L m+gx9C4tmD+B9uy0KbaZLsYEpllV000= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=bVUoBx6x; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667281176; a=rsa-sha256; cv=none; b=XzzNGY5F53nGFuHhcR2h8fPSrUZXkJP+Jwh1Rcimy76HZSpyz4LxFHIR7Qb8iyQxp2foaL DSUHAlVePBWDa6q6nppg08kyqv8H/wX8R1L0adlTZznGzTfXa8DlDx5ghy6nac7tU3VE9B TQWpziEM+BND/pXNlYw5C1Gxny8N9Ac= X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4027B40003 X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=bVUoBx6x; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com X-Stat-Signature: azfrhe4e5xppz3ur3m6gp1kg1c7xjfth X-HE-Tag: 1667281176-351455 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Oct 30, 2022, at 2:30 PM, Peter Xu wrote: > + /* With vma lock held, safe without RCU */ > src_pte =3D huge_pte_offset(src, addr, sz); Just another option to consider: you can create an inline function huge_pte_offset_locked_mm(), which would do the lockdep_assert_held_*(). I personally would prefer it, since it would clarify exactly the lock = you care about and "make the code document itself=E2=80=9D. =20=