From: Andrew Morton <akpm@zip.com.au>
To: Robert Love <rml@tech9.net>
Cc: torvalds@transmeta.com, riel@conectiva.com.br,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] updated low-latency zap_page_range
Date: Wed, 24 Jul 2002 18:19:27 -0700 [thread overview]
Message-ID: <3D3F521F.ECB4DBC4@zip.com.au> (raw)
In-Reply-To: <1027559785.17950.3.camel@sinai>
Robert Love wrote:
>
> ...
> I hope it compiles to nothing! There is a false in an if... oh, wait,
> to preserve possible side-effects gcc will keep the need_resched() call
> so I guess we should reorder it as:
>
> if (preempt_count() == 1 && need_resched())
>
> Then we get "if (0 && ..)" which should hopefully be evaluated away.
> Then the inline is empty and nothing need be done.
I think someone changed the definition of preempt_count()
while you weren't looking.
Plus it's used as an lvalue :(
-
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-07-25 1:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-25 0:29 Robert Love
2002-07-25 0:45 ` Andrew Morton
2002-07-25 1:16 ` Robert Love
2002-07-25 1:19 ` Andrew Morton [this message]
2002-07-25 1:21 ` Linus Torvalds
2002-07-25 1:29 ` Robert Love
2002-07-25 1:39 ` george anzinger
2002-07-25 5:19 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D3F521F.ECB4DBC4@zip.com.au \
--to=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@conectiva.com.br \
--cc=rml@tech9.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox