From: Andrew Morton <akpm@zip.com.au>
To: Robert Love <rml@tech9.net>
Cc: torvalds@transmeta.com, riel@conectiva.com.br,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] updated low-latency zap_page_range
Date: Wed, 24 Jul 2002 17:45:35 -0700 [thread overview]
Message-ID: <3D3F4A2F.B1A9F379@zip.com.au> (raw)
In-Reply-To: <1027556975.927.1641.camel@sinai>
Robert Love wrote:
>
> ...
> +static inline void cond_resched_lock(spinlock_t * lock)
> +{
> + if (need_resched() && preempt_count() == 1) {
> + _raw_spin_unlock(lock);
> + preempt_enable_no_resched();
> + __cond_resched();
> + spin_lock(lock);
> + }
> +}
Maybe I'm being thick. How come a simple spin_unlock() in here
won't do the right thing?
And this won't _really_ compile to nothing with CONFIG_PREEMPT=n,
will it? It just does nothing because preempt_count() is zero?
-
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-07-25 0:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-25 0:29 Robert Love
2002-07-25 0:45 ` Andrew Morton [this message]
2002-07-25 1:16 ` Robert Love
2002-07-25 1:19 ` Andrew Morton
2002-07-25 1:21 ` Linus Torvalds
2002-07-25 1:29 ` Robert Love
2002-07-25 1:39 ` george anzinger
2002-07-25 5:19 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D3F4A2F.B1A9F379@zip.com.au \
--to=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@conectiva.com.br \
--cc=rml@tech9.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox