From: Andrew Morton <akpm@zip.com.au>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Rik van Riel <riel@conectiva.com.br>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH][RFT](2) minimal rmap for 2.5 - akpm tested
Date: Sat, 06 Jul 2002 13:00:42 -0700 [thread overview]
Message-ID: <3D274C6A.C6E23CAA@zip.com.au> (raw)
In-Reply-To: <Pine.LNX.4.44.0207061205001.1157-100000@home.transmeta.com>
Linus Torvalds wrote:
>
> On Fri, 5 Jul 2002, Andrew Morton wrote:
> >
> > The box died, but not due to rmap. We have a lock ranking
> > bug:
> >
> > do_exit
> > ->mmput
> > ->exit_mmap page_table_lock
> > ->removed_shared_vm_struct
> > ->lock_vma_mappings i_shared_lock
>
> I _think_ we should just move the remove_shared_vm_struct() down into the
> case where we're closing the mapping, ie something like the appended.
>
> That way we _only_ do the actual page table stuff under the page table
> lock, and do all the generic VM/FS stuff outside the lock.
>
> Comments?
That is basically what do_munmap() does. But I'm quite unfamiliar
with the locking in there.
-
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-07-06 20:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-06 5:31 Rik van Riel
2002-07-06 6:28 ` Andrew Morton
2002-07-06 19:06 ` Linus Torvalds
2002-07-06 20:00 ` Andrew Morton [this message]
2002-07-06 20:11 ` Linus Torvalds
2002-07-10 17:35 ` Sebastian Droege
2002-07-10 20:42 ` Rik van Riel
2002-07-10 21:56 ` Daniel Phillips
2002-07-11 6:47 ` Jens Axboe
2002-07-11 9:58 ` Daniel Phillips
2002-07-11 10:08 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D274C6A.C6E23CAA@zip.com.au \
--to=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@conectiva.com.br \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox