From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <3D268E19.B68559F6@zip.com.au> Date: Fri, 05 Jul 2002 23:28:41 -0700 From: Andrew Morton MIME-Version: 1.0 Subject: Re: [PATCH][RFT](2) minimal rmap for 2.5 - akpm tested References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Rik van Riel Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds List-ID: Rik van Riel wrote: > > Hi, > > Almost the same patch as before, except this one has had > a few hours of testing by Andrew Morton and two bugs have > been ironed out, most notably the truncate_complete_page() > race. This patch is probably safe since Andrew got bored > when no new bugs showed up ... > The box died, but not due to rmap. We have a lock ranking bug: do_exit ->mmput ->exit_mmap page_table_lock ->removed_shared_vm_struct ->lock_vma_mappings i_shared_lock versus do_truncate ->notify_change ->inode_setattr ->vmtruncate i_shared_lock ->vmtruncate_list ->zap_page_range page_table_lock It seems that in 2.5.16, a call to remove_shared_vm_struct() was added to exit_mmap(), inside mm->page_table_lock. That ranking conflicts with truncate. - -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/