From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B652C433DF for ; Wed, 3 Jun 2020 17:35:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D4E572053B for ; Wed, 3 Jun 2020 17:35:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="wLLqJn8f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4E572053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6BA1280007; Wed, 3 Jun 2020 13:35:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66AA58E0006; Wed, 3 Jun 2020 13:35:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5589E80007; Wed, 3 Jun 2020 13:35:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id 3B8838E0006 for ; Wed, 3 Jun 2020 13:35:47 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E490D1805B344 for ; Wed, 3 Jun 2020 17:35:46 +0000 (UTC) X-FDA: 76888603092.03.toys06_6be8baef0b011 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 1902A4FBD66 for ; Wed, 3 Jun 2020 17:35:42 +0000 (UTC) X-HE-Tag: toys06_6be8baef0b011 X-Filterd-Recvd-Size: 4503 Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Wed, 3 Jun 2020 17:35:41 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 053HWUwW142658; Wed, 3 Jun 2020 17:35:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2020-01-29; bh=2vDnYwiwWSpc/stQ6kyhuWKE78Im7ncdpWFFojdtFCs=; b=wLLqJn8fgRU5VxE40K0lOkZTmldqkbLAgCWZ6joSGXsqZF+ToCESUpXaYWi7PM8LMFtD sPFOnGu21ByiHGQ3D5ZYHFvkG69mI5VmnBcURH6mFySkRCkLj97nh5zYU9Hfa4ghKjFJ KT77AG+sy1iQR9omZ51y8EYMCYWalDMaNA4UJ5iniBhUSNhBgHRMoR7M9PYvWdTv0GLh y99pgimqECeSEedZGm4Ihbq25MJoHwrltt4oeloQsUyyaKvd/WA/BQKfAE+IdvkQqVqP vy1o6NCuI7T2cy3HU/H0sJx7dWcO83jg0ktA7wyBHxolrh/1ML+mRpp4WHqwQN3yljT6 9g== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 31bfemah7g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 03 Jun 2020 17:35:31 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 053HXJX5192883; Wed, 3 Jun 2020 17:35:31 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 31c1e0cdhx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Jun 2020 17:35:31 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 053HZP4V013618; Wed, 3 Jun 2020 17:35:25 GMT Received: from [192.168.0.110] (/73.243.10.6) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 03 Jun 2020 10:35:25 -0700 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [PATCH] vmalloc: Convert to XArray From: William Kucharski In-Reply-To: <20200603171448.5894-1-willy@infradead.org> Date: Wed, 3 Jun 2020 11:35:24 -0600 Cc: Andrew Morton , linux-mm@kvack.org Content-Transfer-Encoding: quoted-printable Message-Id: <3CE9C10C-2C1E-4363-94A6-BD4724881926@oracle.com> References: <20200603171448.5894-1-willy@infradead.org> To: Matthew Wilcox X-Mailer: Apple Mail (2.3608.80.23.2.2) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9641 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 adultscore=0 suspectscore=2 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006030136 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9641 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=2 mlxlogscore=999 priorityscore=1501 bulkscore=0 phishscore=0 clxscore=1011 impostorscore=0 adultscore=0 spamscore=0 mlxscore=0 lowpriorityscore=0 cotscore=-2147483648 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006030136 X-Rspamd-Queue-Id: 1902A4FBD66 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Jun 3, 2020, at 11:14 AM, Matthew Wilcox = wrote: >=20 [ ... snip ... ] > - err =3D radix_tree_preload(gfp_mask); > - if (unlikely(err)) { > - kfree(vb); > - free_vmap_area(va); > - return ERR_PTR(err); > - } > - > vaddr =3D vmap_block_vaddr(va->va_start, 0); > spin_lock_init(&vb->lock); > vb->va =3D va; > @@ -1594,11 +1586,12 @@ static void *new_vmap_block(unsigned int = order, gfp_t gfp_mask) > INIT_LIST_HEAD(&vb->free_list); >=20 > vb_idx =3D addr_to_vb_idx(va->va_start); > - spin_lock(&vmap_block_tree_lock); > - err =3D radix_tree_insert(&vmap_block_tree, vb_idx, vb); > - spin_unlock(&vmap_block_tree_lock); > - BUG_ON(err); > - radix_tree_preload_end(); > + err =3D xa_insert(&vmap_blocks, vb_idx, vb, gfp_mask); > + if (err) { > + kfree(vb); > + free_vmap_area(va); > + return ERR_PTR(err); > + } >=20 Should the "(err)" here be "unlikely(err)" as the radix tree version = was? Nice change and simplifies the code quite a bit. Reviewed-by: William Kucharski =