Re: [PATCH] rmap 13a

[Roman Zippel <zippel@linux-m68k.org>]

Hi,

William Lee Irwin III wrote:

> > You should not only look at the i386 code, if you want to create generic
> > functions.
> 
> It's not only i386. Other architectures are able to do likewise if
> they satisfy the preconditions. And this is exactly one of four
> variations, where all four together are able to handle all cases.
> (In fact, just reverting to B works as a catch-all.)

Your preconditions were no CONFIG_DISCONTIGMEM and no CONFIG_HIGHMEM.
This is true for m68k, but it still breaks every single of your
assumptions, but even on other archs where do these preconditions
require physical memory to start at 0?

> There doesn't seem to be enough depth to this subject to merit this
> much discussion. Are we speaking at cross-purposes? Since I wrote a
> bit of this, is there an issue you're having you'd like me to address?
> I have a sun3 that's booted Linux in the past, so I might be able to
> reproduce m68k-specific issues that arise.

It's really not m68k specific. You are trying to generalize a very small
part of the whole problem. First you only take some special cases (A.
and B.) and the rest was completely arch specific so far. You have to
define the complete model of how virtual and physical addresses and the
pgdat/index tuple relate to each other, before you can generalize
something of it. So far it was completely up to the archs to define this
relationship with only little assumptions from the generic code.

bye, Roman
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/