From: Roman Zippel <zippel@linux-m68k.org>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Rik van Riel <riel@conectiva.com.br>,
Samuel Ortiz <sortiz@dbear.engr.sgi.com>,
linux-mm@kvack.org
Subject: Re: [PATCH] rmap 13a
Date: Thu, 09 May 2002 00:34:34 +0200 [thread overview]
Message-ID: <3CD9A7FA.5967F675@linux-m68k.org> (raw)
In-Reply-To: <20020508213452.GJ15756@holomorphy.com>
Hi,
William Lee Irwin III wrote:
> A:
> static inline void *page_address(struct page *page)
> {
> return __va((page - mem_map) << PAGE_SHIFT);
> }
This is very broken.
> If table lookup is wanted, I feel that should also be a generic option.
> There is nothing inherently architecture-specific about using a table-
> driven method of calculating page_address().
Archs already do the kaddr->node lookup. Archs setup the virtual mapping
and the pgdat nodes, they know best how they are layed out. Why do you
want to generalize this?
bye, Roman
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-05-08 22:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-07 2:17 Rik van Riel
2002-05-07 17:37 ` Christoph Hellwig
2002-05-07 18:03 ` William Lee Irwin III
2002-05-08 11:06 ` Samuel Ortiz
2002-05-08 11:13 ` William Lee Irwin III
2002-05-08 13:40 ` Rik van Riel
2002-05-08 18:21 ` Roman Zippel
2002-05-08 21:34 ` William Lee Irwin III
2002-05-08 22:34 ` Roman Zippel [this message]
2002-05-08 22:42 ` William Lee Irwin III
2002-05-08 22:50 ` William Lee Irwin III
2002-05-08 23:26 ` Roman Zippel
2002-05-09 1:29 ` William Lee Irwin III
2002-05-09 12:33 ` Roman Zippel
2002-05-09 14:09 ` William Lee Irwin III
2002-05-09 15:36 ` Roman Zippel
2002-05-09 17:42 ` William Lee Irwin III
2002-05-09 21:45 ` Roman Zippel
2002-05-09 23:13 ` William Lee Irwin III
2002-05-10 11:37 ` Roman Zippel
2002-05-10 16:28 ` William Lee Irwin III
2002-05-10 19:48 ` Roman Zippel
2002-05-08 21:50 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CD9A7FA.5967F675@linux-m68k.org \
--to=zippel@linux-m68k.org \
--cc=hch@infradead.org \
--cc=linux-mm@kvack.org \
--cc=riel@conectiva.com.br \
--cc=sortiz@dbear.engr.sgi.com \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox