From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4FCBC7EE30 for ; Thu, 29 Aug 2024 07:26:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FBD46B00A3; Thu, 29 Aug 2024 03:26:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55D8F6B00A0; Thu, 29 Aug 2024 03:26:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FE8D6B00A3; Thu, 29 Aug 2024 03:26:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1FEE36B009D for ; Thu, 29 Aug 2024 03:26:04 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C6C08A0A8B for ; Thu, 29 Aug 2024 07:26:03 +0000 (UTC) X-FDA: 82504449006.07.BB46161 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) by imf14.hostedemail.com (Postfix) with ESMTP id 0EB90100004 for ; Thu, 29 Aug 2024 07:26:00 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XnC+ifnJ; spf=pass (imf14.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.186 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724916272; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I5ri7U3ICw+kQAJ41Z0llXmXtxn3eNpISSEiLweTrSg=; b=uTiVKYi0B/ZjHL9wtxqMi9vkquxgEqfF8i+QJGPLOwaR2csB5b0aof9uQFMhINe1ctoo0e DEUVbLaPu2T5TVssXOvN1xdn6T4S0YE67MBYZy86egxVvcqyaeO0KMw7Sj82PvPnC3wbL4 D/qfdSUOcTRKKLOB2CTwg9Ao/aLcs/U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724916272; a=rsa-sha256; cv=none; b=uoqRSjh2Bne8Ix1iu/UJ78q3jqB5alTZ5dslbFryOyqs70WC+OY0KTArZJFFco3Myqp0lC itQp3EuLpbE521G+wBdakCYoJZo4kWBTc+I7seg8dcEQMBN1tnnsJPnsIx1jTwY1MmPWy5 LgTjCHzRXxXo5qRHLgQy/tJEJrQzrCk= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XnC+ifnJ; spf=pass (imf14.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.186 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1724916359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I5ri7U3ICw+kQAJ41Z0llXmXtxn3eNpISSEiLweTrSg=; b=XnC+ifnJTUWJgifpFgmnQKUN1iA51s8smDtrDWc9xoYV0r2DvZRun/a80GBJIS/z8i5FQF +wZ5qMlmMJ+IFqorb4b4mjYQms1OtQTVe4PV36YN4amK8vx3MnqdJIgVq6RFI7WVKKQhOs 08q3auveABGgxrlfI4bi/MoSiViz4lQ= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: [PATCH v2 05/14] mm: khugepaged: __collapse_huge_page_swapin() use pte_offset_map_ro_nolock() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <2b7dceaa12da273c6decf92e3bf2ebc4f4e85ec5.1724310149.git.zhengqi.arch@bytedance.com> Date: Thu, 29 Aug 2024 15:25:19 +0800 Cc: David Hildenbrand , Hugh Dickins , Matthew Wilcox , "Vlastimil Babka (SUSE)" , Andrew Morton , Mike Rapoport , vishal.moola@gmail.com, peterx@redhat.com, ryan.roberts@arm.com, christophe.leroy2@cs-soprasteria.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Content-Transfer-Encoding: 7bit Message-Id: <3BAB5012-B8A5-4DFF-9CAB-31D44AEEB4F4@linux.dev> References: <2b7dceaa12da273c6decf92e3bf2ebc4f4e85ec5.1724310149.git.zhengqi.arch@bytedance.com> To: Qi Zheng X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0EB90100004 X-Stat-Signature: zzm97qk7nn7mts9feasz5cgehn3t93zu X-HE-Tag: 1724916360-317804 X-HE-Meta: U2FsdGVkX1+55LTwDPb5KTCbY9dBcCKhDzbwk2Q1y1G6CydQI5ufB40gVqxcrowctQdt95fLLCAR1SOASU6/jEUtk1YlhenuAAOEgo63trky2Gjpfuq+d/rEuLsYY7zNkpLciECwcQcEOVqb3gKGJK3Dt9/OMW9LzhjeEjDi5+kL8pQhCjZ3uXW2tpX/bp3kzHtf8ll5eWoxON0EFegJheLneYdl0+P1c955DOHoRKzvuErlrbAVYWmSUeNCN2vkWfgGiSU9cdnh7L44TjIYfqYLLYDYOdst8prKulXzZTswgn/sVGquMZ6YJfZzbP95b1qG84/a/i9Jgenz2roTRQ0q3i9RUT7TvfevHkSAqugxufR+LLq1+zBCRw5vFWd5pa+jwCk23wmL3i56goJRO7/e9/U4ZdALlk0XwsVceoHpc/KX5dimLgGafQMfVAXw7N9+Wz8FkCLcYtL/KzvBK7D0hs4e3OzVy1S91dOG8eneOJW5tkjXecJBJpyuICLyId3i99y6gFnhUHhg2futsTcuiIiMPEN1Q90VMm9VCDW+t0yp8rDzlI1lPfEaU7odDLw5sb3540JTRB6KijDlSc1ex0NcuMgld0DXH2IbbCAZ2kubPjGe6gLooH/4xCRzjziWa6EVtNJEa06TmeZRb3DIwNbxDgZWFYSmKwuh8TAZt8JOtN1BoDcyqM+DAgNyYSlkl5bv72tpjSJdjqYHnvh9mnoCpL+ldSqB9Js0PogGujxejmyrsGZ1j+GF7VMXJ2u5Iq8TvPQr5w4e0wlGAOpSm4vepWDHSDgwlN1ypvgQWvwRCcPeJxkzvKz0ZLOw+TvStBawm25hzo6orzKlEB0my/uDPnFHvn0I4wkm5jIbSMDX6Q1Hwr8QQetihFhPFTv0zIolk9sOeUVV7CzoTmcBrKguFjUkh19IOlHMqSiBXFvc8zEhSy4J83z4hXzKdxV9DEaB30Dt3O8Xa40 XQlbT+8Z llQLDF19MKmU8DzH4WPY0OWxqGMfgUwJ8mUl2oCn7DmKbhHUPXRuEWAnsw9aqgUFEFMAmFmBaw1NzZmYwa60ao1tjXR5GY7b2oE5SdFZaOkdVjatAro6wPUgL4VaXs270NtPCKH2lLZkOiZu2HZRGE9rh1vlp4RK0HxW7ZnCxAXWFK7MgY/czSrHlk6uLAAw1pvJnpQyEy67zL+bbNrypsAU4tsMgtwaRVvuzbItjW7Gr3yUMNsNoiYOBjWqYR+IMCTS/tjy6mm6A2Zq72wotC8HVBkNmewpdDt99txayzrGFYBzvpl0x+Wlaqboi+rlttmnyoOIH4tO2xhuoO/ihyj6RhEkmIePfigfN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Aug 22, 2024, at 15:13, Qi Zheng wrote: > > In __collapse_huge_page_swapin(), we just use the ptl for pte_same() check > in do_swap_page(). In other places, we directly use pte_offset_map_lock(), > so convert it to using pte_offset_map_ro_nolock(). > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song