linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Muchun Song <muchun.song@linux.dev>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Muchun Song <songmuchun@bytedance.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Nhat Pham <nphamcs@gmail.com>,
	Linux Memory Management List <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	Shakeel Butt <shakeel.butt@linux.dev>
Subject: Re: [PATCH] mm: list_lru: fix UAF for memory cgroup
Date: Thu, 1 Aug 2024 10:42:02 +0800	[thread overview]
Message-ID: <3AA53CB7-1E21-4B79-8BA9-B1F40D3E15DF@linux.dev> (raw)
In-Reply-To: <20240731132825.1fb29122d35997a425368b32@linux-foundation.org>



> On Aug 1, 2024, at 04:28, Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> On Thu, 18 Jul 2024 16:36:07 +0800 Muchun Song <songmuchun@bytedance.com> wrote:
> 
>> The mem_cgroup_from_slab_obj() is supposed to be called under rcu
>> lock or cgroup_mutex or others which could prevent returned memcg
>> from being freed. Fix it by adding missing rcu read lock.
>> 
> 
> Well I grabbed this, but the review led me to expect a v2.

Will do.

> 
> Should it have cc:stable?

Yes.



      reply	other threads:[~2024-08-01  2:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-18  8:36 Muchun Song
2024-07-18 10:30 ` Vlastimil Babka
2024-07-18 11:20   ` Muchun Song
2024-07-23 11:23     ` Muchun Song
2024-07-23 17:52 ` Shakeel Butt
2024-07-24  0:45 ` Andrew Morton
2024-07-24  2:23   ` Muchun Song
2024-07-31 10:06     ` Vlastimil Babka (SUSE)
2024-08-01  2:42       ` Muchun Song
2024-07-31 20:28 ` Andrew Morton
2024-08-01  2:42   ` Muchun Song [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3AA53CB7-1E21-4B79-8BA9-B1F40D3E15DF@linux.dev \
    --to=muchun.song@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nphamcs@gmail.com \
    --cc=shakeel.butt@linux.dev \
    --cc=songmuchun@bytedance.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox