From: David Mansfield <lkml@dm.ultramaster.com>
To: Rik van Riel <riel@conectiva.com.br>
Cc: "Alan Cox" <alan@lxorguk.ukuu.org.uk>,
linux-mm@kvack.org, "XosÉ Vázquez" <xose@smi-ps.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] oom-killer trigger
Date: Thu, 01 Mar 2001 17:51:45 -0500 [thread overview]
Message-ID: <3A9ED281.90C5F7CB@dm.ultramaster.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0103011904140.1304-100000@duckman.distro.conectiva>
>
> 1. the OOM killer never triggers if we have > freepages.min
> of free memory
> 2. __alloc_pages() never allocates pages to < freepages.min
> for user allocations
>
> ==> the OOM killer never gets triggered under some workloads;
> the system just sits around with nr_free_pages == freepages.min
>
> The patch below trivially fixes this by upping the OOM kill limit
> by a really small number of pages ...
> + if (nr_free_pages() > freepages.min + 4)
Call me stupid, but why not just change the > to >= (or < to <=) rather
than introducing a magic number (4). Or at least make the magic number
interesting, like:
+ if (nr_free_pages() > freepages.min + 42)
:-)
Thanks for the bugfix,
David
--
David Mansfield (718) 963-2020
david@ultramaster.com
Ultramaster Group, LLC www.ultramaster.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
prev parent reply other threads:[~2001-03-01 22:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-01 22:31 Rik van Riel
2001-03-01 22:51 ` David Mansfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A9ED281.90C5F7CB@dm.ultramaster.com \
--to=lkml@dm.ultramaster.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@conectiva.com.br \
--cc=xose@smi-ps.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox