From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F23AAC001DC for ; Wed, 26 Jul 2023 07:05:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7257E900002; Wed, 26 Jul 2023 03:05:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6AE0A8D0001; Wed, 26 Jul 2023 03:05:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5011F900002; Wed, 26 Jul 2023 03:05:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3C9828D0001 for ; Wed, 26 Jul 2023 03:05:12 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0B6D0A013B for ; Wed, 26 Jul 2023 07:05:12 +0000 (UTC) X-FDA: 81052876464.23.BB27CA8 Received: from out-9.mta1.migadu.com (out-9.mta1.migadu.com [95.215.58.9]) by imf22.hostedemail.com (Postfix) with ESMTP id 3A27CC000E for ; Wed, 26 Jul 2023 07:05:09 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=USoqEnOQ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.9 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690355110; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KXYamYs9irq65yhoLRu1td82YuFMeMDqOuwaU+oDyHM=; b=aIfB0ekVx5eUVHz34TbTPxHgBrSCZD526dTvFpY/Kr5AcJNC5UbgLNw6PniHwT4HLSHOvl pkScIZqTCwIX8/kwrIB8eJYaqHOnR2dJMDzTo+xxbZuvmdFEPDlhiPzfcqMwsqneQ54Isv D2yXRcZv6V9Rm0fajYqFIkBVo2KAHeo= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=USoqEnOQ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.9 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690355110; a=rsa-sha256; cv=none; b=fBRbBufLvOfK1Va8yI8j8Ocpp3ccILoy5e1208CbQfhvJBJomdcIRhEC2DRslptgx1/FZP gcn17GBgCY8TYmejXDLJuvcbDPP/pQcBqmGqvDHTg3ZVYDWQ1Bg4N1qzFXtQDc7MC3zaXr nP4DyifiaXRuya4GjeiHik09FMRNr78= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1690355108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KXYamYs9irq65yhoLRu1td82YuFMeMDqOuwaU+oDyHM=; b=USoqEnOQU6eM3+N9zIAHCDwhNC+8+UNIWLHIgerhexBlGJCaVmSRSO1wU4o3mjHNGYO9Rs DYRZMApHrS1Pjvb6NJH1mJ50Vk6voJ6kQPH4oorM80xUHt6/RAFEITooiN15iQlceLlIh+ 2SDmjYt2iC3yWxkOb7vPU57vNB82awk= MIME-Version: 1.0 Subject: Re: [PATCH v2 17/47] rcu: dynamically allocate the rcu-lazy shrinker X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20230724094354.90817-18-zhengqi.arch@bytedance.com> Date: Wed, 26 Jul 2023 15:04:30 +0800 Cc: Andrew Morton , david@fromorbit.com, tkhai@ya.ru, Vlastimil Babka , Roman Gushchin , djwong@kernel.org, Christian Brauner , "Paul E. McKenney" , tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <3A164818-56E1-4EB4-A927-1B2D23B81659@linux.dev> References: <20230724094354.90817-1-zhengqi.arch@bytedance.com> <20230724094354.90817-18-zhengqi.arch@bytedance.com> To: Qi Zheng X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 3A27CC000E X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: p1nfafcd4bdmti53whsxoouag3x1b8z5 X-HE-Tag: 1690355109-870724 X-HE-Meta: U2FsdGVkX185RF+Gzr4XXeixDXXvxMUtjw52CHxubXKOCr9nVXGV7H5aSovJIGuhrznbEsAbZmjYDRscOg/e6PRP4OTbEveQmiD8/5T9EBoNiARlw3+OmyCDzGlrv3B1xD0L0Vv9SDh/6Xa3SKXaKLHerGqlZ/qDTUsjXt8BMXIt6HynKRHoCW1ArH+ou+Qba/e7vtFKYWAXVOOo4GWYpvWdIoSaLmuigvE2Zll9Bt0YXXULrb2ThinH600yK7xh1J3B/kxRnSDjNmS1l2u+WnAdNj2JAcZJFMiWt1gtW39glbCQLrCWZY/tXzky/hLv6w/yTD2j0Ut71rOEaKAdEogF5bTbZ28W6+eth5YmMKdvspHm2XwRSe9RDeRnKn+be6X2fqjqtQ2G7kS58cI8obe8mjSyUsnJgk1D5X/b/CXxf1mJFjJhn1tPjHT8xeRCUP2Oa5F1Y9OhtMsmU1UACnNNCqit05ftD+hW66DJHKFD7bzQpdz30DaI/ZzH+HdMjtOm1KirNbN542m/MdST0wJf7UHxEom9Z2dgwIxO+SmNaLwwCHx3kMfMm3zR0jrfr687R4W8i8zMHNrs3L64hQzKM1tY/gI2t/k7D9kVcQprFNwpHOmrsRSkgm1ovYCSktA2KuUZRtvjhr68Iw0tM1M5JC7bUnNe4hqtAOgwiUbprLdQI2yMyupO22t8s1/2sVbnQqVzemRzMjmk8+U6RgWdBtxEjV1oSAhuXYSJ53Yt4pWOFUvib0ySqnCSDyQrnEqcrllKwg+b7Aiu9eIE32EgsO35isFpZEaNSZ8mySqewvHer8Sqz7Z0D6WZYgImEA/Eu+gCJ0dFPJkCZtkKOy3LQAzQtCLmfOSLLW9Wy4WKwwLLO4FBHQ1srvd+M+4TGAYmF1sRkQ2cLCOTOsqgmTvtBc1VTC36YOoisM7ZFSCugLDCsq/DL/IjeAMjMbMlcV+Biv7LPPUNc3HTJoq ZsC9Th+D KM7oNIc9ciiJKF7WvL7jQcI3UJETHaH/4ZtIhKpsD0YymwDeO8Yazes492qJYgL+TCOL42SxcSaArDfYqI7F3YPSjmABI9EKMWOwXB8c5CuhAY3TcpmigbKQvKAtp5pDTvFAiF3zECWCGc+jH7vbLfsWF9w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Jul 24, 2023, at 17:43, Qi Zheng = wrote: >=20 > Use new APIs to dynamically allocate the rcu-lazy shrinker. >=20 > Signed-off-by: Qi Zheng > --- > kernel/rcu/tree_nocb.h | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-) >=20 > diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h > index 43229d2b0c44..919f17561733 100644 > --- a/kernel/rcu/tree_nocb.h > +++ b/kernel/rcu/tree_nocb.h > @@ -1397,12 +1397,7 @@ lazy_rcu_shrink_scan(struct shrinker *shrink, = struct shrink_control *sc) > return count ? count : SHRINK_STOP; > } >=20 > -static struct shrinker lazy_rcu_shrinker =3D { > - .count_objects =3D lazy_rcu_shrink_count, > - .scan_objects =3D lazy_rcu_shrink_scan, > - .batch =3D 0, > - .seeks =3D DEFAULT_SEEKS, > -}; > +static struct shrinker *lazy_rcu_shrinker; Seems there is no users of this variable, maybe we could drop this.