From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1A25C32771 for ; Sun, 25 Sep 2022 01:43:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3B4D8E0019; Sat, 24 Sep 2022 21:43:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EEA3B8E0007; Sat, 24 Sep 2022 21:43:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB1BE8E0019; Sat, 24 Sep 2022 21:43:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C98678E0007 for ; Sat, 24 Sep 2022 21:43:43 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 94B4B40282 for ; Sun, 25 Sep 2022 01:43:43 +0000 (UTC) X-FDA: 79948911126.14.480C507 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by imf03.hostedemail.com (Postfix) with ESMTP id 1471F20004 for ; Sun, 25 Sep 2022 01:43:42 +0000 (UTC) Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1664070220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4WXzLSYTukyduxymcxvBjNdNw/QHJy+xi6+TnpxtGIM=; b=m8kKGGgphu59i/ommAnhzqGoS4nnOgVqCBVLFxqa3W4mhI3XPVa6npODzCKdCnrKX99M5E PetI1lwRWDcjo8x0wA9mx8KSOGwcMccNjXtXYM5mqHyIY1dTq1Wjb5jW3BciUUCzVUDSFM if0SrB7G1yWVsC6pFBU4rp70vzCsArI= MIME-Version: 1.0 Subject: Re: [PATCH] mm: fix misuse of update_mmu_cache() in do_anonymous_page() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20220924053239.91661-1-zhengqi.arch@bytedance.com> Date: Sun, 25 Sep 2022 09:43:34 +0800 Cc: Andrew Morton , Linux MM , linux-kernel@vger.kernel.org, chris@zankel.net, jcmvbkbc@gmail.com, maobibo@loongson.cn Content-Transfer-Encoding: quoted-printable Message-Id: <3A09E40A-E2C5-4C6F-8550-DD0E17B7DAB9@linux.dev> References: <20220924053239.91661-1-zhengqi.arch@bytedance.com> To: Qi Zheng X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664070223; a=rsa-sha256; cv=none; b=m7U03MfhMGLcplb4jeoB5n2sFC1HcV5D5aJW/vK6UFuxTIN3HK3RY3EfZP35jvXy4dopoe AsUCaBvRNM+swRi5Ub2RK6ZCCnrtoI5Jh6AYAN1NArz12GuuIUICiWbUQsCcSjuu32mdBD 4n7dYIZYXh837CC50uQXkPtgZSopoHo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=m8kKGGgp; spf=pass (imf03.hostedemail.com: domain of muchun.song@linux.dev designates 91.121.223.63 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664070223; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4WXzLSYTukyduxymcxvBjNdNw/QHJy+xi6+TnpxtGIM=; b=VG9BvaKW4jnGWJrasWoLOgpAzlbHyO3g3T/OJUrEBYblV8CTFYTE2qespWMRhczG6UI181 o16klcV1SbBz0CVjmvcRwun0kNmW716pc+2bAKbrvc3OpHQYoJ6kMdgqvOT0bxmY4nWz+g 5CLIvBq4yiv+Zy5V2ujttEih/X8MDEo= X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1471F20004 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=m8kKGGgp; spf=pass (imf03.hostedemail.com: domain of muchun.song@linux.dev designates 91.121.223.63 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Rspam-User: X-Stat-Signature: jci3kymy54ht6xo39b5dnko9hyr1cuoq X-HE-Tag: 1664070222-629790 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Sep 24, 2022, at 13:32, Qi Zheng = wrote: >=20 > As message in commit 7df676974359 ("mm/memory.c: Update local TLB > if PTE entry exists") said, we should update local TLB only on the > second thread. So fix the misuse of update_mmu_cache() by using > update_mmu_tlb() in the do_anonymous_page(). >=20 > Signed-off-by: Qi Zheng The change looks good to me. However, I am not sure what is the = user-visible effect to xtensa users. So Cc xtensa=E2=80=99s maintainer and the author = of 7df676974359 to double check this. But anyway: Reviewed-by: Muchun Song